You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "sarutak (via GitHub)" <gi...@apache.org> on 2026/01/15 11:15:41 UTC
[PR] [SPARK-55045][CORE][TESTS] Fix a flaky test in ExecutorSuite [spark]
sarutak opened a new pull request, #53814:
URL: https://github.com/apache/spark/pull/53814
### What changes were proposed in this pull request?
This PR fixes a flaky test `SPARK-33587: isFatalError` in `ExecutorSuite`.
Recnetly, this test occasionally fails.
https://github.com/apache/spark/actions/runs/20850209017/job/59903273573#step:10:4885
```
[info] - SPARK-33587: isFatalError *** FAILED *** (30 milliseconds)
[info] false did not equal true (ExecutorSuite.scala:516)
[info] org.scalatest.exceptions.TestFailedException:
[info] at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
[info] at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
[info] at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231)
[info] at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295)
[info] at org.apache.spark.executor.ExecutorSuite.testThrowable$1(ExecutorSuite.scala:516)
[info] at org.apache.spark.executor.ExecutorSuite.$anonfun$new$38(ExecutorSuite.scala:528)
[info] at scala.collection.immutable.Range.foreach$mVc$sp(Range.scala:256)
[info] at org.apache.spark.executor.ExecutorSuite.$anonfun$new$33(ExecutorSuite.scala:527)
[info] at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
[info] at org.scalatest.enablers.Timed$$anon$1.timeoutAfter(Timed.scala:127)
[info] at org.scalatest.concurrent.TimeLimits$.failAfterImpl(TimeLimits.scala:282)
[info] at org.scalatest.concurrent.TimeLimits.failAfter(TimeLimits.scala:231)
[info] at org.scalatest.concurrent.TimeLimits.failAfter$(TimeLimits.scala:230)
[info] at org.apache.spark.SparkFunSuite.failAfter(SparkFunSuite.scala:68)
[info] at org.apache.spark.SparkFunSuite.$anonfun$test$2(SparkFunSuite.scala:154)
[info] at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
[info] at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
[info] at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
[info] at org.scalatest.Transformer.apply(Transformer.scala:22)
[info] at org.scalatest.Transformer.apply(Transformer.scala:20)
[info] at org.scalatest.funsuite.AnyFunSuiteLike$$anon$1.apply(AnyFunSuiteLike.scala:226)
[info] at org.apache.spark.SparkFunSuite.withFixture(SparkFunSuite.scala:226)
[info] at org.scalatest.funsuite.AnyFunSuiteLike.invokeWithFixture$1(AnyFunSuiteLike.scala:224)
[info] at org.scalatest.funsuite.AnyFunSuiteLike.$anonfun$runTest$1(AnyFunSuiteLike.scala:236)
[info] at org.scalatest.SuperEngine.runTestImpl(Engine.scala:306)
[info] at org.scalatest.funsuite.AnyFunSuiteLike.runTest(AnyFunSuiteLike.scala:236)
[info] at org.scalatest.funsuite.AnyFunSuiteLike.runTest$(AnyFunSuiteLike.scala:218)
[info] at org.apache.spark.SparkFunSuite.org$scalatest$BeforeAndAfterEach$$super$runTest(SparkFunSuite.scala:68)
[info] at org.scalatest.BeforeAndAfterEach.runTest(BeforeAndAfterEach.scala:234)
[info] at org.scalatest.BeforeAndAfterEach.runTest$(BeforeAndAfterEach.scala:227)
[info] at org.apache.spark.SparkFunSuite.runTest(SparkFunSuite.scala:68)
[info] at org.scalatest.funsuite.AnyFunSuiteLike.$anonfun$runTests$1(AnyFunSuiteLike.scala:269)
[info] at org.scalatest.SuperEngine.$anonfun$runTestsInBranch$1(Engine.scala:413)
[info] at scala.collection.immutable.List.foreach(List.scala:323)
[info] at org.scalatest.SuperEngine.traverseSubNodes$1(Engine.scala:401)
[info] at org.scalatest.SuperEngine.runTestsInBranch(Engine.scala:396)
[info] at org.scalatest.SuperEngine.runTestsImpl(Engine.scala:475)
[info] at org.scalatest.funsuite.AnyFunSuiteLike.runTests(AnyFunSuiteLike.scala:269)
[info] at org.scalatest.funsuite.AnyFunSuiteLike.runTests$(AnyFunSuiteLike.scala:268)
[info] at org.scalatest.funsuite.AnyFunSuite.runTests(AnyFunSuite.scala:1564)
[info] at org.scalatest.Suite.run(Suite.scala:1114)
[info] at org.scalatest.Suite.run$(Suite.scala:1096)
[info] at org.scalatest.funsuite.AnyFunSuite.org$scalatest$funsuite$AnyFunSuiteLike$$super$run(AnyFunSuite.scala:1564)
[info] at org.scalatest.funsuite.AnyFunSuiteLike.$anonfun$run$1(AnyFunSuiteLike.scala:273)
[info] at org.scalatest.SuperEngine.runImpl(Engine.scala:535)
[info] at org.scalatest.funsuite.AnyFunSuiteLike.run(AnyFunSuiteLike.scala:273)
[info] at org.scalatest.funsuite.AnyFunSuiteLike.run$(AnyFunSuiteLike.scala:272)
[info] at org.apache.spark.SparkFunSuite.org$scalatest$BeforeAndAfterAll$$super$run(SparkFunSuite.scala:68)
[info] at org.scalatest.BeforeAndAfterAll.liftedTree1$1(BeforeAndAfterAll.scala:213)
[info] at org.scalatest.BeforeAndAfterAll.run(BeforeAndAfterAll.scala:210)
[info] at org.scalatest.BeforeAndAfterAll.run$(BeforeAndAfterAll.scala:208)
[info] at org.apache.spark.SparkFunSuite.run(SparkFunSuite.scala:68)
[info] at org.scalatest.tools.Framework.org$scalatest$tools$Framework$$runSuite(Framework.scala:321)
[info] at org.scalatest.tools.Framework$ScalaTestTask.execute(Framework.scala:517)
[info] at sbt.ForkMain$Run.lambda$runTest$1(ForkMain.java:414)
[info] at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[info] at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
[info] at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
[info] at java.base/java.lang.Thread.run(Thread.java:840)
```
This issue happens like as follows.
1. [testThrowable](https://github.com/apache/spark/blob/a03bedb6c1281c5263a42bfd20608d2ee005ab05/core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala#L529) is invoked with `InterruptedException`
2. `InterruptedException` is passed to [errorInGuavaCache](https://github.com/apache/spark/blob/a03bedb6c1281c5263a42bfd20608d2ee005ab05/core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala#L511)
3. [Cache#get](https://github.com/apache/spark/blob/a03bedb6c1281c5263a42bfd20608d2ee005ab05/core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala#L498) is invoked. The actual class is [LocalCache.LocalLoadingCache](https://github.com/google/guava/blob/f06690fa3e874f65515e8fd338a74d636e2c792f/guava/src/com/google/common/cache/CacheBuilder.java#L1032)
4. The flow reaches [this line](https://github.com/google/guava/blob/f06690fa3e874f65515e8fd338a74d636e2c792f/guava/src/com/google/common/cache/LocalCache.java#L3570) and the interrupted status is set for the current Thread
5. Escaped from `errorInGuavaCache`, and at the next round of the loop, [errorInThreadPool](https://github.com/apache/spark/blob/a03bedb6c1281c5263a42bfd20608d2ee005ab05/core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala#L517) is invoked
6. Through [f.get()](https://github.com/apache/spark/blob/a03bedb6c1281c5263a42bfd20608d2ee005ab05/core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala#L485), [FutureTask#awaitDone](https://github.com/openjdk/jdk/blob/dfacda488bfbe2e11e8d607a6d08527710286982/src/java.base/share/classes/java/util/concurrent/FutureTask.java#L393) is invoked.
7. If the future task is immediately done, the flow reaches [this line](https://github.com/openjdk/jdk/blob/dfacda488bfbe2e11e8d607a6d08527710286982/src/java.base/share/classes/java/util/concurrent/FutureTask.java#L410), that issue doesn't occur otherwise the flow reaches [this line](https://github.com/openjdk/jdk/blob/dfacda488bfbe2e11e8d607a6d08527710286982/src/java.base/share/classes/java/util/concurrent/FutureTask.java#L418) because the interrupted status is set. Then, `InterruptedException` is thrown without the causes.
8. `InterruptedException` is not a fatal error so if `testThrowable` is invoked with `isFatal = true` this issue occurs.
This issue can be reproducible by changing `ExecutorSuite.scala` like as follows.
```
diff --git a/core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala b/core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala
index dd9884bffb2..42a656cc88b 100644
--- a/core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala
+++ b/core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala
@@ -482,6 +482,8 @@ class ExecutorSuite extends SparkFunSuite
val f = taskPool.submit(new java.util.concurrent.Callable[String] {
override def call(): String = throw e
})
+ // Time consuming task which doesn't clear the interrupted status.
+ Array.fill(10000)(Math.random())
f.get()
} finally {
taskPool.shutdown()
@@ -514,7 +516,12 @@ class ExecutorSuite extends SparkFunSuite
depthToCheck) == (depthToCheck >= 2 && isFatal))
// `e`'s depth is 3 so `depthToCheck` needs to be at least 3 to detect fatal errors.
assert(isFatalError(
- errorInThreadPool(errorInGuavaCache(e)),
+ errorInThreadPool({
+ if (isFatal) {
+ Thread.sleep(100)
+ }
+ errorInGuavaCache(e)
+ }),
```
To fix the issue, this PR clear the interrupted status after `cache.get` in `errorInGuavaCache`.
### Why are the changes needed?
For test stability.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Confirmed the test passed even if `ExecutorSuite.scala` is changed like mentioned above.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55045][CORE][TESTS] Fix a flaky test in ExecutorSuite [spark]
Posted by "Ngone51 (via GitHub)" <gi...@apache.org>.
Ngone51 commented on PR #53814:
URL: https://github.com/apache/spark/pull/53814#issuecomment-3777932765
My concern is that, althought both `ExecutionException` and `InterruptedException` are non-fatal, is there a case we consider the execption is non-fatal becasue of `ExecutionException` rather than `InterruptedException` (which I think is an unexpected behaviour)?
Checking the `Executor.isFatalError()`, it looks like when depthToCheck < 2, `isFatalError` returns false because of `depthToCheck <= 0`. And only when `depthToCheck >= 2`, the cause (i.e., `InterruptedException`) is really verified by `isFatalError()` as non-fatal. I think this is what you meant(?). And my concern is invalid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55045][CORE][TESTS] Fix a flaky test in ExecutorSuite [spark]
Posted by "Ngone51 (via GitHub)" <gi...@apache.org>.
Ngone51 closed pull request #53814: [SPARK-55045][CORE][TESTS] Fix a flaky test in ExecutorSuite
URL: https://github.com/apache/spark/pull/53814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55045][CORE][TESTS] Fix a flaky test in ExecutorSuite [spark]
Posted by "Ngone51 (via GitHub)" <gi...@apache.org>.
Ngone51 commented on PR #53814:
URL: https://github.com/apache/spark/pull/53814#issuecomment-3776886446
> errorInGuavaCache() is called only when checking [depthToCheck >= 2](https://github.com/apache/spark/blob/a03bedb6c1281c5263a42bfd20608d2ee005ab05/core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala#L511) or depthToCheck >= 3
Isn't it called from depth 0 to 5?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55045][CORE][TESTS] Fix a flaky test in ExecutorSuite [spark]
Posted by "Ngone51 (via GitHub)" <gi...@apache.org>.
Ngone51 commented on PR #53814:
URL: https://github.com/apache/spark/pull/53814#issuecomment-3776485699
> Then, [future.get](https://github.com/google/guava/blob/f06690fa3e874f65515e8fd338a74d636e2c792f/guava/src/com/google/common/util/concurrent/Uninterruptibles.java#L246) throws ExecutionException which wraps InterruptedException.
@sarutak I see. That make senses.
But that's actually not intended by `errorInGuavaCache()`, right? What `errorInGuavaCache()` really expects is `InterruptedException`. Shall we also fix it to check the wrapped `InterruptedException`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55045][CORE][TESTS] Fix a flaky test in ExecutorSuite [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #53814:
URL: https://github.com/apache/spark/pull/53814#issuecomment-3773052419
@Ngone51
`InterruptedException` is swallowed by step 4 but `Thread.currentThread().interrupt();` sets interrupted status. It affects step 7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55045][CORE][TESTS] Fix a flaky test in ExecutorSuite [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #53814:
URL: https://github.com/apache/spark/pull/53814#issuecomment-3776909034
@Ngone51
> Isn't it called from depth 0 to 5?
Yes, but `errorInGuavaCache()` is called when checking the case `depthToCheck >= 2` and `depthToCheck >= 3`.
https://github.com/apache/spark/blob/a03bedb6c1281c5263a42bfd20608d2ee005ab05/core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala#L511
https://github.com/apache/spark/blob/a03bedb6c1281c5263a42bfd20608d2ee005ab05/core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala#L517
https://github.com/apache/spark/blob/a03bedb6c1281c5263a42bfd20608d2ee005ab05/core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala#L520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55045][CORE][TESTS] Fix a flaky test in ExecutorSuite [spark]
Posted by "Ngone51 (via GitHub)" <gi...@apache.org>.
Ngone51 commented on PR #53814:
URL: https://github.com/apache/spark/pull/53814#issuecomment-3773064023
@sarutak Yea. I understand how it affect step 7 later. I just wonder `errorInGuavaCache` expects an exception to throw but was swallowed by step4, shouldn't `intercept[Throwable]` fail if there is no more exception throw?
```scala
def errorInGuavaCache(e: => Throwable): Throwable = {
val cache = CacheBuilder.newBuilder()
.build(new CacheLoader[String, String] {
override def load(key: String): String = throw e
})
intercept[Throwable] {
cache.get("test")
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55045][CORE][TESTS] Fix a flaky test in ExecutorSuite [spark]
Posted by "Ngone51 (via GitHub)" <gi...@apache.org>.
Ngone51 commented on PR #53814:
URL: https://github.com/apache/spark/pull/53814#issuecomment-3776964839
Isn't `errorInGuavaCache()` a function call? And `isFatalError(t: Throwable, depthToCheck: Int)` also accpet the `Throwable` directly rather than a function parameter or by-name parameter. So they should execute immediately. I saw the conditions `depthToCheck >= 2` and `depthToCheck >= 3`. But, shouldn't `errorInGuavaCache()` also be called when `depthToCheck < 2`? I'm confused. Did I miss something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55045][CORE][TESTS] Fix a flaky test in ExecutorSuite [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #53814:
URL: https://github.com/apache/spark/pull/53814#issuecomment-3773232595
@Ngone51
`InterruptedException` in step 4 is not only swallowed but also set to the result [here](https://github.com/google/guava/blob/f06690fa3e874f65515e8fd338a74d636e2c792f/guava/src/com/google/common/cache/LocalCache.java#L3568).
Then, [future.get](https://github.com/google/guava/blob/f06690fa3e874f65515e8fd338a74d636e2c792f/guava/src/com/google/common/util/concurrent/Uninterruptibles.java#L246) throws `ExecutionException` which wraps `InterruptedException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55045][CORE][TESTS] Fix a flaky test in ExecutorSuite [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #53814:
URL: https://github.com/apache/spark/pull/53814#issuecomment-3777408695
@Ngone51
> But, shouldn't errorInGuavaCache() also be called when depthToCheck < 2?
`errorInGuavaCache()` is called even when the arg `depthToheck` < 2 but what is the problem?
I don't understand what's your concern. Could you tell me a problematic scenario?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55045][CORE][TESTS] Fix a flaky test in ExecutorSuite [spark]
Posted by "Ngone51 (via GitHub)" <gi...@apache.org>.
Ngone51 commented on PR #53814:
URL: https://github.com/apache/spark/pull/53814#issuecomment-3778564041
Thanks, merged to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55045][CORE][TESTS] Fix a flaky test in ExecutorSuite [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #53814:
URL: https://github.com/apache/spark/pull/53814#issuecomment-3776546353
@Ngone51
> What errorInGuavaCache() really expects is InterruptedException. Shall we also fix it to check the wrapped InterruptedException?
`errorInGuavaCache()` is called only when [depthToCheck >= 2](https://github.com/apache/spark/blob/a03bedb6c1281c5263a42bfd20608d2ee005ab05/core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala#L511) and `InterruptedException` is expected as a [cause](https://github.com/apache/spark/blob/a03bedb6c1281c5263a42bfd20608d2ee005ab05/core/src/main/scala/org/apache/spark/executor/Executor.scala#L1434).
So, that part works as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55045][CORE][TESTS] Fix a flaky test in ExecutorSuite [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #53814:
URL: https://github.com/apache/spark/pull/53814#issuecomment-3754234607
## JIRA Issue Information
=== Bug SPARK-55045 ===
Summary: Fix a flaky test in ExecutorSuite
Assignee: None
Status: Open
Affected: ["4.2.0"]
---
*This comment was automatically generated by GitHub Actions*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55045][CORE][TESTS] Fix a flaky test in ExecutorSuite [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #53814:
URL: https://github.com/apache/spark/pull/53814#issuecomment-3783297861
Thank you @Ngone51 and @yaooqinn for reviewing.
To @Ngone51
> And only when depthToCheck >= 2, the cause (i.e., InterruptedException) is really verified by isFatalError() as non-fatal. I think this is what you meant(?)
Yes. It's as expected that `errorInGuavaCache(e)` returns `ExecutionException` which wraps `e`. So assertions in the test considers such cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org