[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #707: [MINOR] fix: tempdir annotated variable should be referred in BeforeAll method

["advancedxy (via GitHub)" <gi...@apache.org>]

advancedxy commented on code in PR #707:
URL: https://github.com/apache/incubator-uniffle/pull/707#discussion_r1132194195


##########
integration-test/common/src/test/java/org/apache/uniffle/test/DiskErrorToleranceTest.java:
##########
@@ -56,14 +56,15 @@
 public class DiskErrorToleranceTest extends ShuffleReadWriteBase {
   private ShuffleServerGrpcClient shuffleServerClient;
 
-  @TempDir private static File serverTmpDir;
-  private static File data1 = new File(serverTmpDir, "data1");

Review Comment:
   serverTmpDir is injected after static variable initialization



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org