You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/18 09:34:14 UTC
[GitHub] [pulsar] Technoboy- commented on a diff in pull request #15120: [improve][Rest api]Remove duplication validateTopicOwnershipAsync
Technoboy- commented on code in PR #15120:
URL: https://github.com/apache/pulsar/pull/15120#discussion_r852003864
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -1725,11 +1726,7 @@ protected void internalSkipAllMessages(AsyncResponse asyncResponse, String subNa
private CompletableFuture<Void> internalSkipAllMessagesForNonPartitionedTopicAsync(AsyncResponse asyncResponse,
String subName,
boolean authoritative) {
- return validateTopicOwnershipAsync(topicName, authoritative)
- .thenCompose(__ ->
- validateTopicOperationAsync(topicName, TopicOperation.SKIP, subName))
- .thenCompose(__ ->
Review Comment:
Why remove `validateTopicOperationAsync`
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -1147,10 +1150,8 @@ private void resumeAsyncResponse(AsyncResponse asyncResponse, Set<String> subscr
});
}
- private void internalGetSubscriptionsForNonPartitionedTopic(AsyncResponse asyncResponse, boolean authoritative) {
- validateTopicOwnershipAsync(topicName, authoritative)
- .thenCompose(__ -> validateTopicOperationAsync(topicName, TopicOperation.GET_SUBSCRIPTIONS))
- .thenCompose(__ -> getTopicReferenceAsync(topicName))
Review Comment:
Why remove `validateTopicOperationAsync`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org