You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/09/14 04:42:56 UTC

[GitHub] [echarts] quillblue commented on pull request #15601: Add support for StreamGraph algorithm#14643

quillblue commented on pull request #15601:
URL: https://github.com/apache/echarts/pull/15601#issuecomment-918796415


   LGTM on the whole, with following minor items to be considered:
   - Coding format (unnecessary empty line)
   - Not sure whether it is proper to use `List` instead of `SeriesData` here (need input from @pissang ) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org