You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by bs...@apache.org on 2018/04/09 20:55:35 UTC

[geode] branch develop updated: GEODE-3820 CI failure: DataSerializerPropogationDUnitTest.testDataSerializersEventIdVerification

This is an automated email from the ASF dual-hosted git repository.

bschuchardt pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/develop by this push:
     new e47df10  GEODE-3820 CI failure: DataSerializerPropogationDUnitTest.testDataSerializersEventIdVerification
e47df10 is described below

commit e47df106431c693a0b704e1364627a61d875ba66
Author: Bruce Schuchardt <bs...@pivotal.io>
AuthorDate: Mon Apr 9 13:52:11 2018 -0700

    GEODE-3820 CI failure: DataSerializerPropogationDUnitTest.testDataSerializersEventIdVerification
    
    This was actually fixed in 5fe3c76d6b1a595c250d924d0115e20f2491cd2a but the
    flakytest categorization wasn't removed from the test.  I also added a bounce()
    of one of the VMs in a test that would fail if the test is accidentally run
    multiple times.
---
 .../tier/sockets/DataSerializerPropagationDUnitTest.java | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/DataSerializerPropagationDUnitTest.java b/geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/DataSerializerPropagationDUnitTest.java
index 9c6f608..f6367b6 100644
--- a/geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/DataSerializerPropagationDUnitTest.java
+++ b/geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/DataSerializerPropagationDUnitTest.java
@@ -14,8 +14,13 @@
  */
 package org.apache.geode.internal.cache.tier.sockets;
 
-import static org.apache.geode.distributed.ConfigurationProperties.*;
-import static org.junit.Assert.*;
+import static org.apache.geode.distributed.ConfigurationProperties.LOCATORS;
+import static org.apache.geode.distributed.ConfigurationProperties.MCAST_PORT;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
 
 import java.io.DataInput;
 import java.io.DataOutput;
@@ -41,7 +46,6 @@ import org.apache.geode.cache.client.internal.PoolImpl;
 import org.apache.geode.cache.server.CacheServer;
 import org.apache.geode.cache30.CacheSerializableRunnable;
 import org.apache.geode.distributed.DistributedSystem;
-import org.apache.geode.distributed.internal.InternalLocator;
 import org.apache.geode.internal.AvailablePort;
 import org.apache.geode.internal.InternalDataSerializer;
 import org.apache.geode.internal.cache.CacheServerImpl;
@@ -60,9 +64,9 @@ import org.apache.geode.test.dunit.WaitCriterion;
 import org.apache.geode.test.dunit.internal.JUnit4DistributedTestCase;
 import org.apache.geode.test.junit.categories.ClientServerTest;
 import org.apache.geode.test.junit.categories.DistributedTest;
-import org.apache.geode.test.junit.categories.FlakyTest;
+import org.apache.geode.test.junit.categories.SerializationTest;
 
-@Category({DistributedTest.class, ClientServerTest.class, FlakyTest.class})
+@Category({DistributedTest.class, ClientServerTest.class, SerializationTest.class})
 public class DataSerializerPropagationDUnitTest extends JUnit4DistributedTestCase {
   private static Cache cache = null;
 
@@ -638,6 +642,8 @@ public class DataSerializerPropagationDUnitTest extends JUnit4DistributedTestCas
     PORT1 = initServerCache(server1);
     PORT2 = initServerCache(server2);
 
+    client2.bounce();
+
     client1.invoke(() -> DataSerializerPropagationDUnitTest
         .createClientCache(NetworkUtils.getServerHostName(server1.getHost()), new Integer(PORT1)));
     client2.invoke(() -> DataSerializerPropagationDUnitTest

-- 
To stop receiving notification emails like this one, please contact
bschuchardt@apache.org.