You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/06/12 03:59:20 UTC

[GitHub] [commons-codec] kinow commented on pull request #135: Fix byte-skipping described in CODEC-305

kinow commented on PR #135:
URL: https://github.com/apache/commons-codec/pull/135#issuecomment-1153064455

   > Thank you for the quick response. It looks like builds on the master branch were already failing before my changes with the same error (see [here](https://github.com/apache/commons-codec/commit/89cb9572ccdff84082c37e14c49d4ac6cb32f4f5) for example). I was also able to reproduce it locally, both with and without my changes. Should I perhaps use another branch for the pull request?
   
   Ah, thanks for looking into that @gpsfl . In that case we should fix the build and rebase this one to confirm these changes work as well. Feel free to wait until someone else steps in and fixes the build (or if you have spare time and feel like fixing that, pull requests are always welcome, though sometimes it can be tricky to figure out how to fix the build).
   
   Bruno


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org