You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by ro...@apache.org on 2015/09/24 11:38:45 UTC
svn commit: r1705021 - in /sling/trunk/testing/mocks/sling-mock/src:
main/java/org/apache/sling/testing/mock/sling/servlet/MockSlingHttpServletRequest.java
test/java/org/apache/sling/testing/mock/sling/servlet/MockSlingHttpServletRequestTest.java
Author: rombert
Date: Thu Sep 24 09:38:44 2015
New Revision: 1705021
URL: http://svn.apache.org/viewvc?rev=1705021&view=rev
Log:
SLING-5057 - Support HttpServletRequest#getRemoteUser
Implementation and tests
Modified:
sling/trunk/testing/mocks/sling-mock/src/main/java/org/apache/sling/testing/mock/sling/servlet/MockSlingHttpServletRequest.java
sling/trunk/testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/servlet/MockSlingHttpServletRequestTest.java
Modified: sling/trunk/testing/mocks/sling-mock/src/main/java/org/apache/sling/testing/mock/sling/servlet/MockSlingHttpServletRequest.java
URL: http://svn.apache.org/viewvc/sling/trunk/testing/mocks/sling-mock/src/main/java/org/apache/sling/testing/mock/sling/servlet/MockSlingHttpServletRequest.java?rev=1705021&r1=1705020&r2=1705021&view=diff
==============================================================================
--- sling/trunk/testing/mocks/sling-mock/src/main/java/org/apache/sling/testing/mock/sling/servlet/MockSlingHttpServletRequest.java (original)
+++ sling/trunk/testing/mocks/sling-mock/src/main/java/org/apache/sling/testing/mock/sling/servlet/MockSlingHttpServletRequest.java Thu Sep 24 09:38:44 2015
@@ -96,6 +96,7 @@ public class MockSlingHttpServletRequest
private String contentType;
private String characterEncoding;
private byte[] content;
+ private String remoteUser;
private MockRequestDispatcherFactory requestDispatcherFactory;
private static final ResourceBundle EMPTY_RESOURCE_BUNDLE = new ListResourceBundle() {
@@ -605,6 +606,14 @@ public class MockSlingHttpServletRequest
this.requestDispatcherFactory = requestDispatcherFactory;
}
+ @Override
+ public String getRemoteUser() {
+ return remoteUser;
+ }
+
+ public void setRemoteUser(String remoteUser) {
+ this.remoteUser = remoteUser;
+ }
// --- unsupported operations ---
@@ -638,11 +647,6 @@ public class MockSlingHttpServletRequest
throw new UnsupportedOperationException();
}
- @Override
- public String getRemoteUser() {
- throw new UnsupportedOperationException();
- }
-
@Override
public String getRequestURI() {
throw new UnsupportedOperationException();
Modified: sling/trunk/testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/servlet/MockSlingHttpServletRequestTest.java
URL: http://svn.apache.org/viewvc/sling/trunk/testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/servlet/MockSlingHttpServletRequestTest.java?rev=1705021&r1=1705020&r2=1705021&view=diff
==============================================================================
--- sling/trunk/testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/servlet/MockSlingHttpServletRequestTest.java (original)
+++ sling/trunk/testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/servlet/MockSlingHttpServletRequestTest.java Thu Sep 24 09:38:44 2015
@@ -320,4 +320,13 @@ public class MockSlingHttpServletRequest
request.getRequestDispatcher("/path");
}
+ @Test
+ public void testGetRemoteUserN() {
+
+ assertNull(null, request.getRemoteUser());
+
+ request.setRemoteUser("admin");
+ assertEquals("admin", request.getRemoteUser());
+ }
+
}