You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2014/12/19 01:36:28 UTC
[GitHub] incubator-brooklyn pull request: docs - tuning of merged website a...
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/408
docs - tuning of merged website and guide
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn docs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/408.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #408
----
commit 4dc23aa0d4731e778df3ad9e5ef222ef43a8ec9d
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-12-18T12:59:16Z
refactor docs (no content or style changes)
inherit from a common base, move footer to an inclue, add comments to CSS for readability, and introduce a guide-base from which guide-normal inherits
commit 09c98bd4c31d1025e3b9e6d1507c4287535d454e
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-12-18T15:00:08Z
combining style sheets and layouts, esp for user guide
user guide now has the same top+bottom branding as rest of site
commit 2534d5b3664ad574014b200b97b10207d67b5b5f
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-12-18T21:40:54Z
add icon links for twitter, github, and IRC; and use scss, because jekyll allows
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: docs - tuning of merged website a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/408
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: docs - tuning of merged website a...
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/408#issuecomment-67825024
Reviewing now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: docs - tuning of merged website a...
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/408#discussion_r22162236
--- Diff: docs/_includes/topmenu.html ---
@@ -0,0 +1,55 @@
+<nav class="navbar navbar-default navbar-fixed-top" id="header" role="navigation">
+ <div class="container">
+
+ <div id="navbar-icons-extra">
+ <a href="https://github.com/apache/incubator-brooklyn" class="navbar-icon navbar-icon-shift icon-github"
+ data-toggle="tooltip" data-placement="bottom" title="GitHub: apache/incubator-brooklyn" data-delay="400"/>
+ <a href="https://twitter.com/#!/search?q=brooklyncentral" class="navbar-icon navbar-icon-shift icon-twitter"
--- End diff --
The Twitter link is to a *search* for the term `brooklyncentral` - is that what you intended?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: docs - tuning of merged website a...
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/408#issuecomment-67826594
Looking very good - really like that the user guide is adopting the main website style! One comment about the Twitter icon link however (see above).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---