You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by cs...@apache.org on 2012/10/04 16:55:12 UTC

svn commit: r1394103 - /karaf/trunk/features/core/src/main/java/org/apache/karaf/features/internal/FeaturesServiceImpl.java

Author: cschneider
Date: Thu Oct  4 14:55:11 2012
New Revision: 1394103

URL: http://svn.apache.org/viewvc?rev=1394103&view=rev
Log:
KARAF-1889 Change logging of bundle start to debug and feature installs to info. Also log installed bundles

Modified:
    karaf/trunk/features/core/src/main/java/org/apache/karaf/features/internal/FeaturesServiceImpl.java

Modified: karaf/trunk/features/core/src/main/java/org/apache/karaf/features/internal/FeaturesServiceImpl.java
URL: http://svn.apache.org/viewvc/karaf/trunk/features/core/src/main/java/org/apache/karaf/features/internal/FeaturesServiceImpl.java?rev=1394103&r1=1394102&r2=1394103&view=diff
==============================================================================
--- karaf/trunk/features/core/src/main/java/org/apache/karaf/features/internal/FeaturesServiceImpl.java (original)
+++ karaf/trunk/features/core/src/main/java/org/apache/karaf/features/internal/FeaturesServiceImpl.java Thu Oct  4 14:55:11 2012
@@ -400,7 +400,7 @@ public class FeaturesServiceImpl impleme
             bundleManager.refreshBundles(state.bundles, state.installed, options);
             // Start all bundles
             for (Bundle b : state.bundles) {
-                LOGGER.info("Starting bundle: {}", b.getSymbolicName());
+                LOGGER.debug("Starting bundle: {}", b.getSymbolicName());
                 startBundle(state, b);
             }
             // Clean up for batch
@@ -481,9 +481,10 @@ public class FeaturesServiceImpl impleme
 	}
 
     protected void doInstallFeature(InstallationState state, Feature feature, boolean verbose) throws Exception {
-        LOGGER.debug("Installing feature " + feature.getName() + " " + feature.getVersion());
+        String msg = "Installing feature " + feature.getName() + " " + feature.getVersion();
+        LOGGER.info(msg);
         if (verbose) {
-            System.out.println("Installing feature " + feature.getName() + " " + feature.getVersion());
+            System.out.println(msg);
         }
         for (Dependency dependency : feature.getDependencies()) {
             installFeatureDependency(dependency, state, verbose);
@@ -500,12 +501,10 @@ public class FeaturesServiceImpl impleme
             if (result.isNew) {
                 state.installed.add(result.bundle);
             }
+            String msg2 = (result.isNew) ? "Found installed bundle: " + result.bundle : "Installing bundle " + bInfo.getLocation();
+            LOGGER.debug(msg2);
             if (verbose) {
-                if (result.isNew) {
-                    System.out.println("Found installed bundle: " + result.bundle);
-                } else {
-                    System.out.println("Installing bundle " + bInfo.getLocation());
-                }
+                System.out.println(msg2);
             }
 
             bundles.add(result.bundle.getBundleId());