You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/08 15:08:48 UTC

[GitHub] [apisix-ingress-controller] membphis commented on a change in pull request #66: chore: introduce a CLI interface and a Makefile.

membphis commented on a change in pull request #66:
URL: https://github.com/apache/apisix-ingress-controller/pull/66#discussion_r538476569



##########
File path: build.sh
##########
@@ -7,5 +7,5 @@ sed -i -e "s%#syslogAddress#%`echo $SYSLOG_HOST`%g" ${pwd}/conf.json
 sed -i -e "s%#apisixBaseUrl#%`echo $APISIX_BASE_URL`%g" ${pwd}/conf.json
 
 cd /root/ingress-controller
-exec ./ingress-controller
+exec ./ingress-controller ingress

Review comment:
       why we need the argument `ingress`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org