[GitHub] [iceberg] rdblue commented on a change in pull request #1255: Flink: Add Orc value reader, writer implementations

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1255:
URL: https://github.com/apache/iceberg/pull/1255#discussion_r472538071



##########
File path: data/src/main/java/org/apache/iceberg/data/orc/GenericOrcWriters.java
##########
@@ -87,7 +87,7 @@ private GenericOrcWriters() {
     return UUIDWriter.INSTANCE;
   }
 
-  public static OrcValueWriter<byte[]> fixed() {
+  public static OrcValueWriter<byte[]> bytes() {

Review comment:
       Should the `FixedWriter` class also be renamed to `BytesWriter`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org