You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/06/15 20:30:09 UTC
[GitHub] [helix] micahstubbs opened a new pull request, #2157: 2063/prettier
micahstubbs opened a new pull request, #2157:
URL: https://github.com/apache/helix/pull/2157
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
Fix #2143
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
Today, there is limited code style enforcement in helix-front, leading to unnecessary contributor toil to maintain consistent code style and formatting.
This PR adds automatic code formatting for helix-front using https://prettier.io/ and yarn scripts. This PR adds automatic formatting for JavaScript, TypeScript, JSON, and HTML files in the helix-front module.
### Tests
- [x] The following tests are written for this issue:
No new tests, tooling-only PR.
- [x] The following is the result of the "mvn test" command on the appropriate module:
There are no Maven Tests for helix-front.
### Changes that Break Backward Compatibility (Optional)
- [x] My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
No backwards incompatible changes
### Commits
- [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
### Code Quality
- [x] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
No Java code changes. This PR adds analogous code formatting for JavaScript, TypeScript, JSON, and HTML files in the helix-front module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 merged pull request #2157: Automatic code formatting for helix-front
Posted by GitBox <gi...@apache.org>.
NealSun96 merged PR #2157:
URL: https://github.com/apache/helix/pull/2157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2157: Automatic code formatting for helix-front
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2157:
URL: https://github.com/apache/helix/pull/2157#issuecomment-1157071583
This PR is ready to be merged, approved by @somecodemonkey
Final commit message:
## [Automatic code formatting for helix-front](https://github.com/apache/helix/pull/2157#) (#2063)
Add automatic formatting for JavaScript, TypeScript, JSON, CSS, and HTML files in the helix-front module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] somecodemonkey commented on pull request #2157: Automatic code formatting for helix-front
Posted by GitBox <gi...@apache.org>.
somecodemonkey commented on PR #2157:
URL: https://github.com/apache/helix/pull/2157#issuecomment-1157031642
🚢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on a diff in pull request #2157: Automatic code formatting for helix-front
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on code in PR #2157:
URL: https://github.com/apache/helix/pull/2157#discussion_r898393157
##########
helix-front/.prettierrc.json:
##########
@@ -0,0 +1 @@
+{}
Review Comment:
https://prettier.io/docs/en/options.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2157: Automatic code formatting for helix-front
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2157:
URL: https://github.com/apache/helix/pull/2157#issuecomment-1156913065
@somecodemonkey this PR is ready for your review. Thanks for sharing your frontend expertise!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on a diff in pull request #2157: Automatic code formatting for helix-front
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on code in PR #2157:
URL: https://github.com/apache/helix/pull/2157#discussion_r898393157
##########
helix-front/.prettierrc.json:
##########
@@ -0,0 +1 @@
+{}
Review Comment:
Here I recommend we accept the default options https://prettier.io/docs/en/options.html. This can be configured in the future if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org