You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "Sven Meier (JIRA)" <ji...@apache.org> on 2013/03/11 11:39:13 UTC

[jira] [Commented] (WICKET-5080) FilterToolbar.html contains javascript that is used elsewhere

    [ https://issues.apache.org/jira/browse/WICKET-5080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598697#comment-13598697 ] 

Sven Meier commented on WICKET-5080:
------------------------------------

I've left FilterForm#JS private, since this is what most other JavaScript components in wicket do. If you need the js file, you can easily reuse it with your own ResourceReference. 
                
> FilterToolbar.html contains javascript that is used elsewhere
> -------------------------------------------------------------
>
>                 Key: WICKET-5080
>                 URL: https://issues.apache.org/jira/browse/WICKET-5080
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 6.6.0
>            Reporter: Oleg Galimov
>            Assignee: Sven Meier
>            Priority: Minor
>             Fix For: 6.7.0
>
>         Attachments: 0001-patch.patch
>
>
> The file FilterToolbar.html has some JavaScript included. This is inconvenient as we have written our own FilterToolbar with its own markup and still need the JavaScript. So I propose to externalize the JavaScript as a ResourceReference. I have included a patch as a proposal.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira