[GitHub] [iceberg] ConeyLiu commented on a change in pull request #3056: Support purge for Spark 3.2

[GitBox <gi...@apache.org>]

ConeyLiu commented on a change in pull request #3056:
URL: https://github.com/apache/iceberg/pull/3056#discussion_r801210882



##########
File path: spark/v3.1/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
##########
@@ -246,8 +246,19 @@ public SparkTable alterTable(Identifier ident, TableChange... changes) throws No
   public boolean dropTable(Identifier ident) {
     try {
       return isPathIdentifier(ident) ?
-          tables.dropTable(((PathIdentifier) ident).location()) :
-          icebergCatalog.dropTable(buildIdentifier(ident));
+          tables.dropTable(((PathIdentifier) ident).location(), false) :
+          icebergCatalog.dropTable(buildIdentifier(ident), false);
+    } catch (org.apache.iceberg.exceptions.NoSuchTableException e) {
+      return false;
+    }

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org