You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "bbotella (via GitHub)" <gi...@apache.org> on 2025/04/22 17:24:55 UTC
[PR] CASSANALYTICS-30: Add Sidecar Client [cassandra-analytics]
bbotella opened a new pull request, #108:
URL: https://github.com/apache/cassandra-analytics/pull/108
Adding sidecar client to remove the artifact dependency with the Apache Sidecar artifact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-30: Add Sidecar Client [cassandra-analytics]
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh commented on PR #108:
URL: https://github.com/apache/cassandra-analytics/pull/108#issuecomment-2842941984
We will probably need to add to the https://github.com/apache/cassandra-analytics/blob/trunk/LICENSE.txt noting that the code is copied from Sidecar. Please take a look at the bottom of LICENSE.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-30: Add Sidecar Client [cassandra-analytics]
Posted by "yifan-c (via GitHub)" <gi...@apache.org>.
yifan-c commented on code in PR #108:
URL: https://github.com/apache/cassandra-analytics/pull/108#discussion_r2059218953
##########
cassandra-analytics-sidecar-client/src/main/java/org/apache/cassandra/clients/Sidecar.java:
##########
@@ -32,19 +32,19 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import o.a.c.sidecar.client.shaded.common.response.NodeSettings;
-import o.a.c.sidecar.client.shaded.io.vertx.core.Vertx;
-import o.a.c.sidecar.client.shaded.io.vertx.core.VertxOptions;
+import io.vertx.core.Vertx;
+import io.vertx.core.VertxOptions;
+import org.apache.cassandra.sidecar.common.client.SidecarInstance;
+import org.apache.cassandra.sidecar.common.client.SidecarInstanceImpl;
+import org.apache.cassandra.sidecar.common.response.NodeSettings;
+import org.apache.cassandra.sidecar.vertxclient.VertxHttpClient;
+import org.apache.cassandra.sidecar.vertxclient.VertxRequestExecutor;
Review Comment:
I think we still want to shade the sidecar client subproject and reference to the shadow jar. The idea is to embedding the sidecar client as a whole (shadow jar) w/o conflicting with any existing dependencies in analytics and spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-30: Add Sidecar Client [cassandra-analytics]
Posted by "yifan-c (via GitHub)" <gi...@apache.org>.
yifan-c commented on code in PR #108:
URL: https://github.com/apache/cassandra-analytics/pull/108#discussion_r2059218953
##########
cassandra-analytics-sidecar-client/src/main/java/org/apache/cassandra/clients/Sidecar.java:
##########
@@ -32,19 +32,19 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import o.a.c.sidecar.client.shaded.common.response.NodeSettings;
-import o.a.c.sidecar.client.shaded.io.vertx.core.Vertx;
-import o.a.c.sidecar.client.shaded.io.vertx.core.VertxOptions;
+import io.vertx.core.Vertx;
+import io.vertx.core.VertxOptions;
+import org.apache.cassandra.sidecar.common.client.SidecarInstance;
+import org.apache.cassandra.sidecar.common.client.SidecarInstanceImpl;
+import org.apache.cassandra.sidecar.common.response.NodeSettings;
+import org.apache.cassandra.sidecar.vertxclient.VertxHttpClient;
+import org.apache.cassandra.sidecar.vertxclient.VertxRequestExecutor;
Review Comment:
I think we still want to shade the sidecar client subproject and reference to the shadow jar. The idea is to embedding the sidecar client as a whole (shadow jar) w/o conflicting with any existing dependencies in analytics and spark.
Just like what we already do for cassandra-all. See `:cassandra-four-zero`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANALYTICS-30: Add Sidecar Client [cassandra-analytics]
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh commented on code in PR #108:
URL: https://github.com/apache/cassandra-analytics/pull/108#discussion_r2085055083
##########
cassandra-analytics-core/build.gradle:
##########
@@ -77,8 +77,7 @@ dependencies {
runtimeOnly(group: 'net.java.dev.jna', name: 'jna', version: "${jnaVersion}")
runtimeOnly(group: 'net.java.dev.jna', name: 'jna-platform', version: "${jnaVersion}")
- // This dependency must be built by running `scripts/build-dependencies.sh`
- api(group: "${sidecarClientGroup}", name: "${sidecarClientName}", version: "${sidecarVersion}")
Review Comment:
there's clean up to be done for these variables. I see it in the profiles + settings.gradle. It'd be useful to clean that up as part of this PR, since we are removing usage of them here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org