[GitHub] [doris] stalary commented on a diff in pull request #11840: [Enhancement](Doe) Be query es use fe generate dsl.

[GitBox <gi...@apache.org>]

stalary commented on code in PR #11840:
URL: https://github.com/apache/doris/pull/11840#discussion_r947652465


##########
be/src/vec/exec/ves_http_scan_node.cpp:
##########
@@ -124,6 +124,12 @@ Status VEsHttpScanNode::open(RuntimeState* state) {
     SCOPED_CONSUME_MEM_TRACKER(mem_tracker());
     RETURN_IF_CANCELLED(state);
 
+    std::map<std::string, std::string> properties(_properties);
+    if (properties.find(ESScanReader::KEY_QUERY_DSL) != properties.end()) {

Review Comment:
   > a little confused. Maybe you should add a comment here to point out `KEY_QUERY_DSL` in properties means we turn `enable_new_es_dsl` on in FE and we have already removed push-down predicates here.
   
   In order to pass only one field, the argument logic is controlled in FE, so let me comment it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org