[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6578: Core: Allow retrieving response headers from last request

[GitBox <gi...@apache.org>]

danielcweeks commented on code in PR #6578:
URL: https://github.com/apache/iceberg/pull/6578#discussion_r1071463846


##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -64,6 +65,7 @@ public class HTTPClient implements RESTClient {
   private final CloseableHttpClient httpClient;
   private final ObjectMapper mapper;
   private final Map<String, String> baseHeaders;
+  private Map<String, String> responseHeaders;

Review Comment:
   I don't think this is going to work since this is at the client-level and response headers are at the request-level.  We should probably follow the consumer pattern (e.g. `Consumer<Map<String, String>> responseHeaders`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org