You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iotdb.apache.org by ja...@apache.org on 2023/07/07 03:23:19 UTC
[iotdb] branch master updated: Fix authority check of altering view
This is an automated email from the ASF dual-hosted git repository.
jackietien pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iotdb.git
The following commit(s) were added to refs/heads/master by this push:
new 812d6dfc03c Fix authority check of altering view
812d6dfc03c is described below
commit 812d6dfc03c655d52c7007472e7af8e4bb56a2ec
Author: Chen YZ <43...@users.noreply.github.com>
AuthorDate: Fri Jul 7 11:23:14 2023 +0800
Fix authority check of altering view
---
.../iotdb/db/queryengine/plan/parser/ASTVisitor.java | 3 +--
.../statement/metadata/AlterTimeSeriesStatement.java | 17 ++++++++++++-----
2 files changed, 13 insertions(+), 7 deletions(-)
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/parser/ASTVisitor.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/parser/ASTVisitor.java
index ea90b6b3dd7..664c1784756 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/parser/ASTVisitor.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/parser/ASTVisitor.java
@@ -1088,10 +1088,9 @@ public class ASTVisitor extends IoTDBSqlParserBaseVisitor<Statement> {
return alterLogicalViewStatement;
} else {
- AlterTimeSeriesStatement alterTimeSeriesStatement = new AlterTimeSeriesStatement();
+ AlterTimeSeriesStatement alterTimeSeriesStatement = new AlterTimeSeriesStatement(true);
alterTimeSeriesStatement.setPath(parseFullPath(ctx.fullPath()));
parseAlterClause(ctx.alterClause(), alterTimeSeriesStatement);
- alterTimeSeriesStatement.setAlterView(true);
if (alterTimeSeriesStatement.getAlias() != null) {
throw new SemanticException("View doesn't support alias.");
}
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/metadata/AlterTimeSeriesStatement.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/metadata/AlterTimeSeriesStatement.java
index dea7ed45210..2375452a13f 100644
--- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/metadata/AlterTimeSeriesStatement.java
+++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/metadata/AlterTimeSeriesStatement.java
@@ -53,13 +53,24 @@ public class AlterTimeSeriesStatement extends Statement {
private Map<String, String> tagsMap;
private Map<String, String> attributesMap;
- private boolean isAlterView = false;
+ private final boolean isAlterView;
public AlterTimeSeriesStatement() {
super();
+ isAlterView = false;
statementType = StatementType.ALTER_TIMESERIES;
}
+ public AlterTimeSeriesStatement(boolean isAlterView) {
+ super();
+ this.isAlterView = isAlterView;
+ if (isAlterView) {
+ statementType = StatementType.ALTER_LOGICAL_VIEW;
+ } else {
+ statementType = StatementType.ALTER_TIMESERIES;
+ }
+ }
+
@Override
public List<PartialPath> getPaths() {
return Collections.singletonList(path);
@@ -117,10 +128,6 @@ public class AlterTimeSeriesStatement extends Statement {
return isAlterView;
}
- public void setAlterView(boolean alterView) {
- isAlterView = alterView;
- }
-
@Override
public <R, C> R accept(StatementVisitor<R, C> visitor, C context) {
return visitor.visitAlterTimeseries(this, context);