[GitHub] [cxf] awrb commented on a diff in pull request #981: CXF-8750: only add trailing slash if necessary when locating webjars …

[GitBox <gi...@apache.org>]

awrb commented on code in PR #981:
URL: https://github.com/apache/cxf/pull/981#discussion_r944901593


##########
rt/rs/description-swagger-ui/src/main/java/org/apache/cxf/jaxrs/swagger/ui/OsgiSwaggerUiResolver.java:
##########
@@ -32,18 +31,24 @@ public class OsgiSwaggerUiResolver extends SwaggerUiResolver {
     };
     
     private final Class<? extends Annotation> annotationBundle;
+    private FrameworkUtilWrapper frameworkUtilWrapper;

Review Comment:
   Thanks for the review @reta. Yes, the wrapper is for testability as FrameworkUtil is static. But I agree pax exam tests are a better idea than mocking OSGi. I added some but I couldn't get them to work on the main branch, due to some dependencies missing such as spring 6.0.0-M5 (I couldn't find it in central maven repo either - not sure how I can fetch these). So I opened a new PR based on 3.5.x-fixes: https://github.com/apache/cxf/pull/982
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org