You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@continuum.apache.org by ct...@apache.org on 2009/11/17 05:43:35 UTC

svn commit: r881150 - /continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java

Author: ctan
Date: Tue Nov 17 04:43:34 2009
New Revision: 881150

URL: http://svn.apache.org/viewvc?rev=881150&view=rev
Log:
fixed unit test

Modified:
    continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java

Modified: continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java
URL: http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java?rev=881150&r1=881149&r2=881150&view=diff
==============================================================================
--- continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java (original)
+++ continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java Tue Nov 17 04:43:34 2009
@@ -295,7 +295,8 @@
 
         ReleaseResult result = (ReleaseResult) releaseManager.getReleaseResults().get( "testRelease" );
 
-        if ( !result.getOutput().contains( "test/executable/mvn" ) )
+        if ( !result.getOutput().contains( "test/executable/mvn" ) && 
+                !result.getOutput().contains( "test\\executable\\mvn" ) )
         {
             fail( "Error in release:perform. Missing executable" );
         }



Re: svn commit: r881150 - /continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java

Posted by Marica Tan <ma...@gmail.com>.
Done.  Thanks :D

--
Marica

On Tue, Nov 17, 2009 at 12:55 PM, Brett Porter <br...@apache.org> wrote:

> It is probably more reliable to do result.getOutput().replace( "\\", "/"
> ).contains( "test/executable/mvn" ) in case you get something like
> "test/executable\\mvn"
>
> - Brett
>
> On 17/11/2009, at 3:43 PM, ctan@apache.org wrote:
>
> > Author: ctan
> > Date: Tue Nov 17 04:43:34 2009
> > New Revision: 881150
> >
> > URL: http://svn.apache.org/viewvc?rev=881150&view=rev
> > Log:
> > fixed unit test
> >
> > Modified:
> >
>  continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java
> >
> > Modified:
> continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java
> > URL:
> http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java?rev=881150&r1=881149&r2=881150&view=diff
> >
> ==============================================================================
> > ---
> continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java
> (original)
> > +++
> continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java
> Tue Nov 17 04:43:34 2009
> > @@ -295,7 +295,8 @@
> >
> >         ReleaseResult result = (ReleaseResult)
> releaseManager.getReleaseResults().get( "testRelease" );
> >
> > -        if ( !result.getOutput().contains( "test/executable/mvn" ) )
> > +        if ( !result.getOutput().contains( "test/executable/mvn" ) &&
> > +                !result.getOutput().contains( "test\\executable\\mvn" )
> )
> >         {
> >             fail( "Error in release:perform. Missing executable" );
> >         }
> >
> >
>
>

Re: svn commit: r881150 - /continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java

Posted by Brett Porter <br...@apache.org>.
It is probably more reliable to do result.getOutput().replace( "\\", "/" ).contains( "test/executable/mvn" ) in case you get something like "test/executable\\mvn"

- Brett

On 17/11/2009, at 3:43 PM, ctan@apache.org wrote:

> Author: ctan
> Date: Tue Nov 17 04:43:34 2009
> New Revision: 881150
> 
> URL: http://svn.apache.org/viewvc?rev=881150&view=rev
> Log:
> fixed unit test
> 
> Modified:
>    continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java
> 
> Modified: continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java
> URL: http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java?rev=881150&r1=881149&r2=881150&view=diff
> ==============================================================================
> --- continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java (original)
> +++ continuum/branches/continuum-1.3.x/continuum-release/src/test/java/org/apache/maven/continuum/release/executors/ReleaseTaskExecutorTest.java Tue Nov 17 04:43:34 2009
> @@ -295,7 +295,8 @@
> 
>         ReleaseResult result = (ReleaseResult) releaseManager.getReleaseResults().get( "testRelease" );
> 
> -        if ( !result.getOutput().contains( "test/executable/mvn" ) )
> +        if ( !result.getOutput().contains( "test/executable/mvn" ) && 
> +                !result.getOutput().contains( "test\\executable\\mvn" ) )
>         {
>             fail( "Error in release:perform. Missing executable" );
>         }
> 
>