You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "CV-Bowen (via GitHub)" <gi...@apache.org> on 2024/09/03 09:22:05 UTC
[PR] include/nuttx.h: add common align definitions for nuttx [nuttx]
CV-Bowen opened a new pull request, #13281:
URL: https://github.com/apache/nuttx/pull/13281
## Summary
1. add common align definitions for NuttX;
2. replace all the ALIGN_UP() and ALIGN_DOWN() to use common align implementation;
## Impact
Only code refactore
## Testing
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] include/nuttx.h: add common align definitions for nuttx [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #13281:
URL: https://github.com/apache/nuttx/pull/13281#issuecomment-2326699712
@tmedicci could you please consider adding a #ifndef ALIGN_UP to wrap the definition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] include/nuttx.h: add common align definitions for nuttx [nuttx]
Posted by "CV-Bowen (via GitHub)" <gi...@apache.org>.
CV-Bowen closed pull request #13281: include/nuttx.h: add common align definitions for nuttx
URL: https://github.com/apache/nuttx/pull/13281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] include/nuttx.h: add common align definitions for nuttx [nuttx]
Posted by "CV-Bowen (via GitHub)" <gi...@apache.org>.
CV-Bowen commented on PR #13281:
URL: https://github.com/apache/nuttx/pull/13281#issuecomment-2328638007
@tmedicci Hello, could you help us to modify the code? Or this is also an opensoure repo and I can crate PR to do fix this re-definition issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] include/nuttx.h: add common align definitions for nuttx [nuttx]
Posted by "CV-Bowen (via GitHub)" <gi...@apache.org>.
CV-Bowen commented on PR #13281:
URL: https://github.com/apache/nuttx/pull/13281#issuecomment-2326564908
CI Failed, because the macro `ALIGN_UP` redefined with 3rdparty code.
@acassis Could you take a look at this? Maybe we need modify the codes in esp-hal-3rdparty?
```
chip/esp-hal-3rdparty/components/bootloader_support/src/esp_image_format.c:45: error: "ALIGN_UP" redefined [-Werror]
45 | #define ALIGN_UP(num, align) (((num) + ((align) - 1)) & ~((align) - 1))
|
In file included from /Users/runner/work/nuttx/nuttx/sources/nuttx/include/arch/irq.h:36,
from /Users/runner/work/nuttx/nuttx/sources/nuttx/include/nuttx/irq.h:37,
from /Users/runner/work/nuttx/nuttx/sources/nuttx/include/nuttx/fs/fs.h:43,
from /Users/runner/work/nuttx/nuttx/sources/nuttx/include/stdio.h:34,
from /Users/runner/work/nuttx/nuttx/sources/nuttx/arch/xtensa/src/chip/esp-hal-3rdparty/components/esp_common/include/esp_err.h:10,
from /Users/runner/work/nuttx/nuttx/sources/nuttx/arch/xtensa/src/chip/esp-hal-3rdparty/components/esp_hw_support/include/esp_intr_alloc.h:11,
from /Users/runner/work/nuttx/nuttx/sources/nuttx/arch/xtensa/src/chip/esp-hal-3rdparty/components/esp_hw_support/include/esp_cpu.h:20,
from chip/esp-hal-3rdparty/components/bootloader_support/src/esp_image_format.c:8:
/Users/runner/work/nuttx/nuttx/sources/nuttx/include/nuttx/nuttx.h:49: note: this is the location of the previous definition
49 | # define ALIGN_UP(x,a) (((x) + ((a) - 1)) & ~((a) - 1))
|
cc1: all warnings being treated as errors
make[1]: *** [chip/esp-hal-3rdparty/components/bootloader_support/src/esp_image_format.o] Error 1
make[1]: Target `libarch.a' not remade because of errors.
make: *** [arch/xtensa/src/libarch.a] Error 2
make: Target `all' not remade because of errors.
/Users/runner/work/nuttx/nuttx/sources/nuttx/tools/testbuild.sh: line 378: /Users/runner/work/nuttx/nuttx/sources/nuttx/../nuttx/nuttx.manifest: No such file or directory
Normalize esp32-devkitc/wifi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] include/nuttx.h: replace all the align macros to nuttx version [nuttx]
Posted by "GUIDINGLI (via GitHub)" <gi...@apache.org>.
GUIDINGLI merged PR #13281:
URL: https://github.com/apache/nuttx/pull/13281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] include/nuttx.h: add common align definitions for nuttx [nuttx]
Posted by "CV-Bowen (via GitHub)" <gi...@apache.org>.
CV-Bowen commented on PR #13281:
URL: https://github.com/apache/nuttx/pull/13281#issuecomment-2349065696
Deleted the branch by mistake, restore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org