[jira] [Commented] (THRIFT-1204) Ruby autogenerated files should require 'thrift' gem

["Ilya Maykov (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218593#comment-13218593 ] 

Ilya Maykov commented on THRIFT-1204:
-------------------------------------

Update - will get this checked in this week. I propose that we add a 'no-require-gem' argument (default 'false') to the rb target of the thrift compiler. When 'no-require-gem' is set, the compiler will behave as it does now. Otherwise, every gen-rb file will require rubygems and thrift as originally proposed.
                
> Ruby autogenerated files should require 'thrift' gem
> ----------------------------------------------------
>
>                 Key: THRIFT-1204
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1204
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Ruby - Compiler
>    Affects Versions: 0.6.1
>         Environment: All
>            Reporter: Ilya Maykov
>            Assignee: Ilya Maykov
>            Priority: Minor
>         Attachments: THRIFT-1204-require-thrift-in-gen-rb-files.patch
>
>
> The gen-rb files currently don't require the thrift gem. This means that the user of such a file must explicitly require 'thrift' in his code before requiring a gen-rb file, which can be a bit annoying (especially when debugging / experimenting in IRB). I propose that we change the compiler to add the require at the top of every gen-rb file.
> Patch coming shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira