You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by Ferry Huberts <ma...@hupie.com> on 2014/06/18 09:14:58 UTC
RFE: add sources to bundles
Hi,
I'd like to request that the sources be added to released bundles.
This makes debugging so much easier, especially when using bndtools.
The bnd instruction to accomplish this (also applicable to the bundle
plugin) is:
-sources: true
--
Ferry Huberts
Re: RFE: add sources to bundles
Posted by Ferry Huberts <ma...@hupie.com>.
On 18/06/14 16:34, Karl Pauls wrote:
> On Wed, Jun 18, 2014 at 4:11 PM, Jan Willem Janssen <
> janwillem.janssen@luminis.eu> wrote:
>
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On 18/06/14 16:08, Karl Pauls wrote:
>>> FWIW, I'm not a super big fan of shipping the source in the
>>> binaries as that makes them extra bloated - we should
>>> deploy/release the source.jars via maven and bnd should learn how
>>> to download them from the maven repo or at least provide a way to
>>> attach them manually without forcing the source to be contained in
>>> the jar (if it can't do that already).
>>
>> *grin* matter of taste, fuel for a good flamewar! I personally hate it
>> that I need to download additional artifacts before I can make sense
>> from unknown APIs (not using Maven) ;)
>
>
> It's not a matter of taste. We ship binaries for convenience and sources
> for releases.
>
> Now, the binaries are there so you don't have to build the sources. To make
> them contain the sources for developer convenience is yet another level of
> convenience added on top at the price of making the binaries a lot bigger
> (hampering other use cases - i.e., removing convenience for others). So
> it's not a question of taste but a tradeoff (which probably can be
> summarized as deployment vs develop convenience).
>
> IMO providing bigger binaries just to save a click for some developers
> doesn't sound like the right tradeoff to make.
>
There are multiple ways to look at this.
Your view is one of them.
I'd pose that the project just lost a bugfix and _maybe_ even a
potential committer because of this issue.
It is trivial to define a profile in the pom and just build either the
'embedded' profile, the 'with sources' profile or both.
I for one just deploy with sources. Makes my audit trail that much
easier and I don't have to do special 'deploy to production' things.
OTOH, it's fairly trivial to run a script to remove the sources, since
they're always in OSGI-OPT folder in the bundle.
Which IMHO opens even more possibilities for an acceptable solution :-)
> regards,
>
> Karl
>
>
>>
>
> - --
>> Met vriendelijke groeten | Kind regards
>>
>> Jan Willem Janssen | Software Architect
>> +31 631 765 814
>>
>> /My world is revolving around PulseOn and Amdatu/
>>
>> Luminis Technologies B.V.
>> J.C. Wilslaan 29
>> 7313 HK Apeldoorn
>> +31 88 586 46 30
>>
>> http://www.luminis-technologies.com
>> http://www.luminis.eu
>>
>> KvK (CoC) 09 16 28 93
>> BTW (VAT) NL8169.78.566.B.01
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
>> Comment: GPGTools - http://gpgtools.org
>> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>>
>> iQIcBAEBAgAGBQJToZ4VAAoJEKF/mP2eHDc4Ew8QAJZlHFkjzE/Q9Zf7l0UPBstA
>> LE2fxjLMzJFS2GEZ8fg8QxCtt81j+FYzBcXQeCs2LmYSEyDZT5mTSC/LspeA98Vr
>> 8zoY6e2hgGyG7cnXTCZ4ictkRaM+Y7TwtMIKBYhiD7oyqAVmtB4dzQORU0WrLljO
>> /n0P16LpTs0erVe7bynbdLx4G5G8IoDYcJ8/nep2FvhHlshUD5xdk9CNwj4POU25
>> tC+6wD7fPPgaseoZXAO9JIi9a4EuZTZ9MQhapGiccr6ylFJefZ7MkZDE7/ikfOF/
>> c8DlNoj9iZsRX7aETZY2Zsi8ppNPno/KVDDIq2cWrDEePm8/26ycP0kRsmLyz50T
>> uxvATjqNifQSTx6/6Hw/vokcWtBpmtmKjYDvn1oJqC/IQDiCCtRp6XzJDTAqz4q5
>> 3HMtgkSKuINLeqoLKC5jWSiQMZ8yoeWHBTrxdGmHjdR0ljxWaEYekXpZMsm6n6j7
>> WBD4aZKKkjHnTJ5LXz8zJWPl72GyL4WmaiucALQ/EIktsL+HXexfN6gqfuBYrzcz
>> GyFwYyxTi86HBev2lCqn1AIR5J5r2pXkn4uM7xL9PUlk9kPBsqTzTiekZQLhvKaf
>> V79aSEoTW+B488nq3kxwHSSShlYJoHaiBH4YooKlj3xOn+IiX5AS2cg2D/oCnu1k
>> DqF2JZOFsRJWBBDGaQZF
>> =OHAU
>> -----END PGP SIGNATURE-----
>>
>
>
>
--
Ferry Huberts
Re: RFE: add sources to bundles
Posted by Karl Pauls <ka...@gmail.com>.
On Wed, Jun 18, 2014 at 4:11 PM, Jan Willem Janssen <
janwillem.janssen@luminis.eu> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 18/06/14 16:08, Karl Pauls wrote:
> > FWIW, I'm not a super big fan of shipping the source in the
> > binaries as that makes them extra bloated - we should
> > deploy/release the source.jars via maven and bnd should learn how
> > to download them from the maven repo or at least provide a way to
> > attach them manually without forcing the source to be contained in
> > the jar (if it can't do that already).
>
> *grin* matter of taste, fuel for a good flamewar! I personally hate it
> that I need to download additional artifacts before I can make sense
> from unknown APIs (not using Maven) ;)
It's not a matter of taste. We ship binaries for convenience and sources
for releases.
Now, the binaries are there so you don't have to build the sources. To make
them contain the sources for developer convenience is yet another level of
convenience added on top at the price of making the binaries a lot bigger
(hampering other use cases - i.e., removing convenience for others). So
it's not a question of taste but a tradeoff (which probably can be
summarized as deployment vs develop convenience).
IMO providing bigger binaries just to save a click for some developers
doesn't sound like the right tradeoff to make.
regards,
Karl
>
- --
> Met vriendelijke groeten | Kind regards
>
> Jan Willem Janssen | Software Architect
> +31 631 765 814
>
> /My world is revolving around PulseOn and Amdatu/
>
> Luminis Technologies B.V.
> J.C. Wilslaan 29
> 7313 HK Apeldoorn
> +31 88 586 46 30
>
> http://www.luminis-technologies.com
> http://www.luminis.eu
>
> KvK (CoC) 09 16 28 93
> BTW (VAT) NL8169.78.566.B.01
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
> Comment: GPGTools - http://gpgtools.org
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iQIcBAEBAgAGBQJToZ4VAAoJEKF/mP2eHDc4Ew8QAJZlHFkjzE/Q9Zf7l0UPBstA
> LE2fxjLMzJFS2GEZ8fg8QxCtt81j+FYzBcXQeCs2LmYSEyDZT5mTSC/LspeA98Vr
> 8zoY6e2hgGyG7cnXTCZ4ictkRaM+Y7TwtMIKBYhiD7oyqAVmtB4dzQORU0WrLljO
> /n0P16LpTs0erVe7bynbdLx4G5G8IoDYcJ8/nep2FvhHlshUD5xdk9CNwj4POU25
> tC+6wD7fPPgaseoZXAO9JIi9a4EuZTZ9MQhapGiccr6ylFJefZ7MkZDE7/ikfOF/
> c8DlNoj9iZsRX7aETZY2Zsi8ppNPno/KVDDIq2cWrDEePm8/26ycP0kRsmLyz50T
> uxvATjqNifQSTx6/6Hw/vokcWtBpmtmKjYDvn1oJqC/IQDiCCtRp6XzJDTAqz4q5
> 3HMtgkSKuINLeqoLKC5jWSiQMZ8yoeWHBTrxdGmHjdR0ljxWaEYekXpZMsm6n6j7
> WBD4aZKKkjHnTJ5LXz8zJWPl72GyL4WmaiucALQ/EIktsL+HXexfN6gqfuBYrzcz
> GyFwYyxTi86HBev2lCqn1AIR5J5r2pXkn4uM7xL9PUlk9kPBsqTzTiekZQLhvKaf
> V79aSEoTW+B488nq3kxwHSSShlYJoHaiBH4YooKlj3xOn+IiX5AS2cg2D/oCnu1k
> DqF2JZOFsRJWBBDGaQZF
> =OHAU
> -----END PGP SIGNATURE-----
>
--
Karl Pauls
karlpauls@gmail.com
http://twitter.com/karlpauls
http://www.linkedin.com/in/karlpauls
https://profiles.google.com/karlpauls
Re: RFE: add sources to bundles
Posted by Stuart McCulloch <mc...@gmail.com>.
On 18 Jun 2014, at 16:01, Karl Pauls <ka...@gmail.com> wrote:
> On Wed, Jun 18, 2014 at 4:37 PM, Paul Bakker <pa...@luminis.eu> wrote:
>
>> Karl, are you *against* the idea, or just not very fond of it? In other
>> words: can we apply this change to the poms or not?
>
> Changing our parent pom so that all sub projects will be build like this
> without the option to change it? Yes, I'm against that idea. If by "apply
> this change to the poms" you are talking about specific sub projects we
> could debate which ones but I'd much rather you at least make it so that
> you provide both binaries and binaries with source for them.
I agree that this is something that each sub-project should decide, rather than impose a blanket setting across all sub-projects.
Especially since we have such a variety of sub-projects and while it might make sense for some, it won’t make sense for others.
> regards,
>
> Karl
>
>
>> Cheers,
>>
>> Paul
>>
>>
>> On Wed, Jun 18, 2014 at 10:11 AM, Jan Willem Janssen <
>> janwillem.janssen@luminis.eu> wrote:
>>
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>>
>>> On 18/06/14 16:08, Karl Pauls wrote:
>>>> FWIW, I'm not a super big fan of shipping the source in the
>>>> binaries as that makes them extra bloated - we should
>>>> deploy/release the source.jars via maven and bnd should learn how
>>>> to download them from the maven repo or at least provide a way to
>>>> attach them manually without forcing the source to be contained in
>>>> the jar (if it can't do that already).
>>>
>>> *grin* matter of taste, fuel for a good flamewar! I personally hate it
>>> that I need to download additional artifacts before I can make sense
>>> from unknown APIs (not using Maven) ;)
>>>
>>>
>>> - --
>>> Met vriendelijke groeten | Kind regards
>>>
>>> Jan Willem Janssen | Software Architect
>>> +31 631 765 814
>>>
>>> /My world is revolving around PulseOn and Amdatu/
>>>
>>> Luminis Technologies B.V.
>>> J.C. Wilslaan 29
>>> 7313 HK Apeldoorn
>>> +31 88 586 46 30
>>>
>>> http://www.luminis-technologies.com
>>> http://www.luminis.eu
>>>
>>> KvK (CoC) 09 16 28 93
>>> BTW (VAT) NL8169.78.566.B.01
>>> -----BEGIN PGP SIGNATURE-----
>>> Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
>>> Comment: GPGTools - http://gpgtools.org
>>> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>>>
>>> iQIcBAEBAgAGBQJToZ4VAAoJEKF/mP2eHDc4Ew8QAJZlHFkjzE/Q9Zf7l0UPBstA
>>> LE2fxjLMzJFS2GEZ8fg8QxCtt81j+FYzBcXQeCs2LmYSEyDZT5mTSC/LspeA98Vr
>>> 8zoY6e2hgGyG7cnXTCZ4ictkRaM+Y7TwtMIKBYhiD7oyqAVmtB4dzQORU0WrLljO
>>> /n0P16LpTs0erVe7bynbdLx4G5G8IoDYcJ8/nep2FvhHlshUD5xdk9CNwj4POU25
>>> tC+6wD7fPPgaseoZXAO9JIi9a4EuZTZ9MQhapGiccr6ylFJefZ7MkZDE7/ikfOF/
>>> c8DlNoj9iZsRX7aETZY2Zsi8ppNPno/KVDDIq2cWrDEePm8/26ycP0kRsmLyz50T
>>> uxvATjqNifQSTx6/6Hw/vokcWtBpmtmKjYDvn1oJqC/IQDiCCtRp6XzJDTAqz4q5
>>> 3HMtgkSKuINLeqoLKC5jWSiQMZ8yoeWHBTrxdGmHjdR0ljxWaEYekXpZMsm6n6j7
>>> WBD4aZKKkjHnTJ5LXz8zJWPl72GyL4WmaiucALQ/EIktsL+HXexfN6gqfuBYrzcz
>>> GyFwYyxTi86HBev2lCqn1AIR5J5r2pXkn4uM7xL9PUlk9kPBsqTzTiekZQLhvKaf
>>> V79aSEoTW+B488nq3kxwHSSShlYJoHaiBH4YooKlj3xOn+IiX5AS2cg2D/oCnu1k
>>> DqF2JZOFsRJWBBDGaQZF
>>> =OHAU
>>> -----END PGP SIGNATURE-----
>>>
>>
>
>
>
> --
> Karl Pauls
> karlpauls@gmail.com
> http://twitter.com/karlpauls
> http://www.linkedin.com/in/karlpauls
> https://profiles.google.com/karlpauls
Re: RFE: add sources to bundles
Posted by Karl Pauls <ka...@gmail.com>.
On Wed, Jun 18, 2014 at 4:37 PM, Paul Bakker <pa...@luminis.eu> wrote:
> Karl, are you *against* the idea, or just not very fond of it? In other
words: can we apply this change to the poms or not?
>
Changing our parent pom so that all sub projects will be build like this
without the option to change it? Yes, I'm against that idea. If by "apply
this change to the poms" you are talking about specific sub projects we
could debate which ones but I'd much rather you at least make it so that
you provide both binaries and binaries with source for them.
regards,
Karl
> Cheers,
>
> Paul
>
>
> On Wed, Jun 18, 2014 at 10:11 AM, Jan Willem Janssen <
> janwillem.janssen@luminis.eu> wrote:
>
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > On 18/06/14 16:08, Karl Pauls wrote:
> > > FWIW, I'm not a super big fan of shipping the source in the
> > > binaries as that makes them extra bloated - we should
> > > deploy/release the source.jars via maven and bnd should learn how
> > > to download them from the maven repo or at least provide a way to
> > > attach them manually without forcing the source to be contained in
> > > the jar (if it can't do that already).
> >
> > *grin* matter of taste, fuel for a good flamewar! I personally hate it
> > that I need to download additional artifacts before I can make sense
> > from unknown APIs (not using Maven) ;)
> >
> >
> > - --
> > Met vriendelijke groeten | Kind regards
> >
> > Jan Willem Janssen | Software Architect
> > +31 631 765 814
> >
> > /My world is revolving around PulseOn and Amdatu/
> >
> > Luminis Technologies B.V.
> > J.C. Wilslaan 29
> > 7313 HK Apeldoorn
> > +31 88 586 46 30
> >
> > http://www.luminis-technologies.com
> > http://www.luminis.eu
> >
> > KvK (CoC) 09 16 28 93
> > BTW (VAT) NL8169.78.566.B.01
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
> > Comment: GPGTools - http://gpgtools.org
> > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
> >
> > iQIcBAEBAgAGBQJToZ4VAAoJEKF/mP2eHDc4Ew8QAJZlHFkjzE/Q9Zf7l0UPBstA
> > LE2fxjLMzJFS2GEZ8fg8QxCtt81j+FYzBcXQeCs2LmYSEyDZT5mTSC/LspeA98Vr
> > 8zoY6e2hgGyG7cnXTCZ4ictkRaM+Y7TwtMIKBYhiD7oyqAVmtB4dzQORU0WrLljO
> > /n0P16LpTs0erVe7bynbdLx4G5G8IoDYcJ8/nep2FvhHlshUD5xdk9CNwj4POU25
> > tC+6wD7fPPgaseoZXAO9JIi9a4EuZTZ9MQhapGiccr6ylFJefZ7MkZDE7/ikfOF/
> > c8DlNoj9iZsRX7aETZY2Zsi8ppNPno/KVDDIq2cWrDEePm8/26ycP0kRsmLyz50T
> > uxvATjqNifQSTx6/6Hw/vokcWtBpmtmKjYDvn1oJqC/IQDiCCtRp6XzJDTAqz4q5
> > 3HMtgkSKuINLeqoLKC5jWSiQMZ8yoeWHBTrxdGmHjdR0ljxWaEYekXpZMsm6n6j7
> > WBD4aZKKkjHnTJ5LXz8zJWPl72GyL4WmaiucALQ/EIktsL+HXexfN6gqfuBYrzcz
> > GyFwYyxTi86HBev2lCqn1AIR5J5r2pXkn4uM7xL9PUlk9kPBsqTzTiekZQLhvKaf
> > V79aSEoTW+B488nq3kxwHSSShlYJoHaiBH4YooKlj3xOn+IiX5AS2cg2D/oCnu1k
> > DqF2JZOFsRJWBBDGaQZF
> > =OHAU
> > -----END PGP SIGNATURE-----
> >
>
--
Karl Pauls
karlpauls@gmail.com
http://twitter.com/karlpauls
http://www.linkedin.com/in/karlpauls
https://profiles.google.com/karlpauls
Re: RFE: add sources to bundles
Posted by Uwe Barthel <ba...@x-reizend.de>.
Hi,
I'm agree with Karl. A 'lot' of space for a bit comfort.
There are environments with very limited space for the bundle store.
-1 for the idea
Kind Regards
Uwe
On June 18, 2014 4:37:38 PM Paul Bakker <pa...@luminis.eu> wrote:
> Karl, are you *against* the idea, or just not very fond of it? In other
> words: can we apply this change to the poms or not?
>
> Cheers,
>
> Paul
>
>
> On Wed, Jun 18, 2014 at 10:11 AM, Jan Willem Janssen <
> janwillem.janssen@luminis.eu> wrote:
>
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > On 18/06/14 16:08, Karl Pauls wrote:
> > > FWIW, I'm not a super big fan of shipping the source in the
> > > binaries as that makes them extra bloated - we should
> > > deploy/release the source.jars via maven and bnd should learn how
> > > to download them from the maven repo or at least provide a way to
> > > attach them manually without forcing the source to be contained in
> > > the jar (if it can't do that already).
> >
> > *grin* matter of taste, fuel for a good flamewar! I personally hate it
> > that I need to download additional artifacts before I can make sense
> > from unknown APIs (not using Maven) ;)
> >
> >
> > - --
> > Met vriendelijke groeten | Kind regards
> >
> > Jan Willem Janssen | Software Architect
> > +31 631 765 814
> >
> > /My world is revolving around PulseOn and Amdatu/
> >
> > Luminis Technologies B.V.
> > J.C. Wilslaan 29
> > 7313 HK Apeldoorn
> > +31 88 586 46 30
> >
> > http://www.luminis-technologies.com
> > http://www.luminis.eu
> >
> > KvK (CoC) 09 16 28 93
> > BTW (VAT) NL8169.78.566.B.01
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
> > Comment: GPGTools - http://gpgtools.org
> > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
> >
> > iQIcBAEBAgAGBQJToZ4VAAoJEKF/mP2eHDc4Ew8QAJZlHFkjzE/Q9Zf7l0UPBstA
> > LE2fxjLMzJFS2GEZ8fg8QxCtt81j+FYzBcXQeCs2LmYSEyDZT5mTSC/LspeA98Vr
> > 8zoY6e2hgGyG7cnXTCZ4ictkRaM+Y7TwtMIKBYhiD7oyqAVmtB4dzQORU0WrLljO
> > /n0P16LpTs0erVe7bynbdLx4G5G8IoDYcJ8/nep2FvhHlshUD5xdk9CNwj4POU25
> > tC+6wD7fPPgaseoZXAO9JIi9a4EuZTZ9MQhapGiccr6ylFJefZ7MkZDE7/ikfOF/
> > c8DlNoj9iZsRX7aETZY2Zsi8ppNPno/KVDDIq2cWrDEePm8/26ycP0kRsmLyz50T
> > uxvATjqNifQSTx6/6Hw/vokcWtBpmtmKjYDvn1oJqC/IQDiCCtRp6XzJDTAqz4q5
> > 3HMtgkSKuINLeqoLKC5jWSiQMZ8yoeWHBTrxdGmHjdR0ljxWaEYekXpZMsm6n6j7
> > WBD4aZKKkjHnTJ5LXz8zJWPl72GyL4WmaiucALQ/EIktsL+HXexfN6gqfuBYrzcz
> > GyFwYyxTi86HBev2lCqn1AIR5J5r2pXkn4uM7xL9PUlk9kPBsqTzTiekZQLhvKaf
> > V79aSEoTW+B488nq3kxwHSSShlYJoHaiBH4YooKlj3xOn+IiX5AS2cg2D/oCnu1k
> > DqF2JZOFsRJWBBDGaQZF
> > =OHAU
> > -----END PGP SIGNATURE-----
> >
Re: RFE: add sources to bundles
Posted by Paul Bakker <pa...@luminis.eu>.
Karl, are you *against* the idea, or just not very fond of it? In other
words: can we apply this change to the poms or not?
Cheers,
Paul
On Wed, Jun 18, 2014 at 10:11 AM, Jan Willem Janssen <
janwillem.janssen@luminis.eu> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 18/06/14 16:08, Karl Pauls wrote:
> > FWIW, I'm not a super big fan of shipping the source in the
> > binaries as that makes them extra bloated - we should
> > deploy/release the source.jars via maven and bnd should learn how
> > to download them from the maven repo or at least provide a way to
> > attach them manually without forcing the source to be contained in
> > the jar (if it can't do that already).
>
> *grin* matter of taste, fuel for a good flamewar! I personally hate it
> that I need to download additional artifacts before I can make sense
> from unknown APIs (not using Maven) ;)
>
>
> - --
> Met vriendelijke groeten | Kind regards
>
> Jan Willem Janssen | Software Architect
> +31 631 765 814
>
> /My world is revolving around PulseOn and Amdatu/
>
> Luminis Technologies B.V.
> J.C. Wilslaan 29
> 7313 HK Apeldoorn
> +31 88 586 46 30
>
> http://www.luminis-technologies.com
> http://www.luminis.eu
>
> KvK (CoC) 09 16 28 93
> BTW (VAT) NL8169.78.566.B.01
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
> Comment: GPGTools - http://gpgtools.org
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iQIcBAEBAgAGBQJToZ4VAAoJEKF/mP2eHDc4Ew8QAJZlHFkjzE/Q9Zf7l0UPBstA
> LE2fxjLMzJFS2GEZ8fg8QxCtt81j+FYzBcXQeCs2LmYSEyDZT5mTSC/LspeA98Vr
> 8zoY6e2hgGyG7cnXTCZ4ictkRaM+Y7TwtMIKBYhiD7oyqAVmtB4dzQORU0WrLljO
> /n0P16LpTs0erVe7bynbdLx4G5G8IoDYcJ8/nep2FvhHlshUD5xdk9CNwj4POU25
> tC+6wD7fPPgaseoZXAO9JIi9a4EuZTZ9MQhapGiccr6ylFJefZ7MkZDE7/ikfOF/
> c8DlNoj9iZsRX7aETZY2Zsi8ppNPno/KVDDIq2cWrDEePm8/26ycP0kRsmLyz50T
> uxvATjqNifQSTx6/6Hw/vokcWtBpmtmKjYDvn1oJqC/IQDiCCtRp6XzJDTAqz4q5
> 3HMtgkSKuINLeqoLKC5jWSiQMZ8yoeWHBTrxdGmHjdR0ljxWaEYekXpZMsm6n6j7
> WBD4aZKKkjHnTJ5LXz8zJWPl72GyL4WmaiucALQ/EIktsL+HXexfN6gqfuBYrzcz
> GyFwYyxTi86HBev2lCqn1AIR5J5r2pXkn4uM7xL9PUlk9kPBsqTzTiekZQLhvKaf
> V79aSEoTW+B488nq3kxwHSSShlYJoHaiBH4YooKlj3xOn+IiX5AS2cg2D/oCnu1k
> DqF2JZOFsRJWBBDGaQZF
> =OHAU
> -----END PGP SIGNATURE-----
>
Re: RFE: add sources to bundles
Posted by Jan Willem Janssen <ja...@luminis.eu>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 18/06/14 16:08, Karl Pauls wrote:
> FWIW, I'm not a super big fan of shipping the source in the
> binaries as that makes them extra bloated - we should
> deploy/release the source.jars via maven and bnd should learn how
> to download them from the maven repo or at least provide a way to
> attach them manually without forcing the source to be contained in
> the jar (if it can't do that already).
*grin* matter of taste, fuel for a good flamewar! I personally hate it
that I need to download additional artifacts before I can make sense
from unknown APIs (not using Maven) ;)
- --
Met vriendelijke groeten | Kind regards
Jan Willem Janssen | Software Architect
+31 631 765 814
/My world is revolving around PulseOn and Amdatu/
Luminis Technologies B.V.
J.C. Wilslaan 29
7313 HK Apeldoorn
+31 88 586 46 30
http://www.luminis-technologies.com
http://www.luminis.eu
KvK (CoC) 09 16 28 93
BTW (VAT) NL8169.78.566.B.01
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJToZ4VAAoJEKF/mP2eHDc4Ew8QAJZlHFkjzE/Q9Zf7l0UPBstA
LE2fxjLMzJFS2GEZ8fg8QxCtt81j+FYzBcXQeCs2LmYSEyDZT5mTSC/LspeA98Vr
8zoY6e2hgGyG7cnXTCZ4ictkRaM+Y7TwtMIKBYhiD7oyqAVmtB4dzQORU0WrLljO
/n0P16LpTs0erVe7bynbdLx4G5G8IoDYcJ8/nep2FvhHlshUD5xdk9CNwj4POU25
tC+6wD7fPPgaseoZXAO9JIi9a4EuZTZ9MQhapGiccr6ylFJefZ7MkZDE7/ikfOF/
c8DlNoj9iZsRX7aETZY2Zsi8ppNPno/KVDDIq2cWrDEePm8/26ycP0kRsmLyz50T
uxvATjqNifQSTx6/6Hw/vokcWtBpmtmKjYDvn1oJqC/IQDiCCtRp6XzJDTAqz4q5
3HMtgkSKuINLeqoLKC5jWSiQMZ8yoeWHBTrxdGmHjdR0ljxWaEYekXpZMsm6n6j7
WBD4aZKKkjHnTJ5LXz8zJWPl72GyL4WmaiucALQ/EIktsL+HXexfN6gqfuBYrzcz
GyFwYyxTi86HBev2lCqn1AIR5J5r2pXkn4uM7xL9PUlk9kPBsqTzTiekZQLhvKaf
V79aSEoTW+B488nq3kxwHSSShlYJoHaiBH4YooKlj3xOn+IiX5AS2cg2D/oCnu1k
DqF2JZOFsRJWBBDGaQZF
=OHAU
-----END PGP SIGNATURE-----
Re: RFE: add sources to bundles
Posted by David Bosschaert <da...@gmail.com>.
I guess the consensus here is leaning towards having the sources in a
separate jar file. This is what Maven normally does anyway when you're
using the maven-source-plugin. IDEs should be able to find these
sources when you need them. I know m2e does this automatically for you
- downloads them on the fly when you debug into a class of the
associated jar file...
My 2c,
David
On 18 June 2014 19:25, Achim Nierbeck <bc...@googlemail.com> wrote:
> FWIW the latest framework bundle didn't have a src jar with it. It would be
> nice if that src.jar could be available again. Previous versions did have
> this. Usually the IDE is capable of attaching this to the binary. For
> example the me plugin for eclipse.
>
> Regards, Achim
>
> sent from mobile device
> Am 18.06.2014 18:04 schrieb "David Jencks" <da...@yahoo.com.invalid>:
>
>> I'm pretty strongly -1 on the default binary artifact including the
>> sources. So far felix follows maven conventions more or less and this is
>> definitely against maven conventions.
>>
>> On the other hand I'm cautiously +0.5 on building an additional artifact
>> that is the binary jar + sources.
>>
>> I really would think that rather than fighting maven it might be more
>> advisable to teach bndtools about maven standards so that it can find the
>> sources jar automatically given a binary jar. This would fix the problem
>> for any bundle built with maven, not just felix bundles.
>>
>> thanks
>> david jencks
>>
>> On Jun 18, 2014, at 8:33 AM, Felix Meschberger <fm...@adobe.com> wrote:
>>
>> > +1 FWIW.
>> >
>> > I agree that having the source within the bundles might be a
>> nice-to-have. AFAICT we already deploy the sources to maven and as such can
>> download them as dependencies.
>> >
>> > I would be ok if we would have a build profile which would create a
>> developer's artifact which embeds the sources with the binary code. But the
>> default IMHO should remain to be binary only.
>> >
>> > Regards
>> > Felix
>> >
>> > Am 18.06.2014 um 16:08 schrieb Karl Pauls <ka...@gmail.com>:
>> >
>> >> Oh, I was assuming you where talking about generating maven source jars
>> on
>> >> release. So that will not work (I'd still be happy if somebody gets that
>> >> one done in the parent pom).
>> >>
>> >> FWIW, I'm not a super big fan of shipping the source in the binaries as
>> >> that makes them extra bloated - we should deploy/release the source.jars
>> >> via maven and bnd should learn how to download them from the maven repo
>> or
>> >> at least provide a way to attach them manually without forcing the
>> source
>> >> to be contained in the jar (if it can't do that already).
>> >>
>> >> regards,
>> >>
>> >> Karl
>> >>
>> >>
>> >> On Wed, Jun 18, 2014 at 3:39 PM, Ferry Huberts <ma...@hupie.com>
>> wrote:
>> >>
>> >>>
>> >>>
>> >>> On 18/06/14 15:27, Karl Pauls wrote:
>> >>>
>> >>>> Attaching the source jars makes a lot of sense - somebody wants to
>> take a
>> >>>> go at our parent pom?
>> >>>>
>> >>>>
>> >>> IIRC you can't do it in the parent pom.
>> >>> You need to add
>> >>> <_source>true</_source>
>> >>> to the bundle plugin configurations
>> >>>
>> >>>
>> >>> regards,
>> >>>>
>> >>>> Karl
>> >>>>
>> >>>>
>> >>>> On Wed, Jun 18, 2014 at 3:18 PM, Paul Bakker <pa...@luminis.eu>
>> >>>> wrote:
>> >>>>
>> >>>> +1
>> >>>>>
>> >>>>> I believe Maven source jars are already generated, but it would be
>> great
>> >>>>> to
>> >>>>> also generate the sources in the binaries like Bndtools expects.
>> >>>>>
>> >>>>> Cheers,
>> >>>>>
>> >>>>> Paul
>> >>>>>
>> >>>>>
>> >>>>> On Wed, Jun 18, 2014 at 9:11 AM, Ferry Huberts <ma...@hupie.com>
>> >>>>> wrote:
>> >>>>>
>> >>>>>
>> >>>>>>
>> >>>>>> On 18/06/14 14:48, Raymond Auge wrote:
>> >>>>>>
>> >>>>>> +1
>> >>>>>>>
>> >>>>>>> I find if incredibly tiring to have to fetch the source bundles for
>> >>>>>>> libs
>> >>>>>>> all the time.
>> >>>>>>>
>> >>>>>>> Meanwhile, some libs like bnd for instance, contain the sources and
>> >>>>>>> that
>> >>>>>>> makes them a joy to work with.
>> >>>>>>>
>> >>>>>>>
>> >>>>>>
>> >>>>>> the reason I sent this mail is that I have an insane jetty crash
>> that I
>> >>>>>> wanted to track down. Because no sources were included and I use
>> many
>> >>>>>>
>> >>>>> felix
>> >>>>>
>> >>>>>> bundles with widely differing versions it became a nightmare and I
>> just
>> >>>>>> gave up.
>> >>>>>>
>> >>>>>>
>> >>>>>>
>> >>>>>> However, I could see a counter argument for the size of the archive
>> >>>>>>>
>> >>>>>> being
>> >>>>>
>> >>>>>> adversely affected by the inclusion of sources, particularly for
>> those
>> >>>>>>> small profile installations (particularly embedded).
>> >>>>>>>
>> >>>>>>>
>> >>>>>>> I'm sure an acceptable solution can be found.
>> >>>>>>
>> >>>>>>
>> >>>>>>
>> >>>>>> On Wed, Jun 18, 2014 at 3:14 AM, Ferry Huberts <ma...@hupie.com>
>> >>>>>>> wrote:
>> >>>>>>>
>> >>>>>>> Hi,
>> >>>>>>>
>> >>>>>>>>
>> >>>>>>>> I'd like to request that the sources be added to released bundles.
>> >>>>>>>> This makes debugging so much easier, especially when using
>> bndtools.
>> >>>>>>>>
>> >>>>>>>> The bnd instruction to accomplish this (also applicable to the
>> bundle
>> >>>>>>>> plugin) is:
>> >>>>>>>> -sources: true
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>> --
>> >>>>>>>> Ferry Huberts
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>
>> >>>>>>>
>> >>>>>>> --
>> >>>>>> Ferry Huberts
>> >>>>>>
>> >>>>>>
>> >>>>>
>> >>>>
>> >>>>
>> >>>>
>> >>> --
>> >>> Ferry Huberts
>> >>>
>> >>
>> >>
>> >>
>> >> --
>> >> Karl Pauls
>> >> karlpauls@gmail.com
>> >> http://twitter.com/karlpauls
>> >> http://www.linkedin.com/in/karlpauls
>> >> https://profiles.google.com/karlpauls
>> >
>>
>>
Re: RFE: add sources to bundles
Posted by Achim Nierbeck <bc...@googlemail.com>.
FWIW the latest framework bundle didn't have a src jar with it. It would be
nice if that src.jar could be available again. Previous versions did have
this. Usually the IDE is capable of attaching this to the binary. For
example the me plugin for eclipse.
Regards, Achim
sent from mobile device
Am 18.06.2014 18:04 schrieb "David Jencks" <da...@yahoo.com.invalid>:
> I'm pretty strongly -1 on the default binary artifact including the
> sources. So far felix follows maven conventions more or less and this is
> definitely against maven conventions.
>
> On the other hand I'm cautiously +0.5 on building an additional artifact
> that is the binary jar + sources.
>
> I really would think that rather than fighting maven it might be more
> advisable to teach bndtools about maven standards so that it can find the
> sources jar automatically given a binary jar. This would fix the problem
> for any bundle built with maven, not just felix bundles.
>
> thanks
> david jencks
>
> On Jun 18, 2014, at 8:33 AM, Felix Meschberger <fm...@adobe.com> wrote:
>
> > +1 FWIW.
> >
> > I agree that having the source within the bundles might be a
> nice-to-have. AFAICT we already deploy the sources to maven and as such can
> download them as dependencies.
> >
> > I would be ok if we would have a build profile which would create a
> developer's artifact which embeds the sources with the binary code. But the
> default IMHO should remain to be binary only.
> >
> > Regards
> > Felix
> >
> > Am 18.06.2014 um 16:08 schrieb Karl Pauls <ka...@gmail.com>:
> >
> >> Oh, I was assuming you where talking about generating maven source jars
> on
> >> release. So that will not work (I'd still be happy if somebody gets that
> >> one done in the parent pom).
> >>
> >> FWIW, I'm not a super big fan of shipping the source in the binaries as
> >> that makes them extra bloated - we should deploy/release the source.jars
> >> via maven and bnd should learn how to download them from the maven repo
> or
> >> at least provide a way to attach them manually without forcing the
> source
> >> to be contained in the jar (if it can't do that already).
> >>
> >> regards,
> >>
> >> Karl
> >>
> >>
> >> On Wed, Jun 18, 2014 at 3:39 PM, Ferry Huberts <ma...@hupie.com>
> wrote:
> >>
> >>>
> >>>
> >>> On 18/06/14 15:27, Karl Pauls wrote:
> >>>
> >>>> Attaching the source jars makes a lot of sense - somebody wants to
> take a
> >>>> go at our parent pom?
> >>>>
> >>>>
> >>> IIRC you can't do it in the parent pom.
> >>> You need to add
> >>> <_source>true</_source>
> >>> to the bundle plugin configurations
> >>>
> >>>
> >>> regards,
> >>>>
> >>>> Karl
> >>>>
> >>>>
> >>>> On Wed, Jun 18, 2014 at 3:18 PM, Paul Bakker <pa...@luminis.eu>
> >>>> wrote:
> >>>>
> >>>> +1
> >>>>>
> >>>>> I believe Maven source jars are already generated, but it would be
> great
> >>>>> to
> >>>>> also generate the sources in the binaries like Bndtools expects.
> >>>>>
> >>>>> Cheers,
> >>>>>
> >>>>> Paul
> >>>>>
> >>>>>
> >>>>> On Wed, Jun 18, 2014 at 9:11 AM, Ferry Huberts <ma...@hupie.com>
> >>>>> wrote:
> >>>>>
> >>>>>
> >>>>>>
> >>>>>> On 18/06/14 14:48, Raymond Auge wrote:
> >>>>>>
> >>>>>> +1
> >>>>>>>
> >>>>>>> I find if incredibly tiring to have to fetch the source bundles for
> >>>>>>> libs
> >>>>>>> all the time.
> >>>>>>>
> >>>>>>> Meanwhile, some libs like bnd for instance, contain the sources and
> >>>>>>> that
> >>>>>>> makes them a joy to work with.
> >>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>> the reason I sent this mail is that I have an insane jetty crash
> that I
> >>>>>> wanted to track down. Because no sources were included and I use
> many
> >>>>>>
> >>>>> felix
> >>>>>
> >>>>>> bundles with widely differing versions it became a nightmare and I
> just
> >>>>>> gave up.
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> However, I could see a counter argument for the size of the archive
> >>>>>>>
> >>>>>> being
> >>>>>
> >>>>>> adversely affected by the inclusion of sources, particularly for
> those
> >>>>>>> small profile installations (particularly embedded).
> >>>>>>>
> >>>>>>>
> >>>>>>> I'm sure an acceptable solution can be found.
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> On Wed, Jun 18, 2014 at 3:14 AM, Ferry Huberts <ma...@hupie.com>
> >>>>>>> wrote:
> >>>>>>>
> >>>>>>> Hi,
> >>>>>>>
> >>>>>>>>
> >>>>>>>> I'd like to request that the sources be added to released bundles.
> >>>>>>>> This makes debugging so much easier, especially when using
> bndtools.
> >>>>>>>>
> >>>>>>>> The bnd instruction to accomplish this (also applicable to the
> bundle
> >>>>>>>> plugin) is:
> >>>>>>>> -sources: true
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> --
> >>>>>>>> Ferry Huberts
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> --
> >>>>>> Ferry Huberts
> >>>>>>
> >>>>>>
> >>>>>
> >>>>
> >>>>
> >>>>
> >>> --
> >>> Ferry Huberts
> >>>
> >>
> >>
> >>
> >> --
> >> Karl Pauls
> >> karlpauls@gmail.com
> >> http://twitter.com/karlpauls
> >> http://www.linkedin.com/in/karlpauls
> >> https://profiles.google.com/karlpauls
> >
>
>
Re: RFE: add sources to bundles
Posted by David Jencks <da...@yahoo.com.INVALID>.
I'm pretty strongly -1 on the default binary artifact including the sources. So far felix follows maven conventions more or less and this is definitely against maven conventions.
On the other hand I'm cautiously +0.5 on building an additional artifact that is the binary jar + sources.
I really would think that rather than fighting maven it might be more advisable to teach bndtools about maven standards so that it can find the sources jar automatically given a binary jar. This would fix the problem for any bundle built with maven, not just felix bundles.
thanks
david jencks
On Jun 18, 2014, at 8:33 AM, Felix Meschberger <fm...@adobe.com> wrote:
> +1 FWIW.
>
> I agree that having the source within the bundles might be a nice-to-have. AFAICT we already deploy the sources to maven and as such can download them as dependencies.
>
> I would be ok if we would have a build profile which would create a developer's artifact which embeds the sources with the binary code. But the default IMHO should remain to be binary only.
>
> Regards
> Felix
>
> Am 18.06.2014 um 16:08 schrieb Karl Pauls <ka...@gmail.com>:
>
>> Oh, I was assuming you where talking about generating maven source jars on
>> release. So that will not work (I'd still be happy if somebody gets that
>> one done in the parent pom).
>>
>> FWIW, I'm not a super big fan of shipping the source in the binaries as
>> that makes them extra bloated - we should deploy/release the source.jars
>> via maven and bnd should learn how to download them from the maven repo or
>> at least provide a way to attach them manually without forcing the source
>> to be contained in the jar (if it can't do that already).
>>
>> regards,
>>
>> Karl
>>
>>
>> On Wed, Jun 18, 2014 at 3:39 PM, Ferry Huberts <ma...@hupie.com> wrote:
>>
>>>
>>>
>>> On 18/06/14 15:27, Karl Pauls wrote:
>>>
>>>> Attaching the source jars makes a lot of sense - somebody wants to take a
>>>> go at our parent pom?
>>>>
>>>>
>>> IIRC you can't do it in the parent pom.
>>> You need to add
>>> <_source>true</_source>
>>> to the bundle plugin configurations
>>>
>>>
>>> regards,
>>>>
>>>> Karl
>>>>
>>>>
>>>> On Wed, Jun 18, 2014 at 3:18 PM, Paul Bakker <pa...@luminis.eu>
>>>> wrote:
>>>>
>>>> +1
>>>>>
>>>>> I believe Maven source jars are already generated, but it would be great
>>>>> to
>>>>> also generate the sources in the binaries like Bndtools expects.
>>>>>
>>>>> Cheers,
>>>>>
>>>>> Paul
>>>>>
>>>>>
>>>>> On Wed, Jun 18, 2014 at 9:11 AM, Ferry Huberts <ma...@hupie.com>
>>>>> wrote:
>>>>>
>>>>>
>>>>>>
>>>>>> On 18/06/14 14:48, Raymond Auge wrote:
>>>>>>
>>>>>> +1
>>>>>>>
>>>>>>> I find if incredibly tiring to have to fetch the source bundles for
>>>>>>> libs
>>>>>>> all the time.
>>>>>>>
>>>>>>> Meanwhile, some libs like bnd for instance, contain the sources and
>>>>>>> that
>>>>>>> makes them a joy to work with.
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> the reason I sent this mail is that I have an insane jetty crash that I
>>>>>> wanted to track down. Because no sources were included and I use many
>>>>>>
>>>>> felix
>>>>>
>>>>>> bundles with widely differing versions it became a nightmare and I just
>>>>>> gave up.
>>>>>>
>>>>>>
>>>>>>
>>>>>> However, I could see a counter argument for the size of the archive
>>>>>>>
>>>>>> being
>>>>>
>>>>>> adversely affected by the inclusion of sources, particularly for those
>>>>>>> small profile installations (particularly embedded).
>>>>>>>
>>>>>>>
>>>>>>> I'm sure an acceptable solution can be found.
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Wed, Jun 18, 2014 at 3:14 AM, Ferry Huberts <ma...@hupie.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>>>
>>>>>>>> I'd like to request that the sources be added to released bundles.
>>>>>>>> This makes debugging so much easier, especially when using bndtools.
>>>>>>>>
>>>>>>>> The bnd instruction to accomplish this (also applicable to the bundle
>>>>>>>> plugin) is:
>>>>>>>> -sources: true
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Ferry Huberts
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>> Ferry Huberts
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>>
>>> --
>>> Ferry Huberts
>>>
>>
>>
>>
>> --
>> Karl Pauls
>> karlpauls@gmail.com
>> http://twitter.com/karlpauls
>> http://www.linkedin.com/in/karlpauls
>> https://profiles.google.com/karlpauls
>
Re: RFE: add sources to bundles
Posted by Felix Meschberger <fm...@adobe.com>.
+1 FWIW.
I agree that having the source within the bundles might be a nice-to-have. AFAICT we already deploy the sources to maven and as such can download them as dependencies.
I would be ok if we would have a build profile which would create a developer's artifact which embeds the sources with the binary code. But the default IMHO should remain to be binary only.
Regards
Felix
Am 18.06.2014 um 16:08 schrieb Karl Pauls <ka...@gmail.com>:
> Oh, I was assuming you where talking about generating maven source jars on
> release. So that will not work (I'd still be happy if somebody gets that
> one done in the parent pom).
>
> FWIW, I'm not a super big fan of shipping the source in the binaries as
> that makes them extra bloated - we should deploy/release the source.jars
> via maven and bnd should learn how to download them from the maven repo or
> at least provide a way to attach them manually without forcing the source
> to be contained in the jar (if it can't do that already).
>
> regards,
>
> Karl
>
>
> On Wed, Jun 18, 2014 at 3:39 PM, Ferry Huberts <ma...@hupie.com> wrote:
>
>>
>>
>> On 18/06/14 15:27, Karl Pauls wrote:
>>
>>> Attaching the source jars makes a lot of sense - somebody wants to take a
>>> go at our parent pom?
>>>
>>>
>> IIRC you can't do it in the parent pom.
>> You need to add
>> <_source>true</_source>
>> to the bundle plugin configurations
>>
>>
>> regards,
>>>
>>> Karl
>>>
>>>
>>> On Wed, Jun 18, 2014 at 3:18 PM, Paul Bakker <pa...@luminis.eu>
>>> wrote:
>>>
>>> +1
>>>>
>>>> I believe Maven source jars are already generated, but it would be great
>>>> to
>>>> also generate the sources in the binaries like Bndtools expects.
>>>>
>>>> Cheers,
>>>>
>>>> Paul
>>>>
>>>>
>>>> On Wed, Jun 18, 2014 at 9:11 AM, Ferry Huberts <ma...@hupie.com>
>>>> wrote:
>>>>
>>>>
>>>>>
>>>>> On 18/06/14 14:48, Raymond Auge wrote:
>>>>>
>>>>> +1
>>>>>>
>>>>>> I find if incredibly tiring to have to fetch the source bundles for
>>>>>> libs
>>>>>> all the time.
>>>>>>
>>>>>> Meanwhile, some libs like bnd for instance, contain the sources and
>>>>>> that
>>>>>> makes them a joy to work with.
>>>>>>
>>>>>>
>>>>>
>>>>> the reason I sent this mail is that I have an insane jetty crash that I
>>>>> wanted to track down. Because no sources were included and I use many
>>>>>
>>>> felix
>>>>
>>>>> bundles with widely differing versions it became a nightmare and I just
>>>>> gave up.
>>>>>
>>>>>
>>>>>
>>>>> However, I could see a counter argument for the size of the archive
>>>>>>
>>>>> being
>>>>
>>>>> adversely affected by the inclusion of sources, particularly for those
>>>>>> small profile installations (particularly embedded).
>>>>>>
>>>>>>
>>>>>> I'm sure an acceptable solution can be found.
>>>>>
>>>>>
>>>>>
>>>>> On Wed, Jun 18, 2014 at 3:14 AM, Ferry Huberts <ma...@hupie.com>
>>>>>> wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>>>
>>>>>>> I'd like to request that the sources be added to released bundles.
>>>>>>> This makes debugging so much easier, especially when using bndtools.
>>>>>>>
>>>>>>> The bnd instruction to accomplish this (also applicable to the bundle
>>>>>>> plugin) is:
>>>>>>> -sources: true
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Ferry Huberts
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>> Ferry Huberts
>>>>>
>>>>>
>>>>
>>>
>>>
>>>
>> --
>> Ferry Huberts
>>
>
>
>
> --
> Karl Pauls
> karlpauls@gmail.com
> http://twitter.com/karlpauls
> http://www.linkedin.com/in/karlpauls
> https://profiles.google.com/karlpauls
Re: RFE: add sources to bundles
Posted by Karl Pauls <ka...@gmail.com>.
Oh, I was assuming you where talking about generating maven source jars on
release. So that will not work (I'd still be happy if somebody gets that
one done in the parent pom).
FWIW, I'm not a super big fan of shipping the source in the binaries as
that makes them extra bloated - we should deploy/release the source.jars
via maven and bnd should learn how to download them from the maven repo or
at least provide a way to attach them manually without forcing the source
to be contained in the jar (if it can't do that already).
regards,
Karl
On Wed, Jun 18, 2014 at 3:39 PM, Ferry Huberts <ma...@hupie.com> wrote:
>
>
> On 18/06/14 15:27, Karl Pauls wrote:
>
>> Attaching the source jars makes a lot of sense - somebody wants to take a
>> go at our parent pom?
>>
>>
> IIRC you can't do it in the parent pom.
> You need to add
> <_source>true</_source>
> to the bundle plugin configurations
>
>
> regards,
>>
>> Karl
>>
>>
>> On Wed, Jun 18, 2014 at 3:18 PM, Paul Bakker <pa...@luminis.eu>
>> wrote:
>>
>> +1
>>>
>>> I believe Maven source jars are already generated, but it would be great
>>> to
>>> also generate the sources in the binaries like Bndtools expects.
>>>
>>> Cheers,
>>>
>>> Paul
>>>
>>>
>>> On Wed, Jun 18, 2014 at 9:11 AM, Ferry Huberts <ma...@hupie.com>
>>> wrote:
>>>
>>>
>>>>
>>>> On 18/06/14 14:48, Raymond Auge wrote:
>>>>
>>>> +1
>>>>>
>>>>> I find if incredibly tiring to have to fetch the source bundles for
>>>>> libs
>>>>> all the time.
>>>>>
>>>>> Meanwhile, some libs like bnd for instance, contain the sources and
>>>>> that
>>>>> makes them a joy to work with.
>>>>>
>>>>>
>>>>
>>>> the reason I sent this mail is that I have an insane jetty crash that I
>>>> wanted to track down. Because no sources were included and I use many
>>>>
>>> felix
>>>
>>>> bundles with widely differing versions it became a nightmare and I just
>>>> gave up.
>>>>
>>>>
>>>>
>>>> However, I could see a counter argument for the size of the archive
>>>>>
>>>> being
>>>
>>>> adversely affected by the inclusion of sources, particularly for those
>>>>> small profile installations (particularly embedded).
>>>>>
>>>>>
>>>>> I'm sure an acceptable solution can be found.
>>>>
>>>>
>>>>
>>>> On Wed, Jun 18, 2014 at 3:14 AM, Ferry Huberts <ma...@hupie.com>
>>>>> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>>>
>>>>>> I'd like to request that the sources be added to released bundles.
>>>>>> This makes debugging so much easier, especially when using bndtools.
>>>>>>
>>>>>> The bnd instruction to accomplish this (also applicable to the bundle
>>>>>> plugin) is:
>>>>>> -sources: true
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Ferry Huberts
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>> Ferry Huberts
>>>>
>>>>
>>>
>>
>>
>>
> --
> Ferry Huberts
>
--
Karl Pauls
karlpauls@gmail.com
http://twitter.com/karlpauls
http://www.linkedin.com/in/karlpauls
https://profiles.google.com/karlpauls
Re: RFE: add sources to bundles
Posted by Jan Willem Janssen <ja...@luminis.eu>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi,
+1 for this idea!
On 18/06/14 15:39, Ferry Huberts wrote:
>
> On 18/06/14 15:27, Karl Pauls wrote:
>> Attaching the source jars makes a lot of sense - somebody wants
>> to take a go at our parent pom?
>>
>
> IIRC you can't do it in the parent pom. You need to add
> <_source>true</_source> to the bundle plugin configurations
I've been playing with this a bit and it seems that it is possible to
enforce this setting through the parent POM. The only thing is that
sub-projects need to upgrade (after we've released it) to this new
version in order to use it...
- --
Met vriendelijke groeten | Kind regards
Jan Willem Janssen | Software Architect
+31 631 765 814
/My world is revolving around PulseOn and Amdatu/
Luminis Technologies B.V.
J.C. Wilslaan 29
7313 HK Apeldoorn
+31 88 586 46 30
http://www.luminis-technologies.com
http://www.luminis.eu
KvK (CoC) 09 16 28 93
BTW (VAT) NL8169.78.566.B.01
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJToZ1ZAAoJEKF/mP2eHDc4PFUP/2feCd/UU73n/+a+DjwbBtzp
UPUJVb9keBaB3VrVki6hLxEs3IHuZgwd5U9iSrn0XUmQyglZlsTU/tAiJ2BOaq5d
pC2eT+M4wDsyFSDluimdX3I5bb7prF5qacZ2swaml8GomXkViWZ4BVf+fKtV1L0x
SCJXwcSRw6e5aJmjy1NnNfY7il68dAQBnNGmMw5RHqj5WRN/euROzK9vIuvrwjsZ
ZF0BnM18pwOprTJhRIJMtfJF7SteIVDNfk/vMkGrfOR/DXF0nz94PaEyllr+yk1j
iYJD9otfaglJIhv7VaswNoTh0bzvHYYIlONY113gUffZqRS9SVsA/K7PocY4Kh+Z
Bdc6U7AjiePRPgC9mmrwMmLItkCPqz9aF+F2tmVbqcdl36v3ojr4jtwZdpAeZJQV
AL4dypEAfnxhH66tOj+khaBk3nCHKt5hX/FRwARDx7PI2UVoycAbtMtfJVr/H7zj
4MLNLl9XRxL361YZbv3QMQxC1MALYd4oJbJRNgRRkdV6w9JUIC7dh+/oCt1U9HLW
VPbTVWCCgTxztXquzn8Zq/6/8d2uMXW98NMXkNSk31iSAJWDhGCnsrk/pAT/6atx
edTdxEEyaCjSMLka03HW2WTv8rzK//QKuzdzJLKeFNBODmxPaF5ThUCZhiZpLHzj
KSuY/zAYVs21LgPPmDVN
=fGFi
-----END PGP SIGNATURE-----
Re: RFE: add sources to bundles
Posted by Ferry Huberts <ma...@hupie.com>.
On 18/06/14 15:27, Karl Pauls wrote:
> Attaching the source jars makes a lot of sense - somebody wants to take a
> go at our parent pom?
>
IIRC you can't do it in the parent pom.
You need to add
<_source>true</_source>
to the bundle plugin configurations
> regards,
>
> Karl
>
>
> On Wed, Jun 18, 2014 at 3:18 PM, Paul Bakker <pa...@luminis.eu> wrote:
>
>> +1
>>
>> I believe Maven source jars are already generated, but it would be great to
>> also generate the sources in the binaries like Bndtools expects.
>>
>> Cheers,
>>
>> Paul
>>
>>
>> On Wed, Jun 18, 2014 at 9:11 AM, Ferry Huberts <ma...@hupie.com> wrote:
>>
>>>
>>>
>>> On 18/06/14 14:48, Raymond Auge wrote:
>>>
>>>> +1
>>>>
>>>> I find if incredibly tiring to have to fetch the source bundles for libs
>>>> all the time.
>>>>
>>>> Meanwhile, some libs like bnd for instance, contain the sources and that
>>>> makes them a joy to work with.
>>>>
>>>
>>>
>>> the reason I sent this mail is that I have an insane jetty crash that I
>>> wanted to track down. Because no sources were included and I use many
>> felix
>>> bundles with widely differing versions it became a nightmare and I just
>>> gave up.
>>>
>>>
>>>
>>>> However, I could see a counter argument for the size of the archive
>> being
>>>> adversely affected by the inclusion of sources, particularly for those
>>>> small profile installations (particularly embedded).
>>>>
>>>>
>>> I'm sure an acceptable solution can be found.
>>>
>>>
>>>
>>>> On Wed, Jun 18, 2014 at 3:14 AM, Ferry Huberts <ma...@hupie.com>
>>>> wrote:
>>>>
>>>> Hi,
>>>>>
>>>>> I'd like to request that the sources be added to released bundles.
>>>>> This makes debugging so much easier, especially when using bndtools.
>>>>>
>>>>> The bnd instruction to accomplish this (also applicable to the bundle
>>>>> plugin) is:
>>>>> -sources: true
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Ferry Huberts
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>> --
>>> Ferry Huberts
>>>
>>
>
>
>
--
Ferry Huberts
Re: RFE: add sources to bundles
Posted by Paul Bakker <pa...@luminis.eu>.
I had a quick look at it, but it looks like the bundle-plugin is configured
per project, not in the parent pom?
Cheers,
Paul
On Wed, Jun 18, 2014 at 9:27 AM, Karl Pauls <ka...@gmail.com> wrote:
> Attaching the source jars makes a lot of sense - somebody wants to take a
> go at our parent pom?
>
> regards,
>
> Karl
>
>
> On Wed, Jun 18, 2014 at 3:18 PM, Paul Bakker <pa...@luminis.eu>
> wrote:
>
> > +1
> >
> > I believe Maven source jars are already generated, but it would be great
> to
> > also generate the sources in the binaries like Bndtools expects.
> >
> > Cheers,
> >
> > Paul
> >
> >
> > On Wed, Jun 18, 2014 at 9:11 AM, Ferry Huberts <ma...@hupie.com>
> wrote:
> >
> > >
> > >
> > > On 18/06/14 14:48, Raymond Auge wrote:
> > >
> > >> +1
> > >>
> > >> I find if incredibly tiring to have to fetch the source bundles for
> libs
> > >> all the time.
> > >>
> > >> Meanwhile, some libs like bnd for instance, contain the sources and
> that
> > >> makes them a joy to work with.
> > >>
> > >
> > >
> > > the reason I sent this mail is that I have an insane jetty crash that I
> > > wanted to track down. Because no sources were included and I use many
> > felix
> > > bundles with widely differing versions it became a nightmare and I just
> > > gave up.
> > >
> > >
> > >
> > >> However, I could see a counter argument for the size of the archive
> > being
> > >> adversely affected by the inclusion of sources, particularly for those
> > >> small profile installations (particularly embedded).
> > >>
> > >>
> > > I'm sure an acceptable solution can be found.
> > >
> > >
> > >
> > >> On Wed, Jun 18, 2014 at 3:14 AM, Ferry Huberts <ma...@hupie.com>
> > >> wrote:
> > >>
> > >> Hi,
> > >>>
> > >>> I'd like to request that the sources be added to released bundles.
> > >>> This makes debugging so much easier, especially when using bndtools.
> > >>>
> > >>> The bnd instruction to accomplish this (also applicable to the bundle
> > >>> plugin) is:
> > >>> -sources: true
> > >>>
> > >>>
> > >>>
> > >>>
> > >>> --
> > >>> Ferry Huberts
> > >>>
> > >>>
> > >>
> > >>
> > >>
> > > --
> > > Ferry Huberts
> > >
> >
>
>
>
> --
> Karl Pauls
> karlpauls@gmail.com
> http://twitter.com/karlpauls
> http://www.linkedin.com/in/karlpauls
> https://profiles.google.com/karlpauls
>
Re: RFE: add sources to bundles
Posted by Karl Pauls <ka...@gmail.com>.
Attaching the source jars makes a lot of sense - somebody wants to take a
go at our parent pom?
regards,
Karl
On Wed, Jun 18, 2014 at 3:18 PM, Paul Bakker <pa...@luminis.eu> wrote:
> +1
>
> I believe Maven source jars are already generated, but it would be great to
> also generate the sources in the binaries like Bndtools expects.
>
> Cheers,
>
> Paul
>
>
> On Wed, Jun 18, 2014 at 9:11 AM, Ferry Huberts <ma...@hupie.com> wrote:
>
> >
> >
> > On 18/06/14 14:48, Raymond Auge wrote:
> >
> >> +1
> >>
> >> I find if incredibly tiring to have to fetch the source bundles for libs
> >> all the time.
> >>
> >> Meanwhile, some libs like bnd for instance, contain the sources and that
> >> makes them a joy to work with.
> >>
> >
> >
> > the reason I sent this mail is that I have an insane jetty crash that I
> > wanted to track down. Because no sources were included and I use many
> felix
> > bundles with widely differing versions it became a nightmare and I just
> > gave up.
> >
> >
> >
> >> However, I could see a counter argument for the size of the archive
> being
> >> adversely affected by the inclusion of sources, particularly for those
> >> small profile installations (particularly embedded).
> >>
> >>
> > I'm sure an acceptable solution can be found.
> >
> >
> >
> >> On Wed, Jun 18, 2014 at 3:14 AM, Ferry Huberts <ma...@hupie.com>
> >> wrote:
> >>
> >> Hi,
> >>>
> >>> I'd like to request that the sources be added to released bundles.
> >>> This makes debugging so much easier, especially when using bndtools.
> >>>
> >>> The bnd instruction to accomplish this (also applicable to the bundle
> >>> plugin) is:
> >>> -sources: true
> >>>
> >>>
> >>>
> >>>
> >>> --
> >>> Ferry Huberts
> >>>
> >>>
> >>
> >>
> >>
> > --
> > Ferry Huberts
> >
>
--
Karl Pauls
karlpauls@gmail.com
http://twitter.com/karlpauls
http://www.linkedin.com/in/karlpauls
https://profiles.google.com/karlpauls
Re: RFE: add sources to bundles
Posted by Paul Bakker <pa...@luminis.eu>.
+1
I believe Maven source jars are already generated, but it would be great to
also generate the sources in the binaries like Bndtools expects.
Cheers,
Paul
On Wed, Jun 18, 2014 at 9:11 AM, Ferry Huberts <ma...@hupie.com> wrote:
>
>
> On 18/06/14 14:48, Raymond Auge wrote:
>
>> +1
>>
>> I find if incredibly tiring to have to fetch the source bundles for libs
>> all the time.
>>
>> Meanwhile, some libs like bnd for instance, contain the sources and that
>> makes them a joy to work with.
>>
>
>
> the reason I sent this mail is that I have an insane jetty crash that I
> wanted to track down. Because no sources were included and I use many felix
> bundles with widely differing versions it became a nightmare and I just
> gave up.
>
>
>
>> However, I could see a counter argument for the size of the archive being
>> adversely affected by the inclusion of sources, particularly for those
>> small profile installations (particularly embedded).
>>
>>
> I'm sure an acceptable solution can be found.
>
>
>
>> On Wed, Jun 18, 2014 at 3:14 AM, Ferry Huberts <ma...@hupie.com>
>> wrote:
>>
>> Hi,
>>>
>>> I'd like to request that the sources be added to released bundles.
>>> This makes debugging so much easier, especially when using bndtools.
>>>
>>> The bnd instruction to accomplish this (also applicable to the bundle
>>> plugin) is:
>>> -sources: true
>>>
>>>
>>>
>>>
>>> --
>>> Ferry Huberts
>>>
>>>
>>
>>
>>
> --
> Ferry Huberts
>
Re: RFE: add sources to bundles
Posted by Ferry Huberts <ma...@hupie.com>.
On 18/06/14 14:48, Raymond Auge wrote:
> +1
>
> I find if incredibly tiring to have to fetch the source bundles for libs
> all the time.
>
> Meanwhile, some libs like bnd for instance, contain the sources and that
> makes them a joy to work with.
the reason I sent this mail is that I have an insane jetty crash that I
wanted to track down. Because no sources were included and I use many
felix bundles with widely differing versions it became a nightmare and I
just gave up.
>
> However, I could see a counter argument for the size of the archive being
> adversely affected by the inclusion of sources, particularly for those
> small profile installations (particularly embedded).
>
I'm sure an acceptable solution can be found.
>
> On Wed, Jun 18, 2014 at 3:14 AM, Ferry Huberts <ma...@hupie.com> wrote:
>
>> Hi,
>>
>> I'd like to request that the sources be added to released bundles.
>> This makes debugging so much easier, especially when using bndtools.
>>
>> The bnd instruction to accomplish this (also applicable to the bundle
>> plugin) is:
>> -sources: true
>>
>>
>>
>>
>> --
>> Ferry Huberts
>>
>
>
>
--
Ferry Huberts
Re: RFE: add sources to bundles
Posted by Raymond Auge <ra...@liferay.com>.
+1
I find if incredibly tiring to have to fetch the source bundles for libs
all the time.
Meanwhile, some libs like bnd for instance, contain the sources and that
makes them a joy to work with.
However, I could see a counter argument for the size of the archive being
adversely affected by the inclusion of sources, particularly for those
small profile installations (particularly embedded).
On Wed, Jun 18, 2014 at 3:14 AM, Ferry Huberts <ma...@hupie.com> wrote:
> Hi,
>
> I'd like to request that the sources be added to released bundles.
> This makes debugging so much easier, especially when using bndtools.
>
> The bnd instruction to accomplish this (also applicable to the bundle
> plugin) is:
> -sources: true
>
>
>
>
> --
> Ferry Huberts
>
--
*Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
(@rotty3000)
Senior Software Architect
*Liferay, Inc.* <http://www.liferay.com> (@Liferay)