You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by doanduyhai <gi...@git.apache.org> on 2016/01/19 14:54:00 UTC
[GitHub] incubator-zeppelin pull request: Switch to Java 8
GitHub user doanduyhai opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/658
Switch to Java 8
### What is this PR for?
Java 7 is now officially no longer supported by Oracle and Java 8 has been released quite a while. We should take the opportunity to switch to Java 8.
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Task
### Is there a relevant Jira issue?
**[ZEPPELIN-621]**
### How should this be tested?
* Build Zeppelin with `mvn clean -Pxxxx -DskipTests`
* Create some notes with spark/angular/shell interpreter and test some basic use-case
This PR is low risk because Java 8 is backward-compatible with Java 7 source code.
### Screenshots (if appropriate)
N/A
### Questions:
* Does the licenses files need update? --> No
* Is there breaking changes for older versions? --> No
* Does this needs documentation? --> No
[ZEPPELIN-621]: https://issues.apache.org/jira/browse/ZEPPELIN-621
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/doanduyhai/incubator-zeppelin Java8
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/658.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #658
----
commit fa45a49f819ace6937cbe05663ad3cd3d855814f
Author: DuyHai DOAN <do...@gmail.com>
Date: 2016-01-19T13:29:45Z
Switch to Java 8
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Switch to Java 8
Posted by doanduyhai <gi...@git.apache.org>.
Github user doanduyhai closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/658
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Switch to Java 8
Posted by doanduyhai <gi...@git.apache.org>.
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/658#issuecomment-173000019
@felixcheung I create this PR because Cassandra server version 3.0 is using Java 8. Right now, some of the features of the Cassandra interpreter cannot be tested because it requires pulling the server and so requires using Java 8 for the integration test.
In general, all the drivers that work at client side are still staying under Java 7 or even Java 6. But on the server side, it's not a problem to ask for Java 8 (because officially Java 7 is no longer supported). Since Zeppelin is a server technology, it's not that a big deal.
However it's not an urgent matter, so I'm fine if we do not switch to Java 8 right now.
Maybe we need some feedback from the community
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Switch to Java 8
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/658#issuecomment-174133596
Geode interpreter also depends on 1.8 https://issues.apache.org/jira/browse/ZEPPELIN-375
Would be nice to switch gradually too (i.e through profile at first)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Switch to Java 8
Posted by pranasblk <gi...@git.apache.org>.
Github user pranasblk commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/658#issuecomment-183295759
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Switch to Java 8
Posted by doanduyhai <gi...@git.apache.org>.
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/658#issuecomment-173001117
Closing since it's not urgent matter
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Switch to Java 8
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/658#issuecomment-172970750
I think we might need this under a profile switch - there are still a lot of companies running JDK 7 - what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Switch to Java 8
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/658#issuecomment-173023594
For me massive +1, this will allow us to update some ancient library.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Switch to Java 8
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/658#issuecomment-173004999
right - feedback would be good. I think it's a great idea but I can't move to JDK 8 yet ;)
thanks for taking the lead on this though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---