You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "drivebyer (via GitHub)" <gi...@apache.org> on 2023/08/07 05:46:52 UTC
[GitHub] [rocketmq-operator] drivebyer opened a new pull request, #169: [ISSUE #168] Upload auto generated files for third-party reference
drivebyer opened a new pull request, #169:
URL: https://github.com/apache/rocketmq-operator/pull/169
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-operator] caigy merged pull request #169: [ISSUE #168] Upload auto generated files for third-party reference
Posted by "caigy (via GitHub)" <gi...@apache.org>.
caigy merged PR #169:
URL: https://github.com/apache/rocketmq-operator/pull/169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-operator] drivebyer commented on pull request #169: [ISSUE #168] Upload auto generated files for third-party reference
Posted by "drivebyer (via GitHub)" <gi...@apache.org>.
drivebyer commented on PR #169:
URL: https://github.com/apache/rocketmq-operator/pull/169#issuecomment-1677453326
for example:
* https://github.com/minio/operator/tree/master/pkg/apis/minio.min.io/v2
* https://github.com/grafana-operator/grafana-operator/tree/master/api/v1beta1
* https://github.com/cockroachdb/cockroach-operator/tree/master/apis/v1alpha1
* ...
I think we should follow the convention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-operator] drivebyer commented on pull request #169: [ISSUE #168] Upload auto generated files for third-party reference
Posted by "drivebyer (via GitHub)" <gi...@apache.org>.
drivebyer commented on PR #169:
URL: https://github.com/apache/rocketmq-operator/pull/169#issuecomment-1667232838
PTAL @caigy @RongtongJin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-operator] drivebyer commented on pull request #169: [ISSUE #168] Upload auto generated files for third-party reference
Posted by "drivebyer (via GitHub)" <gi...@apache.org>.
drivebyer commented on PR #169:
URL: https://github.com/apache/rocketmq-operator/pull/169#issuecomment-1677460961
PTAL @caigy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #168] Upload auto generated files for third-party reference [rocketmq-operator]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on PR #169:
URL: https://github.com/apache/rocketmq-operator/pull/169#issuecomment-5343252978
**Issue Evaluation**
Category: `enhancement` | Status: **Evaluated**
This requests uploading auto-generated Go files (e.g., `zz_generated_*`) for third-party reference, following conventions from projects like Istio, MinIO, Grafana, and CockroachDB operators.
**Feasibility:** Feasible — standard practice for Kubernetes operators.
**Scope:** `pkg/apis/` directory — generated deepcopy, clientset, informer, and lister code.
**Compatibility:** No breaking changes; improves developer experience for downstream consumers.
This is a good housekeeping improvement. The generated files should be committed alongside the API types to make it easier for external projects to import the CRD types without running code generation locally.
---
*Automated evaluation by RockteMQ-AI*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org