[GitHub] [incubator-doris] imay commented on a change in pull request #2414: fix several races in stream load that could cause BE crash

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #2414: fix several races in stream load that could cause BE crash
URL: https://github.com/apache/incubator-doris/pull/2414#discussion_r355488476
 
 

 ##########
 File path: be/src/runtime/load_channel_mgr.cpp
 ##########
 @@ -213,11 +218,16 @@ Status LoadChannelMgr::_start_bg_worker() {
 
 Status LoadChannelMgr::_start_load_channels_clean() {
     std::vector<std::shared_ptr<LoadChannel>> need_delete_channels;
+    const int32_t max_alive_time = config::streaming_load_rpc_max_alive_time_sec;
+    LOG(INFO) << "start cleaning load channel which is not active for more than " << max_alive_time << " seconds";
     time_t now = time(nullptr);
     {
         std::vector<UniqueId> need_delete_channel_ids;
         std::lock_guard<std::mutex> l(_lock);
+        LOG(INFO) << "there are " << _load_channels.size() << " running load channels";
+        int i = 0;
         for (auto& kv : _load_channels) {
+            LOG(INFO) << "load channel[" << i++ << "]: " << *(kv.second);
 
 Review comment:
   I think there may be too many logs which is not be worthful

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org