You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by Jay357089 <gi...@git.apache.org> on 2016/08/24 02:13:59 UTC
[GitHub] incubator-carbondata pull request #88: [WIP]The exception info is not proper...
GitHub user Jay357089 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/88
[WIP]The exception info is not proper when measure used as columnDict
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jay357089/incubator-carbondata MeasureColDict
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/88.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #88
----
commit 97b9da5307fc75ed8eec24923df9962524a844db
Author: Jay357089 <li...@huawei.com>
Date: 2016-08-24T02:08:01Z
measure can not use columnDict
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #88: [CARBONDATA-173]The exception info is...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/88#discussion_r76234490
--- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala ---
@@ -489,9 +489,10 @@ object GlobalDictionaryUtil extends Logging {
val preDictDimensionOption = dimensions.filter(
_.getColName.equalsIgnoreCase(dimParent))
if (preDictDimensionOption.length == 0) {
- logError(s"No column $dimParent exists in ${table.getDatabaseName}.${table.getTableName}")
- throw new DataLoadingException(s"No column $colName exists " +
- s"in ${table.getDatabaseName}.${table.getTableName}")
+ logError(s"No key column $dimParent exists in ${table.getDatabaseName}.${table.getTableName}")
+ throw new DataLoadingException(s"No key column $colName exists in " +
+ s"${table.getDatabaseName}.${table.getTableName}, please make sure " +
+ s"that $colName can be dictionary.")
--- End diff --
Please add a message only key column can be part of dictionary
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #88: [CARBONDATA-173]The exception info is...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/88
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #88: [CARBONDATA-173]The exception info is...
Posted by Jay357089 <gi...@git.apache.org>.
Github user Jay357089 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/88#discussion_r76372261
--- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala ---
@@ -489,9 +489,10 @@ object GlobalDictionaryUtil extends Logging {
val preDictDimensionOption = dimensions.filter(
_.getColName.equalsIgnoreCase(dimParent))
if (preDictDimensionOption.length == 0) {
- logError(s"No column $dimParent exists in ${table.getDatabaseName}.${table.getTableName}")
- throw new DataLoadingException(s"No column $colName exists " +
- s"in ${table.getDatabaseName}.${table.getTableName}")
+ logError(s"No key column $dimParent exists in ${table.getDatabaseName}.${table.getTableName}")
+ throw new DataLoadingException(s"No key column $colName exists in " +
+ s"${table.getDatabaseName}.${table.getTableName}, please make sure " +
+ s"that $colName can be dictionary.")
--- End diff --
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---