You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jason Brown (JIRA)" <ji...@apache.org> on 2018/05/31 16:41:00 UTC
[jira] [Updated] (CASSANDRA-13631) add header parameter size to
internode messaging protocol
[ https://issues.apache.org/jira/browse/CASSANDRA-13631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Brown updated CASSANDRA-13631:
------------------------------------
Resolution: Duplicate
Status: Resolved (was: Patch Available)
Closing as I rolled this functionality into CASSANDRA-14485
> add header parameter size to internode messaging protocol
> ---------------------------------------------------------
>
> Key: CASSANDRA-13631
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13631
> Project: Cassandra
> Issue Type: Task
> Components: Streaming and Messaging
> Reporter: Jason Brown
> Assignee: Jason Brown
> Priority: Minor
> Fix For: 4.0
>
>
> as netty is not a streaming/blocking protocol and works best when buffer sizes are known, I had to do a bunch of contortions in {{MessageInHandler}} (as part of CASSANDRA-8457) to safely read the message header parameters. If we add a header parameters size field to the internode messaging protocol, the header parsing code would be dramatically simpler (note: we'll still need the existing parsing to support the cluster upgrade use case). An alternative to adding a new field is to hijack the existing header parameter count field; that field is an {{int}}, so field width is not an issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org