You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by wo...@apache.org on 2004/11/05 05:13:41 UTC
cvs commit: jakarta-jmeter/src/protocol/jms/org/apache/jmeter/protocol/jms/client ClientPool.java InitialContextFactory.java ConnectionFactory.java MessageClient.java
woolfel 2004/11/04 20:13:41
Modified: src/protocol/jms/org/apache/jmeter/protocol/jms/client
ClientPool.java InitialContextFactory.java
ConnectionFactory.java
Removed: src/protocol/jms/org/apache/jmeter/protocol/jms/client
MessageClient.java
Log:
added more comments and removed MessageClient, since it's not used
so better to clean things up.
peter
Revision Changes Path
1.3 +4 -2 jakarta-jmeter/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ClientPool.java
Index: ClientPool.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ClientPool.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- ClientPool.java 4 Nov 2004 02:23:57 -0000 1.2
+++ ClientPool.java 5 Nov 2004 04:13:41 -0000 1.3
@@ -23,8 +23,10 @@
/**
* @author pete
*
- * To change the template for this generated type comment go to
- * Window>Preferences>Java>Code Generation>Code and Comments
+ * ClientPool holds the client instances in an ArrayList. The
+ * main purpose of this is to make it easier to clean up all
+ * the instances at the end of a test. If we didn't do this,
+ * threads might become zombie.
*/
public class ClientPool {
1.2 +3 -2 jakarta-jmeter/src/protocol/jms/org/apache/jmeter/protocol/jms/client/InitialContextFactory.java
Index: InitialContextFactory.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/protocol/jms/org/apache/jmeter/protocol/jms/client/InitialContextFactory.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- InitialContextFactory.java 28 Oct 2004 04:52:36 -0000 1.1
+++ InitialContextFactory.java 5 Nov 2004 04:13:41 -0000 1.2
@@ -33,8 +33,9 @@
/**
* @author pete
*
- * To change the template for this generated type comment go to
- * Window>Preferences>Java>Code Generation>Code and Comments
+ * InitialContextFactory is responsible for getting and instance
+ * of the initial context. It is also responsible for looking
+ * up JMS topics and queues.
*/
public class InitialContextFactory {
1.4 +5 -2 jakarta-jmeter/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ConnectionFactory.java
Index: ConnectionFactory.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ConnectionFactory.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- ConnectionFactory.java 4 Nov 2004 02:23:57 -0000 1.3
+++ ConnectionFactory.java 5 Nov 2004 04:13:41 -0000 1.4
@@ -35,8 +35,11 @@
/**
* @author pete
*
- * To change the template for this generated type comment go to
- * Window>Preferences>Java>Code Generation>Code and Comments
+ * ConnectionFactory is responsible for creating new connections.
+ * Eventually, the connection factory should read an external
+ * configuration file and create a pool of connections. The current
+ * implementation just does the basics. Once the tires get kicked
+ * a bit, we can add connection pooling support.
*/
public class ConnectionFactory implements TestListener {
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org