[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4003: Logging framework to use only log4j and wrapper slf4j

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #4003: Logging framework to use only log4j and wrapper slf4j
URL: https://github.com/apache/cloudstack/pull/4003#discussion_r401884130
 
 

 ##########
 File path: utils/src/main/java/com/cloud/utils/backoff/impl/ConstantTimeBackoff.java
 ##########
 @@ -44,7 +41,7 @@
 public class ConstantTimeBackoff extends AdapterBase implements BackoffAlgorithm, ConstantTimeBackoffMBean {
     long _time;
     private final Map<String, Thread> _asleep = new ConcurrentHashMap<String, Thread>();
-    private final static Log LOG = LogFactory.getLog(ConstantTimeBackoff.class);
+    private static final Logger s_logger = Logger.getLogger(ConstantTimeBackoff.class.getName());
 
 Review comment:
   name convention for private statics is all capitals so LOG is a better name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services