You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/04/30 07:46:56 UTC

[GitHub] [skywalking] dmsolr commented on a change in pull request #4736: Increase Vert.x Compatability

dmsolr commented on a change in pull request #4736:
URL: https://github.com/apache/skywalking/pull/4736#discussion_r417819216



##########
File path: apm-sniffer/apm-sdk-plugin/vertx-plugins/vertx-core-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/vertx3/HttpClientRequestImplEndInterceptor.java
##########
@@ -40,11 +40,17 @@ public void onConstruct(EnhancedInstance objInst, Object[] allArguments) {
         String host;
         int port;
         if (allArguments[3] instanceof Integer) {
+            //ver. 3.0.x - 3.3.x

Review comment:
       Yeap. If they have a right witness class in each version range.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org