You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/10 02:35:22 UTC

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #15877: [fix][clients]Check pendingIndividualBatchIndexAcks size in doIndividualBatchAckAsync

gaoran10 commented on code in PR #15877:
URL: https://github.com/apache/pulsar/pull/15877#discussion_r894105483


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java:
##########
@@ -366,6 +360,9 @@ private void doIndividualBatchAckAsync(BatchMessageIdImpl batchMessageId) {
                     return value;
                 });
         bitSet.clear(batchMessageId.getBatchIndex());
+        if (pendingIndividualBatchIndexAcks.size() >= MAX_ACK_GROUP_SIZE) {
+            flush();
+        }

Review Comment:
   Maybe we could add the logic here because only this method could add entries to `pendingIndividualBatchIndexAcks`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org