[GitHub] rvesse commented on a change in pull request #23846: [SPARK-26729][K8S] Make image names under test configurable

[GitBox <gi...@apache.org>]

rvesse commented on a change in pull request #23846: [SPARK-26729][K8S] Make image names under test configurable
URL: https://github.com/apache/spark/pull/23846#discussion_r258964878
 
 

 ##########
 File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SecretsTestsSuite.scala
 ##########
 @@ -72,7 +72,7 @@ private[spark] trait SecretsTestsSuite { k8sSuite: KubernetesSuite =>
           doBasicExecutorPodCheck(executorPod)
           checkSecrets(executorPod)
         },
-        appArgs = Array("1000") // give it enough time for all execs to be visible
+        appArgs = Array("10000") // give it enough time for all execs to be visible
 
 Review comment:
   On a slow cluster these timeouts are too short.  When testing this against our custom named images on a low spec dev cluster this test repeatedly failed because the executors simply didn't launch fast enough

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org