You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Howard Fear <hs...@pooh.pageplus.com> on 1997/07/28 00:32:43 UTC
[PATCH] mod_include handle_endif unused
Dean Gaudet writes:
> After adding static stuff in mod_include I got this:
> mod_include.c:1721: warning: `handle_endif' defined but not used
> When it reaches an endif it calls handle_else... what's up with that ?
The following patch ran through my test page cleanly.
--
Howard Fear I'm just a country perl hacker Jim. hsf@pageplus.com
http://www.pageplus.com/~hsf/ hsf@redcape.com
*** mod_include.c.dist Sun Jul 27 12:54:31 1997
--- mod_include.c Sun Jul 27 12:56:22 1997
***************
*** 1728,1733 ****
--- 1728,1734 ----
#ifdef DEBUG_INCLUDE
rvputs(r, "**** endif conditional_status=\"", *conditional_status ? "1" : "0", "\"\n", NULL);
#endif
+ *printing = 1;
*conditional_status = 1;
return 0;
} else {
***************
*** 1843,1850 ****
continue;
} else if (!strcmp(directive, "endif")) {
if (!if_nesting) {
! ret = handle_else(f, r, error, &conditional_status, &printing);
! printing = 1;
} else {
if_nesting--;
}
--- 1844,1850 ----
continue;
} else if (!strcmp(directive, "endif")) {
if (!if_nesting) {
! ret = handle_endif(f, r, error, &conditional_status, &printing);
} else {
if_nesting--;
}
Re: [PATCH] mod_include handle_endif unused
Posted by Dean Gaudet <dg...@arctic.org>.
+1
Dean
On Sun, 27 Jul 1997, Howard Fear wrote:
>
> Dean Gaudet writes:
> > After adding static stuff in mod_include I got this:
> > mod_include.c:1721: warning: `handle_endif' defined but not used
> > When it reaches an endif it calls handle_else... what's up with that ?
>
> The following patch ran through my test page cleanly.
Re: [PATCH] mod_include handle_endif unused
Posted by Marc Slemko <ma...@worldgate.com>.
+1.
On Sun, 27 Jul 1997, Howard Fear wrote:
>
> Dean Gaudet writes:
> > After adding static stuff in mod_include I got this:
> > mod_include.c:1721: warning: `handle_endif' defined but not used
> > When it reaches an endif it calls handle_else... what's up with that ?
>
> The following patch ran through my test page cleanly.
>
> --
> Howard Fear I'm just a country perl hacker Jim. hsf@pageplus.com
> http://www.pageplus.com/~hsf/ hsf@redcape.com
>
> *** mod_include.c.dist Sun Jul 27 12:54:31 1997
> --- mod_include.c Sun Jul 27 12:56:22 1997
> ***************
> *** 1728,1733 ****
> --- 1728,1734 ----
> #ifdef DEBUG_INCLUDE
> rvputs(r, "**** endif conditional_status=\"", *conditional_status ? "1" : "0", "\"\n", NULL);
> #endif
> + *printing = 1;
> *conditional_status = 1;
> return 0;
> } else {
> ***************
> *** 1843,1850 ****
> continue;
> } else if (!strcmp(directive, "endif")) {
> if (!if_nesting) {
> ! ret = handle_else(f, r, error, &conditional_status, &printing);
> ! printing = 1;
> } else {
> if_nesting--;
> }
> --- 1844,1850 ----
> continue;
> } else if (!strcmp(directive, "endif")) {
> if (!if_nesting) {
> ! ret = handle_endif(f, r, error, &conditional_status, &printing);
> } else {
> if_nesting--;
> }
>