[jira] [Commented] (WICKET-4439) Move classes around so that there are no two packages with the same name in different modules

["Andreas Pieber (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223939#comment-13223939 ] 

Andreas Pieber commented on WICKET-4439:
----------------------------------------

1) I'm still at evaluating WICKET-4439.patch checking if it works correctly to add the osgi manifest.
2) I've copied and attached the src from OsgiPackageAnalyserScript here granting the "Licsensed for inclusion in ASF works" just to make sure that there are no license conflicts
3) WICKET-4439-test.patch: I really like the approach; pretty cool work! Though one comment about line 207...

{code}
if (className.endsWith(".class"))
{code}

...is not completely correct. The osgi import/export statements only describe which packages are available for resource loading. Therefore, if we need to load any packages with other resources than java code we need to check for a file (vs directory) in general rather than for a .class file.
                
> Move classes around so that there are no two packages with the same name in different modules
> ---------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4439
>                 URL: https://issues.apache.org/jira/browse/WICKET-4439
>             Project: Wicket
>          Issue Type: Sub-task
>    Affects Versions: 6.0.0
>            Reporter: Martin Grigorov
>            Priority: Minor
>             Fix For: 6.0.0
>
>         Attachments: OsgiPackageAnalyserScript.java, WICKET-4439-test.patch, WICKET-4439.patch
>
>
> There are several packages which appear in at least two wicket- modules. This causes some troubles when deploying these modules in OSGi containers.
> See http://markmail.org/message/e3isxaqirce2yyfd for more info.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira