You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/07 18:19:48 UTC

[GitHub] [tvm] StrongerXi opened a new pull request, #13311: [Driver] Correctly propogate simple-mode flag in LowerSchedule

StrongerXi opened a new pull request, #13311:
URL: https://github.com/apache/tvm/pull/13311

   Currently one version of `tvm::LowerSchedule` doesn't pass along the input `simple_mode` flag, which causes it to default back to `false`. This commit fixes it by passing along the input flag.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] StrongerXi commented on pull request #13311: [BugFix][Driver] Correctly propogate simple-mode flag in LowerSchedule

Posted by GitBox <gi...@apache.org>.
StrongerXi commented on PR #13311:
URL: https://github.com/apache/tvm/pull/13311#issuecomment-1306056395

   > Thanks for sending this! Would it be possible that we can add some tests with simple_mode set to true/false? Otherwise LGTM.
   
   Thanks. I did look into existing tests for `LowerSchedule` or `tvm.lower`, unfortunately none of them really tests `simple_mode`, which seems to be a convenience flag for debugging/testing purposes.
   
   I could write a simple `tvm.lower(..., simple_mode=...)` unittest, but it actually doesn't go through this problematic version of `LowerSchedule`, which is only used [here](https://github.com/apache/tvm/blob/main/src/relay/backend/te_compiler.cc#L447-L448) and [here](https://github.com/apache/tvm/blob/main/src/relay/backend/te_compiler_cache.cc#L852-L853), and they don't even use the `simple_mode` flag.
   
   I feel like the testing effort here isn't well worth it, but let me know what you think:).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #13311: [Driver] Correctly propogate simple-mode flag in LowerSchedule

Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13311:
URL: https://github.com/apache/tvm/pull/13311#issuecomment-1306010541

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * No users to tag found in teams: `driver` <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao merged pull request #13311: [BugFix][Driver] Correctly propogate simple-mode flag in LowerSchedule

Posted by GitBox <gi...@apache.org>.
junrushao merged PR #13311:
URL: https://github.com/apache/tvm/pull/13311


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] StrongerXi commented on a diff in pull request #13311: [Driver] Correctly propogate simple-mode flag in LowerSchedule

Posted by GitBox <gi...@apache.org>.
StrongerXi commented on code in PR #13311:
URL: https://github.com/apache/tvm/pull/13311#discussion_r1015757679


##########
src/driver/driver_api.cc:
##########
@@ -54,9 +54,6 @@ TVM_REGISTER_PASS_CONFIG_OPTION("tir.use_async_copy", Bool);
 TVM_REGISTER_PASS_CONFIG_OPTION("tir.merge_async_commit_queue_scope", Bool);
 TVM_REGISTER_PASS_CONFIG_OPTION("tir.instrument_lwp", Bool);
 
-using runtime::PackedFunc;
-using runtime::TVMArgs;
-using runtime::TVMRetValue;

Review Comment:
   I deleted these as well because they are not used at all in this file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org