You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by Jeffery Painter <je...@jivecast.com> on 2018/10/02 21:24:43 UTC

Re: svn commit: r1842655 - /turbine/fulcrum/trunk/quartz/pom.xml

Hi dev team,

so... it looks like the double dash in the add-modules kind of breaks
maven when they are commented out :-(

I will try to find a more clean solution, but I was experimenting with
trying to build all of turbine-5.0 and fulcrum with the latest jdk-11...
there are a few hurdles to overcome, but I will see if I can make it
happen and keep you posted.  Happy to take these commits out until I get
it all working if you prefer.

Just let me know.

Thanks!
Jeff


On 10/02/2018 05:03 PM, painter@apache.org wrote:
> Author: painter
> Date: Tue Oct  2 21:03:34 2018
> New Revision: 1842655
>
> URL: http://svn.apache.org/viewvc?rev=1842655&view=rev
> Log:
> Adding some pointers to the pom.xml for those who want to build with JDK 9+
>
> Modified:
>     turbine/fulcrum/trunk/quartz/pom.xml
>
> Modified: turbine/fulcrum/trunk/quartz/pom.xml
> URL: http://svn.apache.org/viewvc/turbine/fulcrum/trunk/quartz/pom.xml?rev=1842655&r1=1842654&r2=1842655&view=diff
> ==============================================================================
> --- turbine/fulcrum/trunk/quartz/pom.xml (original)
> +++ turbine/fulcrum/trunk/quartz/pom.xml Tue Oct  2 21:03:34 2018
> @@ -66,6 +66,32 @@
>    </developers>
>  
>    <dependencies>
> +  
> +    <!-- uncomment if using Java 9 JDK or later -->
> +    <!-- 
> +    <dependency>
> +        <groupId>javax.xml.bind</groupId>
> +        <artifactId>jaxb-api</artifactId>
> +        <version>2.3.0</version>
> +    </dependency>
> +    <dependency>
> +        <groupId>com.sun.xml.bind</groupId>
> +        <artifactId>jaxb-impl</artifactId>
> +        <version>2.3.0</version>
> +    </dependency>
> +    <dependency>
> +        <groupId>com.sun.xml.bind</groupId>
> +        <artifactId>jaxb-core</artifactId>
> +        <version>2.3.0</version>
> +    </dependency>
> +    <dependency>
> +        <groupId>javax.activation</groupId>
> +        <artifactId>activation</artifactId>
> +        <version>1.1.1</version>
> +    </dependency>
> +    -->
> +  
> +  
>      <!-- Test Dependencies -->
>      <dependency>
>        <groupId>junit</groupId>
> @@ -112,10 +138,26 @@
>    <build>
>      <sourceDirectory>${basedir}/src/java</sourceDirectory>
>      <testSourceDirectory>${basedir}/src/test</testSourceDirectory>
> +
> +    <!-- uncomment plugins if using JDK 9 or later -->
> +    <!--
> +    <plugins>
> +        <plugin>
> +            <groupId>org.apache.maven.plugins</groupId>
> +            <artifactId>maven-surefire-plugin</artifactId>
> +            <configuration>
> +                <forkMode>always</forkMode>
> +                <argLine>--add-modules java.xml.bind</argLine>
> +                <argLine>--add-modules java.activation</argLine>
> +                <argLine>--add-opens=java.base/java.lang=ALL-UNNAMED --illegal-access=deny</argLine>
> +            </configuration>
> +        </plugin>
> +    </plugins>
> +    -->
>    </build>
>    
>    <properties>
>      <turbine.site.path>fulcrum/fulcrum-quartz</turbine.site.path>
>    </properties>  
>  
> -</project>
> \ No newline at end of file
> +</project>
>
>



Re: svn commit: r1842655 - /turbine/fulcrum/trunk/quartz/pom.xml

Posted by Jeffery Painter <je...@jivecast.com>.
I would like to note however that torque from trunk builds perfectly
fine with no changes to the pom.xml under jdk-11 !!! :-)

I am still chasing down some issues with turbine build process... I am
mostly getting errors in test related which all report a failure to
start the AvalonComponentService:


Running org.apache.turbine.modules.LayoutLoaderTest
org.apache.turbine.services.InstantiationException: Service
AvalonComponentService failed to initialize

.
.
.

Tests run: 121, Failures: 14, Errors: 66, Skipped: 2

I have been playing with fulcrum/yaafi and other modules to update their
pom's to build (I have no problems there), but no luck as of yet... with
each step, updating my local turbine pom.xml to point to all the latest
snapshots I am building... any other ideas?

-
Jeff




On 10/02/2018 05:24 PM, Jeffery Painter wrote:
> Hi dev team,
>
> so... it looks like the double dash in the add-modules kind of breaks
> maven when they are commented out :-(
>
> I will try to find a more clean solution, but I was experimenting with
> trying to build all of turbine-5.0 and fulcrum with the latest jdk-11...
> there are a few hurdles to overcome, but I will see if I can make it
> happen and keep you posted.  Happy to take these commits out until I get
> it all working if you prefer.
>
> Just let me know.
>
> Thanks!
> Jeff
>
>
> On 10/02/2018 05:03 PM, painter@apache.org wrote:
>> Author: painter
>> Date: Tue Oct  2 21:03:34 2018
>> New Revision: 1842655
>>
>> URL: http://svn.apache.org/viewvc?rev=1842655&view=rev
>> Log:
>> Adding some pointers to the pom.xml for those who want to build with JDK 9+
>>
>> Modified:
>>     turbine/fulcrum/trunk/quartz/pom.xml
>>
>> Modified: turbine/fulcrum/trunk/quartz/pom.xml
>> URL: http://svn.apache.org/viewvc/turbine/fulcrum/trunk/quartz/pom.xml?rev=1842655&r1=1842654&r2=1842655&view=diff
>> ==============================================================================
>> --- turbine/fulcrum/trunk/quartz/pom.xml (original)
>> +++ turbine/fulcrum/trunk/quartz/pom.xml Tue Oct  2 21:03:34 2018
>> @@ -66,6 +66,32 @@
>>    </developers>
>>  
>>    <dependencies>
>> +  
>> +    <!-- uncomment if using Java 9 JDK or later -->
>> +    <!-- 
>> +    <dependency>
>> +        <groupId>javax.xml.bind</groupId>
>> +        <artifactId>jaxb-api</artifactId>
>> +        <version>2.3.0</version>
>> +    </dependency>
>> +    <dependency>
>> +        <groupId>com.sun.xml.bind</groupId>
>> +        <artifactId>jaxb-impl</artifactId>
>> +        <version>2.3.0</version>
>> +    </dependency>
>> +    <dependency>
>> +        <groupId>com.sun.xml.bind</groupId>
>> +        <artifactId>jaxb-core</artifactId>
>> +        <version>2.3.0</version>
>> +    </dependency>
>> +    <dependency>
>> +        <groupId>javax.activation</groupId>
>> +        <artifactId>activation</artifactId>
>> +        <version>1.1.1</version>
>> +    </dependency>
>> +    -->
>> +  
>> +  
>>      <!-- Test Dependencies -->
>>      <dependency>
>>        <groupId>junit</groupId>
>> @@ -112,10 +138,26 @@
>>    <build>
>>      <sourceDirectory>${basedir}/src/java</sourceDirectory>
>>      <testSourceDirectory>${basedir}/src/test</testSourceDirectory>
>> +
>> +    <!-- uncomment plugins if using JDK 9 or later -->
>> +    <!--
>> +    <plugins>
>> +        <plugin>
>> +            <groupId>org.apache.maven.plugins</groupId>
>> +            <artifactId>maven-surefire-plugin</artifactId>
>> +            <configuration>
>> +                <forkMode>always</forkMode>
>> +                <argLine>--add-modules java.xml.bind</argLine>
>> +                <argLine>--add-modules java.activation</argLine>
>> +                <argLine>--add-opens=java.base/java.lang=ALL-UNNAMED --illegal-access=deny</argLine>
>> +            </configuration>
>> +        </plugin>
>> +    </plugins>
>> +    -->
>>    </build>
>>    
>>    <properties>
>>      <turbine.site.path>fulcrum/fulcrum-quartz</turbine.site.path>
>>    </properties>  
>>  
>> -</project>
>> \ No newline at end of file
>> +</project>
>>
>>
>