You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/03/20 07:22:39 UTC
[GitHub] [rocketmq-client-go] xujianhai666 opened a new pull request #457:
feat: support nameserver resolver
xujianhai666 opened a new pull request #457: feat: support nameserver resolver
URL: https://github.com/apache/rocketmq-client-go/pull/457
use nameserver resolver instead of nameserver addr, we can pass
passThrough for direct addr, httpResolver for domain, envResovler
for env param.
Closes #455
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] ShannonDing commented on issue #457: feat:
support nameserver resolver
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on issue #457: feat: support nameserver resolver
URL: https://github.com/apache/rocketmq-client-go/pull/457#issuecomment-603666665
IMO, it is better to add a new nameserver resolver, but for old users, it is better to keep the "WithNameServer" at the same time and do create a default resolver inner for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] ShannonDing commented on a change in pull
request #457: feat: support nameserver resolver
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on a change in pull request #457: feat: support nameserver resolver
URL: https://github.com/apache/rocketmq-client-go/pull/457#discussion_r408552054
##########
File path: primitive/nsresolver.go
##########
@@ -0,0 +1,203 @@
+package primitive
Review comment:
lack off APLv2 header.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] xujianhai666 commented on issue #457: feat:
support nameserver resolver
Posted by GitBox <gi...@apache.org>.
xujianhai666 commented on issue #457: feat: support nameserver resolver
URL: https://github.com/apache/rocketmq-client-go/pull/457#issuecomment-611394980
> IMO, it is better to add a new nameserver resolver, but for old users, it is better to keep the "WithNameServer" at the same time and do create a default resolver inner for it.
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] ShannonDing commented on a change in pull
request #457: feat: support nameserver resolver
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on a change in pull request #457: feat: support nameserver resolver
URL: https://github.com/apache/rocketmq-client-go/pull/457#discussion_r408552194
##########
File path: primitive/nsresolver_test.go
##########
@@ -0,0 +1,117 @@
+package primitive
Review comment:
lack of APLv2 header.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] xujianhai666 commented on issue #457: feat:
support nameserver resolver
Posted by GitBox <gi...@apache.org>.
xujianhai666 commented on issue #457: feat: support nameserver resolver
URL: https://github.com/apache/rocketmq-client-go/pull/457#issuecomment-611385722
> IMO, it is better to add a new nameserver resolver, but for old users, it is better to keep the "WithNameServer" at the same time and do create a default resolver inner for it.
ok, I impl later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services