You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Marcus Eriksson (JIRA)" <ji...@apache.org> on 2018/09/27 11:41:00 UTC
[jira] [Commented] (CASSANDRA-14373) Allow using custom script for
chronicle queue BinLog archival
[ https://issues.apache.org/jira/browse/CASSANDRA-14373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630259#comment-16630259 ]
Marcus Eriksson commented on CASSANDRA-14373:
---------------------------------------------
hey [~psivaraju] thanks for the patch, I rewrote it a bit here: [https://github.com/krummas/cassandra/commits/marcuse/14373]
* make sure nodetool can take multi-word arguments (ie, {{nodetool enablefullquerylog --archive-command "/path/to/executable.sh %path"}} should work) - my solution required me to change the nodetool interpreter from {{/bin/sh}} to {{/bin/bash}} to get arrays, I'll try to figure out a way to do in in posix sh though.
* remove the option to set the --archive-command from enableauditlog - it wasn't working and it looks like it might need some more refactoring of that code to get it working
* Break out the archiving logic in to two separate classes ({{DeletingArchiver}} and {{ExternalArchiver}}) for easier testing
* Reworked the configuration to add binlog specific configuration to its own class
Also wrote a bunch of dtests for audit/fullquerylogging here: [https://github.com/krummas/cassandra-dtest/commits/marcuse/14373] (these also required a CCM change which has been [merged|https://github.com/riptano/ccm/commit/a76e45c1fbe7ebb4ef43de686644c90181e80b29])
I also filed CASSANDRA-14772 to further clean up the audit/fullquerylogging code
Note that 4.0 is currently in feature freeze and one could argue that this is a new feature, but as it simplifies collecting full query logs for replay testing, I'd like to get it in 4.0.
> Allow using custom script for chronicle queue BinLog archival
> -------------------------------------------------------------
>
> Key: CASSANDRA-14373
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14373
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stefan Podkowinski
> Assignee: Pramod K Sivaraju
> Priority: Major
> Labels: lhf, pull-request-available
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It would be nice to allow the user to configure an archival script that will be executed in {{BinLog.onReleased(cycle, file)}} for every deleted bin log, just as we do in {{CommitLogArchiver}}. The script should be able to copy the released file to an external location or do whatever the author hand in mind. Deleting the log file should be delegated to the script as well.
> See CASSANDRA-13983, CASSANDRA-12151 for use cases.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org