You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Nikolay Ananiev <an...@thegdb.com> on 2005/08/23 13:56:16 UTC
Fix for "undefined value" warning in Makefile.PL
This one fixes an "Undefined value" warning in Makefile.PL, when apxs is not
present on Win32.
Index: Makefile.PL
===================================================================
--- Makefile.PL (revision 239256)
+++ Makefile.PL (working copy)
@@ -391,11 +391,15 @@
if ($build->is_dynamic) {
warning
"You'll need to add the following to httpd.conf:",
"",
- " LoadModule perl_module modules/$build->{MODPERL_LIB_DSO}",
"",
- "depending on your build, mod_perl might not live in",
- "the modules/ directory - check the results of",
"",
- " \$ $build->{MP_APXS} -q LIBEXECDIR",
"",
- "and adjust the LoadModule directive accordingly.\n";
+ " LoadModule perl_module modules/$build->{MODPERL_LIB_DSO}";
+
+ if($build->{MP_APXS}) {
+ warning "",
+ "depending on your build, mod_perl might not live in",
+ "the modules/ directory - check the results of",
"",
+ " \$ $build->{MP_APXS} -q LIBEXECDIR",
"",
+ "and adjust the LoadModule directive accordingly.\n";
+ }
}
$build->save;
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Fix for "undefined value" warning in Makefile.PL
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Nikolay Ananiev wrote:
> ok :)
Committed. Thanks!
--
END
------------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Fix for "undefined value" warning in Makefile.PL
Posted by Nikolay Ananiev <an...@thegdb.com>.
ok :)
"Philip M. Gollucci" <pg...@p6m7g8.com> wrote in message
news:430BF59B.1020201@p6m7g8.com...
> Nikolay Ananiev wrote:
> > + " LoadModule perl_module
modules/$build->{MODPERL_LIB_DSO}",
> > +
> > + if($build->{MP_APXS}) {
> > + warning "",
> > + "depending on your build, mod_perl might not live
in",
> > + "the modules/ directory - check the results of",
"",
> > + " \$ $build->{MP_APXS} -q LIBEXECDIR",
"",
> > + "and adjust the LoadModule directive
accordingly.\n";
> > + }
>
> Thanks Nick, but I think I'd move the if a bit:
> Index: Makefile.PL
> ===================================================================
> --- Makefile.PL (revision 234145)
> +++ Makefile.PL (working copy)
> @@ -393,9 +393,13 @@
> "You'll need to add the following to httpd.conf:",
"",
> " LoadModule perl_module
modules/$build->{MODPERL_LIB_DSO}", "",
> "depending on your build, mod_perl might not live in",
> - "the modules/ directory - check the results of",
"",
> - " \$ $build->{MP_APXS} -q LIBEXECDIR",
"",
> - "and adjust the LoadModule directive accordingly.\n";
> + "the modules/ directory.\n";
> + if ($build->{MP_APXS}) {
> + warning
> + "Check the results of",
"",
> + " \$ $build->{MP_APXS} -q LIBEXECDIR",
"",
> + "and adjust the LoadModule directive accordingly.\n";
> + }
> }
>
> $build->save;
>
>
> --
> END
> ------------------------------------------------------------
> What doesn't kill us can only make us stronger.
> Nothing is impossible.
>
> Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
> Consultant / http://p6m7g8.net/Resume/
> Senior Developer / Liquidity Services, Inc.
> http://www.liquidityservicesinc.com
> http://www.liquidation.com
> http://www.uksurplus.com
> http://www.govliquidation.com
> http://www.gowholesale.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Fix for "undefined value" warning in Makefile.PL
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Nikolay Ananiev wrote:
> + " LoadModule perl_module modules/$build->{MODPERL_LIB_DSO}",
> +
> + if($build->{MP_APXS}) {
> + warning "",
> + "depending on your build, mod_perl might not live in",
> + "the modules/ directory - check the results of", "",
> + " \$ $build->{MP_APXS} -q LIBEXECDIR", "",
> + "and adjust the LoadModule directive accordingly.\n";
> + }
Thanks Nick, but I think I'd move the if a bit:
Index: Makefile.PL
===================================================================
--- Makefile.PL (revision 234145)
+++ Makefile.PL (working copy)
@@ -393,9 +393,13 @@
"You'll need to add the following to httpd.conf:", "",
" LoadModule perl_module modules/$build->{MODPERL_LIB_DSO}", "",
"depending on your build, mod_perl might not live in",
- "the modules/ directory - check the results of", "",
- " \$ $build->{MP_APXS} -q LIBEXECDIR", "",
- "and adjust the LoadModule directive accordingly.\n";
+ "the modules/ directory.\n";
+ if ($build->{MP_APXS}) {
+ warning
+ "Check the results of", "",
+ " \$ $build->{MP_APXS} -q LIBEXECDIR", "",
+ "and adjust the LoadModule directive accordingly.\n";
+ }
}
$build->save;
--
END
------------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Fix for "undefined value" warning in Makefile.PL
Posted by Nikolay Ananiev <an...@thegdb.com>.
"Nikolay Ananiev" <an...@thegdb.com> wrote in message
news:deev6o$4r0$1@sea.gmane.org...
> This one fixes an "Undefined value" warning in Makefile.PL, when apxs is
not
> present on Win32.
>
>[...]
Seems like the patch is malformed, so I'm attaching it here.
begin 666 p.txt
M26YD97@Z($UA:V5F:6QE+E!,#0H]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]#0HM
M+2T@36%K969I;&4N4$P)*')E=FES:6]N(#(S.3(U-BD-"BLK*R!-86ME9FEL
M92Y03 DH=V]R:VEN9R!C;W!Y*0T*0$ @+3,Y,2PQ,2 K,SDQ+#$U($! #0H@
M(" @(&EF("@D8G5I;&0M/FES7V1Y;F%M:6,I('L*(" @(" @(" @=V%R;FEN
M9PH@(" @(" @(" @(" @(EEO=2=L;"!N965D('1O(&%D9"!T:&4@9F]L;&]W
M:6YG('1O(&AT='!D+F-O;F8Z(BP@(" @(" @(" @(" B(BP*+2 @(" @(" @
M(" @("(@($QO861-;V1U;&4@<&5R;%]M;V1U;&4@;6]D=6QE<R\D8G5I;&0M
M/GM-3T1015),7TQ)0E]$4T]](BP@(B(L"BT@(" @(" @(" @(" B9&5P96YD
M:6YG(&]N('EO=7(@8G5I;&0L(&UO9%]P97)L(&UI9VAT(&YO="!L:79E(&EN
M(BP*+2 @(" @(" @(" @(")T:&4@;6]D=6QE<R\@9&ER96-T;W)Y("T@8VAE
M8VL@=&AE(')E<W5L=',@;V8B+" @(" @(" @(" @(" @(B(L"BT@(" @(" @
M(" @(" B("!<)" D8G5I;&0M/GM-4%]!4%A3?2 M<2!,24)%6$5#1$E2(BP@
M(" @(" @(" @(" @(" @(" @(" @("(B+ HM(" @(" @(" @(" @(F%N9"!A
M9&IU<W0@=&AE($QO861-;V1U;&4@9&ER96-T:79E(&%C8V]R9&EN9VQY+EQN
M(CL**R @(" @(" @(" @("(@($QO861-;V1U;&4@<&5R;%]M;V1U;&4@;6]D
M=6QE<R\D8G5I;&0M/GM-3T1015),7TQ)0E]$4T]](BP**R @(" @(" @(" @
M( HK(" @(" @(" @(" @:68H)&)U:6QD+3Y[35!?05!84WTI('L**R @(" @
M(" @(" @(" @("!W87)N:6YG("(B+ HK(" @(" @(" @(" @(" @(" @(" B
M9&5P96YD:6YG(&]N('EO=7(@8G5I;&0L(&UO9%]P97)L(&UI9VAT(&YO="!L
M:79E(&EN(BP**R @(" @(" @(" @(" @(" @(" @(G1H92!M;V1U;&5S+R!D
M:7)E8W1O<GD@+2!C:&5C:R!T:&4@<F5S=6QT<R!O9B(L(" @(" @(" @(" @
M(" B(BP**R @(" @(" @(" @(" @(" @(" @(B @7"0@)&)U:6QD+3Y[35!?
M05!84WT@+7$@3$E"15A%0T1)4B(L(" @(" @(" @(" @(" @(" @(" @(" B
M(BP**R @(" @(" @(" @(" @(" @(" @(F%N9"!A9&IU<W0@=&AE($QO861-
M;V1U;&4@9&ER96-T:79E(&%C8V]R9&EN9VQY+EQN(CL**R @(" @(" @(" @
?('T*(" @("!]"B *(" @(" D8G5I;&0M/G-A=F4["@``
`
end
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org