You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by Fokko <gi...@git.apache.org> on 2017/06/04 14:14:03 UTC
[GitHub] flink pull request #4072: [FLINK-6848] Update managed state docs
GitHub user Fokko opened a pull request:
https://github.com/apache/flink/pull/4072
[FLINK-6848] Update managed state docs
Hi guys,
I would like to add an example of how to work with managed state in Scala. The code is tested locally and might be a nice addition to the docs.
Cheers,
Fokko Driesprong
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Fokko/flink fd-update-raw-and-managed-state-docs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4072.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4072
----
commit 8103fc28d10d131eb1273dba4b477c25ac278bf0
Author: Fokko Driesprong <fo...@godatadriven.com>
Date: 2017-06-04T14:08:44Z
Update managed state docs
Add an example of how to work with managed state in Scala
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4072: [FLINK-6848] Update managed state docs
Posted by Fokko <gi...@git.apache.org>.
Github user Fokko commented on the issue:
https://github.com/apache/flink/pull/4072
Hi @tzulitai,
I fully agree. Give me some time to work on the other Scala examples, I need to make sure that they are working properly. I'll wrap it up this week. I'll update the commit and rebase with master.
Cheers, Fokko
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4072: [FLINK-6848] Update managed state docs
Posted by Fokko <gi...@git.apache.org>.
Github user Fokko commented on the issue:
https://github.com/apache/flink/pull/4072
Hi @tzulitai,
I've added some more Scala examples. If you are still missing something, please let me know.
Kind regards, Fokko
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4072: [FLINK-6848] Update managed state docs
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4072
Hi @Fokko, thanks a lot for this contribution!
The current changes look good. However, while you're on it, what do you think about also adding a Scala counterpart example for the other code snippets on the page (e.g. managed operator state, source functions)?
The changes right now are good as is, but I prefer not to merge a "partially documented Scala example", which may give the wrong impression that Scala works only for some cases. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4072: [FLINK-6848] Update managed state docs
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4072
Thanks a lot @Fokko! This looks very good. +1.
Merging this ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4072: [FLINK-6848] Update managed state docs
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4072
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---