[lucy-issues] [jira] [Commented] (CLOWNFISH-4) Account for compiler names with invalid leading whitespace

["Nick Wellnhofer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOWNFISH-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14123451#comment-14123451 ] 

Nick Wellnhofer commented on CLOWNFISH-4:
-----------------------------------------

Pushed two commits to master and 0.4 branch:

- Strip whitespace from --cc argument.
- Fix quoting when calling charmonizer from Perl.

If we also trim the --cc argument in CFC::Perl::Build, a new Lucy release might not be required.

> Account for compiler names with invalid leading whitespace
> ----------------------------------------------------------
>
>                 Key: CLOWNFISH-4
>                 URL: https://issues.apache.org/jira/browse/CLOWNFISH-4
>             Project: Apache Lucy-Clownfish
>          Issue Type: Bug
>            Reporter: Marvin Humphrey
>            Assignee: Nick Wellnhofer
>
> Some CPAN testers are failing because they have goofy configs with leading whitespace for the compiler command.
> http://www.cpantesters.org/cpan/report/4f843ef2-3378-11e4-9edc-fa674cc0d69e
> http://www.cpantesters.org/cpan/report/aac1c602-3361-11e4-9c8b-efd94cc0d69e
> {code}
>      cc=' cc’
>      cc=' clang’
> {code}
> To inoculate ourselves against such weirdness, we should strip whitespace from the supplied compiler command in chaz_CC_init.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)