You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Thomas Marshall <tw...@gmail.com> on 2013/03/12 21:58:04 UTC
Re: Review Request: Clean up HierarchicalAllocatorProcess code
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6665/
-----------------------------------------------------------
(Updated March 12, 2013, 8:58 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Updated to Ben M's review.
Summary (updated)
-----------------
Clean up HierarchicalAllocatorProcess code
Description (updated)
-------
There has been an unfortunate trend in the HierarchicalAllocatorProcess code to use lots of hashmaps between slaveIds or frameworkIds and some attribute of those frameworks/slaves. This patch collapses those into two hashmaps, one for slaves and one for frameworks, mapping ids to structs containing the appropriate attributes. The patch also introduces an allocator namespace.
Diffs (updated)
-----
src/local/local.hpp 2633d25
src/local/local.cpp 3402029
src/master/allocator.hpp b68b67d
src/master/drf_sorter.hpp 79566cc
src/master/drf_sorter.cpp fe31a00
src/master/hierarchical_allocator_process.hpp c1d6f54
src/master/main.cpp ca0abec
src/master/master.hpp c9b4b3f
src/master/master.cpp 814a6e1
src/master/sorter.hpp 73db6b1
src/tests/allocator_tests.cpp b953cd1
src/tests/allocator_zookeeper_tests.cpp 3f70202
src/tests/fault_tolerance_tests.cpp 61509f1
src/tests/gc_tests.cpp fbdd6d6
src/tests/master_detector_tests.cpp 787ba19
src/tests/master_tests.cpp 2ba14fc
src/tests/resource_offers_tests.cpp 44eaf0d
src/tests/sorter_tests.cpp 61e6038
src/tests/utils.hpp d3efa58
third_party/libprocess/third_party/stout/include/stout/stringify.hpp 136316d
Diff: https://reviews.apache.org/r/6665/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request: Clean up HierarchicalAllocatorProcess code
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6665/
-----------------------------------------------------------
(Updated May 9, 2013, 9:49 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Updated to trunk.
Description
-------
There has been an unfortunate trend in the HierarchicalAllocatorProcess code to use lots of hashmaps between slaveIds or frameworkIds and some attribute of those frameworks/slaves. This patch collapses those into two hashmaps, one for slaves and one for frameworks, mapping ids to structs containing the appropriate attributes. The patch also introduces an allocator namespace.
Diffs (updated)
-----
src/local/local.hpp 2633d25
src/local/local.cpp f43ab2a
src/master/allocator.hpp b68b67d
src/master/drf_sorter.hpp 79566cc
src/master/drf_sorter.cpp fe31a00
src/master/hierarchical_allocator_process.hpp 2422fbd
src/master/main.cpp d6e1c73
src/master/master.hpp d3790dc
src/master/master.cpp 3207157
src/master/sorter.hpp 73db6b1
src/tests/allocator_tests.cpp 540c05a
src/tests/allocator_zookeeper_tests.cpp 2c7deb1
src/tests/cluster.hpp 682b7d6
src/tests/fault_tolerance_tests.cpp 68cd5fc
src/tests/isolator_tests.cpp 435c780
src/tests/resource_offers_tests.cpp 5e53a89
src/tests/slave_recovery_tests.cpp d963ce1
src/tests/sorter_tests.cpp 95e8d28
src/tests/utils.hpp ca3ecd7
third_party/libprocess/third_party/stout/include/stout/stringify.hpp 136316d
Diff: https://reviews.apache.org/r/6665/diff/
Testing
-------
On both OSX and Ubuntu (with this patch: https://reviews.apache.org/r/10786/ also applied)
bin/mesos-tests.sh --gtest_break_on_failure --gtest_repeat=2000 --gtest_filter=*Allocator*
Thanks,
Thomas Marshall
Re: Review Request: Clean up HierarchicalAllocatorProcess code
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6665/
-----------------------------------------------------------
(Updated April 26, 2013, 12:31 a.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Updated to trunk.
Description
-------
There has been an unfortunate trend in the HierarchicalAllocatorProcess code to use lots of hashmaps between slaveIds or frameworkIds and some attribute of those frameworks/slaves. This patch collapses those into two hashmaps, one for slaves and one for frameworks, mapping ids to structs containing the appropriate attributes. The patch also introduces an allocator namespace.
Diffs (updated)
-----
src/local/local.hpp 2633d25
src/local/local.cpp f43ab2a
src/master/allocator.hpp b68b67d
src/master/drf_sorter.hpp 79566cc
src/master/drf_sorter.cpp fe31a00
src/master/hierarchical_allocator_process.hpp 2422fbd
src/master/main.cpp d6e1c73
src/master/master.hpp 9776a7c
src/master/master.cpp c3b26b1
src/master/sorter.hpp 73db6b1
src/tests/allocator_tests.cpp 540c05a
src/tests/allocator_zookeeper_tests.cpp 2c7deb1
src/tests/cluster.hpp 682b7d6
src/tests/fault_tolerance_tests.cpp d3476f7
src/tests/isolator_tests.cpp 435c780
src/tests/resource_offers_tests.cpp 5e53a89
src/tests/slave_recovery_tests.cpp c1d2000
src/tests/sorter_tests.cpp 95e8d28
src/tests/utils.hpp ca3ecd7
third_party/libprocess/third_party/stout/include/stout/stringify.hpp 136316d
Diff: https://reviews.apache.org/r/6665/diff/
Testing (updated)
-------
On both OSX and Ubuntu (with this patch: https://reviews.apache.org/r/10786/ also applied)
bin/mesos-tests.sh --gtest_break_on_failure --gtest_repeat=2000 --gtest_filter=*Allocator*
Thanks,
Thomas Marshall
Re: Review Request: Clean up HierarchicalAllocatorProcess code
Posted by Thomas Marshall <tw...@gmail.com>.
> On April 17, 2013, 7:21 p.m., Ben Mahler wrote:
> > src/master/hierarchical_allocator_process.hpp, line 99
> > <https://reviews.apache.org/r/6665/diff/14/?file=281663#file281663line99>
> >
> > Can this be const?
Correct me if I'm wrong, but we can't make this const unless we start saving the Slaves as pointers, since it makes the Slaves unassignable.
> On April 17, 2013, 7:21 p.m., Ben Mahler wrote:
> > src/master/hierarchical_allocator_process.hpp, line 116
> > <https://reviews.apache.org/r/6665/diff/14/?file=281663#file281663line116>
> >
> > Can this be const?
Ditto.
> On April 17, 2013, 7:21 p.m., Ben Mahler wrote:
> > src/master/hierarchical_allocator_process.hpp, line 423
> > <https://reviews.apache.org/r/6665/diff/14/?file=281663#file281663line423>
> >
> > Would love to see a cleanup if this tricky filter deletion in a follow up!
It's on my TODO list.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6665/#review19340
-----------------------------------------------------------
On April 16, 2013, 9:53 p.m., Thomas Marshall wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6665/
> -----------------------------------------------------------
>
> (Updated April 16, 2013, 9:53 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Description
> -------
>
> There has been an unfortunate trend in the HierarchicalAllocatorProcess code to use lots of hashmaps between slaveIds or frameworkIds and some attribute of those frameworks/slaves. This patch collapses those into two hashmaps, one for slaves and one for frameworks, mapping ids to structs containing the appropriate attributes. The patch also introduces an allocator namespace.
>
>
> Diffs
> -----
>
> src/local/local.hpp 2633d25
> src/local/local.cpp f43ab2a
> src/master/allocator.hpp b68b67d
> src/master/drf_sorter.hpp 79566cc
> src/master/drf_sorter.cpp fe31a00
> src/master/hierarchical_allocator_process.hpp 2422fbd
> src/master/main.cpp d6e1c73
> src/master/master.hpp 9776a7c
> src/master/master.cpp 5b0e8c0
> src/master/sorter.hpp 73db6b1
> src/tests/allocator_tests.cpp ca8d4ea
> src/tests/allocator_zookeeper_tests.cpp 82a498e
> src/tests/cluster.hpp 28fc269
> src/tests/fault_tolerance_tests.cpp 0348f20
> src/tests/isolator_tests.cpp 4a115c3
> src/tests/resource_offers_tests.cpp ad3640f
> src/tests/slave_recovery_tests.cpp 7be332b
> src/tests/sorter_tests.cpp 61e6038
> src/tests/utils.hpp b5c577d
> third_party/libprocess/third_party/stout/include/stout/stringify.hpp 136316d
>
> Diff: https://reviews.apache.org/r/6665/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Thomas Marshall
>
>
Re: Review Request: Clean up HierarchicalAllocatorProcess code
Posted by Ben Mahler <be...@gmail.com>.
> On April 17, 2013, 7:21 p.m., Ben Mahler wrote:
> > src/master/hierarchical_allocator_process.hpp, line 99
> > <https://reviews.apache.org/r/6665/diff/14/?file=281663#file281663line99>
> >
> > Can this be const?
>
> Thomas Marshall wrote:
> Correct me if I'm wrong, but we can't make this const unless we start saving the Slaves as pointers, since it makes the Slaves unassignable.
Ah yes, thanks!
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6665/#review19340
-----------------------------------------------------------
On April 26, 2013, 12:31 a.m., Thomas Marshall wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6665/
> -----------------------------------------------------------
>
> (Updated April 26, 2013, 12:31 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Description
> -------
>
> There has been an unfortunate trend in the HierarchicalAllocatorProcess code to use lots of hashmaps between slaveIds or frameworkIds and some attribute of those frameworks/slaves. This patch collapses those into two hashmaps, one for slaves and one for frameworks, mapping ids to structs containing the appropriate attributes. The patch also introduces an allocator namespace.
>
>
> Diffs
> -----
>
> src/local/local.hpp 2633d25
> src/local/local.cpp f43ab2a
> src/master/allocator.hpp b68b67d
> src/master/drf_sorter.hpp 79566cc
> src/master/drf_sorter.cpp fe31a00
> src/master/hierarchical_allocator_process.hpp 2422fbd
> src/master/main.cpp d6e1c73
> src/master/master.hpp 9776a7c
> src/master/master.cpp c3b26b1
> src/master/sorter.hpp 73db6b1
> src/tests/allocator_tests.cpp 540c05a
> src/tests/allocator_zookeeper_tests.cpp 2c7deb1
> src/tests/cluster.hpp 682b7d6
> src/tests/fault_tolerance_tests.cpp d3476f7
> src/tests/isolator_tests.cpp 435c780
> src/tests/resource_offers_tests.cpp 5e53a89
> src/tests/slave_recovery_tests.cpp c1d2000
> src/tests/sorter_tests.cpp 95e8d28
> src/tests/utils.hpp ca3ecd7
> third_party/libprocess/third_party/stout/include/stout/stringify.hpp 136316d
>
> Diff: https://reviews.apache.org/r/6665/diff/
>
>
> Testing
> -------
>
> On both OSX and Ubuntu (with this patch: https://reviews.apache.org/r/10786/ also applied)
>
> bin/mesos-tests.sh --gtest_break_on_failure --gtest_repeat=2000 --gtest_filter=*Allocator*
>
>
> Thanks,
>
> Thomas Marshall
>
>
Re: Review Request: Clean up HierarchicalAllocatorProcess code
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6665/#review19340
-----------------------------------------------------------
Ship it!
This is looking good, can you ensure the allocator tests are all passing on a high number of iterations? Let me know and I can get this committed for you.
src/master/hierarchical_allocator_process.hpp
<https://reviews.apache.org/r/6665/#comment40022>
Can this be const?
src/master/hierarchical_allocator_process.hpp
<https://reviews.apache.org/r/6665/#comment40023>
Can this be const?
src/master/hierarchical_allocator_process.hpp
<https://reviews.apache.org/r/6665/#comment40024>
Would love to see a cleanup if this tricky filter deletion in a follow up!
- Ben Mahler
On April 16, 2013, 9:53 p.m., Thomas Marshall wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6665/
> -----------------------------------------------------------
>
> (Updated April 16, 2013, 9:53 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Description
> -------
>
> There has been an unfortunate trend in the HierarchicalAllocatorProcess code to use lots of hashmaps between slaveIds or frameworkIds and some attribute of those frameworks/slaves. This patch collapses those into two hashmaps, one for slaves and one for frameworks, mapping ids to structs containing the appropriate attributes. The patch also introduces an allocator namespace.
>
>
> Diffs
> -----
>
> src/local/local.hpp 2633d25
> src/local/local.cpp f43ab2a
> src/master/allocator.hpp b68b67d
> src/master/drf_sorter.hpp 79566cc
> src/master/drf_sorter.cpp fe31a00
> src/master/hierarchical_allocator_process.hpp 2422fbd
> src/master/main.cpp d6e1c73
> src/master/master.hpp 9776a7c
> src/master/master.cpp 5b0e8c0
> src/master/sorter.hpp 73db6b1
> src/tests/allocator_tests.cpp ca8d4ea
> src/tests/allocator_zookeeper_tests.cpp 82a498e
> src/tests/cluster.hpp 28fc269
> src/tests/fault_tolerance_tests.cpp 0348f20
> src/tests/isolator_tests.cpp 4a115c3
> src/tests/resource_offers_tests.cpp ad3640f
> src/tests/slave_recovery_tests.cpp 7be332b
> src/tests/sorter_tests.cpp 61e6038
> src/tests/utils.hpp b5c577d
> third_party/libprocess/third_party/stout/include/stout/stringify.hpp 136316d
>
> Diff: https://reviews.apache.org/r/6665/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Thomas Marshall
>
>
Re: Review Request: Clean up HierarchicalAllocatorProcess code
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6665/
-----------------------------------------------------------
(Updated April 16, 2013, 9:53 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Minor fix. Actually updated to trunk now.
Description
-------
There has been an unfortunate trend in the HierarchicalAllocatorProcess code to use lots of hashmaps between slaveIds or frameworkIds and some attribute of those frameworks/slaves. This patch collapses those into two hashmaps, one for slaves and one for frameworks, mapping ids to structs containing the appropriate attributes. The patch also introduces an allocator namespace.
Diffs (updated)
-----
src/local/local.hpp 2633d25
src/local/local.cpp f43ab2a
src/master/allocator.hpp b68b67d
src/master/drf_sorter.hpp 79566cc
src/master/drf_sorter.cpp fe31a00
src/master/hierarchical_allocator_process.hpp 2422fbd
src/master/main.cpp d6e1c73
src/master/master.hpp 9776a7c
src/master/master.cpp 5b0e8c0
src/master/sorter.hpp 73db6b1
src/tests/allocator_tests.cpp ca8d4ea
src/tests/allocator_zookeeper_tests.cpp 82a498e
src/tests/cluster.hpp 28fc269
src/tests/fault_tolerance_tests.cpp 0348f20
src/tests/isolator_tests.cpp 4a115c3
src/tests/resource_offers_tests.cpp ad3640f
src/tests/slave_recovery_tests.cpp 7be332b
src/tests/sorter_tests.cpp 61e6038
src/tests/utils.hpp b5c577d
third_party/libprocess/third_party/stout/include/stout/stringify.hpp 136316d
Diff: https://reviews.apache.org/r/6665/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request: Clean up HierarchicalAllocatorProcess code
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6665/
-----------------------------------------------------------
(Updated April 16, 2013, 9:08 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Updated to trunk.
Description
-------
There has been an unfortunate trend in the HierarchicalAllocatorProcess code to use lots of hashmaps between slaveIds or frameworkIds and some attribute of those frameworks/slaves. This patch collapses those into two hashmaps, one for slaves and one for frameworks, mapping ids to structs containing the appropriate attributes. The patch also introduces an allocator namespace.
Diffs (updated)
-----
src/local/local.hpp 2633d25
src/local/local.cpp f43ab2a
src/master/allocator.hpp b68b67d
src/master/drf_sorter.hpp 79566cc
src/master/drf_sorter.cpp fe31a00
src/master/hierarchical_allocator_process.hpp 2422fbd
src/master/main.cpp d6e1c73
src/master/master.hpp 9776a7c
src/master/master.cpp 5b0e8c0
src/master/sorter.hpp 73db6b1
src/tests/allocator_tests.cpp ca8d4ea
src/tests/allocator_zookeeper_tests.cpp 82a498e
src/tests/fault_tolerance_tests.cpp 0348f20
src/tests/resource_offers_tests.cpp ad3640f
src/tests/slave_recovery_tests.cpp 7be332b
src/tests/sorter_tests.cpp 61e6038
src/tests/utils.hpp b5c577d
third_party/libprocess/third_party/stout/include/stout/stringify.hpp 136316d
Diff: https://reviews.apache.org/r/6665/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request: Clean up HierarchicalAllocatorProcess code
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6665/
-----------------------------------------------------------
(Updated April 2, 2013, midnight)
Review request for mesos and Benjamin Hindman.
Changes
-------
Updated to trunk.
Description
-------
There has been an unfortunate trend in the HierarchicalAllocatorProcess code to use lots of hashmaps between slaveIds or frameworkIds and some attribute of those frameworks/slaves. This patch collapses those into two hashmaps, one for slaves and one for frameworks, mapping ids to structs containing the appropriate attributes. The patch also introduces an allocator namespace.
Diffs (updated)
-----
src/local/local.hpp 2633d25
src/local/local.cpp f43ab2a
src/master/allocator.hpp b68b67d
src/master/drf_sorter.hpp 79566cc
src/master/drf_sorter.cpp fe31a00
src/master/hierarchical_allocator_process.hpp 2422fbd
src/master/main.cpp d6e1c73
src/master/master.hpp 9776a7c
src/master/master.cpp 5b0e8c0
src/master/sorter.hpp 73db6b1
src/tests/allocator_tests.cpp 04a8581
src/tests/allocator_zookeeper_tests.cpp cc6e22e
src/tests/fault_tolerance_tests.cpp d02c9b2
src/tests/gc_tests.cpp 037fe09
src/tests/master_detector_tests.cpp fe3b91f
src/tests/master_tests.cpp c74cb5e
src/tests/resource_offers_tests.cpp 53b92ab
src/tests/slave_recovery_tests.cpp b4276ed
src/tests/sorter_tests.cpp 61e6038
src/tests/status_update_manager_tests.cpp a355ecd
src/tests/utils.hpp 32784a7
third_party/libprocess/third_party/stout/include/stout/stringify.hpp 136316d
Diff: https://reviews.apache.org/r/6665/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request: Clean up HierarchicalAllocatorProcess code
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6665/
-----------------------------------------------------------
(Updated March 21, 2013, 11:10 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Updated to trunk.
Description
-------
There has been an unfortunate trend in the HierarchicalAllocatorProcess code to use lots of hashmaps between slaveIds or frameworkIds and some attribute of those frameworks/slaves. This patch collapses those into two hashmaps, one for slaves and one for frameworks, mapping ids to structs containing the appropriate attributes. The patch also introduces an allocator namespace.
Diffs (updated)
-----
src/local/local.hpp 2633d25
src/local/local.cpp f43ab2a
src/master/allocator.hpp b68b67d
src/master/drf_sorter.hpp 79566cc
src/master/drf_sorter.cpp fe31a00
src/master/hierarchical_allocator_process.hpp 2422fbd
src/master/main.cpp d6e1c73
src/master/master.hpp 9776a7c
src/master/master.cpp 5b0e8c0
src/master/sorter.hpp 73db6b1
src/tests/allocator_tests.cpp e8b835f
src/tests/allocator_zookeeper_tests.cpp 802a508
src/tests/fault_tolerance_tests.cpp 9d3f8b1
src/tests/gc_tests.cpp 67bf957
src/tests/master_detector_tests.cpp fe3b91f
src/tests/master_tests.cpp 16f7637
src/tests/resource_offers_tests.cpp 53b92ab
src/tests/slave_recovery_tests.cpp 47f9b0f
src/tests/sorter_tests.cpp 61e6038
src/tests/status_update_manager_tests.cpp 9ce47b5
src/tests/utils.hpp 5020357
third_party/libprocess/third_party/stout/include/stout/stringify.hpp 136316d
Diff: https://reviews.apache.org/r/6665/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request: Clean up HierarchicalAllocatorProcess code
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6665/#review17760
-----------------------------------------------------------
Ship it!
Also, if you're worried about performance, feel free to re-run your performance test to check for regressions!
- Ben Mahler
On March 12, 2013, 8:58 p.m., Thomas Marshall wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6665/
> -----------------------------------------------------------
>
> (Updated March 12, 2013, 8:58 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Description
> -------
>
> There has been an unfortunate trend in the HierarchicalAllocatorProcess code to use lots of hashmaps between slaveIds or frameworkIds and some attribute of those frameworks/slaves. This patch collapses those into two hashmaps, one for slaves and one for frameworks, mapping ids to structs containing the appropriate attributes. The patch also introduces an allocator namespace.
>
>
> Diffs
> -----
>
> src/local/local.hpp 2633d25
> src/local/local.cpp 3402029
> src/master/allocator.hpp b68b67d
> src/master/drf_sorter.hpp 79566cc
> src/master/drf_sorter.cpp fe31a00
> src/master/hierarchical_allocator_process.hpp c1d6f54
> src/master/main.cpp ca0abec
> src/master/master.hpp c9b4b3f
> src/master/master.cpp 814a6e1
> src/master/sorter.hpp 73db6b1
> src/tests/allocator_tests.cpp b953cd1
> src/tests/allocator_zookeeper_tests.cpp 3f70202
> src/tests/fault_tolerance_tests.cpp 61509f1
> src/tests/gc_tests.cpp fbdd6d6
> src/tests/master_detector_tests.cpp 787ba19
> src/tests/master_tests.cpp 2ba14fc
> src/tests/resource_offers_tests.cpp 44eaf0d
> src/tests/sorter_tests.cpp 61e6038
> src/tests/utils.hpp d3efa58
> third_party/libprocess/third_party/stout/include/stout/stringify.hpp 136316d
>
> Diff: https://reviews.apache.org/r/6665/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Thomas Marshall
>
>