You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Will McQueen (Created) (JIRA)" <ji...@apache.org> on 2011/11/02 04:56:32 UTC
[jira] [Created] (FLUME-831) flume-jdbc-channel project has
unnecessary direct dependency on log4j API
flume-jdbc-channel project has unnecessary direct dependency on log4j API
-------------------------------------------------------------------------
Key: FLUME-831
URL: https://issues.apache.org/jira/browse/FLUME-831
Project: Flume
Issue Type: Bug
Components: Sinks+Sources
Affects Versions: NG alpha 1
Reporter: Will McQueen
Please use slf4j API instead of direct log4j API. So in org.apache.flume.channel.jdbc.JdbcChannel, just change this:
import org.apache.log4j.Logger;
private static final Logger LOG = Logger.getLogger(JdbcChannel.class);
...to this:
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
private static final Logger LOG = LoggerFactory.getLogger(JdbcChannel.class);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-831) flume-jdbc-channel project has
unnecessary direct dependency on log4j API
Posted by "Arvind Prabhakar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar updated FLUME-831:
-----------------------------------
Resolution: Fixed
Fix Version/s: NG beta 1
Status: Resolved (was: Patch Available)
Patch committed.
> flume-jdbc-channel project has unnecessary direct dependency on log4j API
> -------------------------------------------------------------------------
>
> Key: FLUME-831
> URL: https://issues.apache.org/jira/browse/FLUME-831
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 1
> Reporter: Will McQueen
> Assignee: Arvind Prabhakar
> Fix For: NG beta 1
>
>
> Please use slf4j API instead of direct log4j API. So in org.apache.flume.channel.jdbc.JdbcChannel, just change this:
> import org.apache.log4j.Logger;
> private static final Logger LOG = Logger.getLogger(JdbcChannel.class);
> ...to this:
> import org.slf4j.Logger;
> import org.slf4j.LoggerFactory;
> private static final Logger LOG = LoggerFactory.getLogger(JdbcChannel.class);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-831) flume-jdbc-channel project has
unnecessary direct dependency on log4j API
Posted by "E. Sammer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
E. Sammer updated FLUME-831:
----------------------------
Status: Patch Available (was: Open)
Marking as patch available.
> flume-jdbc-channel project has unnecessary direct dependency on log4j API
> -------------------------------------------------------------------------
>
> Key: FLUME-831
> URL: https://issues.apache.org/jira/browse/FLUME-831
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 1
> Reporter: Will McQueen
> Assignee: Arvind Prabhakar
>
> Please use slf4j API instead of direct log4j API. So in org.apache.flume.channel.jdbc.JdbcChannel, just change this:
> import org.apache.log4j.Logger;
> private static final Logger LOG = Logger.getLogger(JdbcChannel.class);
> ...to this:
> import org.slf4j.Logger;
> import org.slf4j.LoggerFactory;
> private static final Logger LOG = LoggerFactory.getLogger(JdbcChannel.class);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-831) flume-jdbc-channel project has
unnecessary direct dependency on log4j API
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146617#comment-13146617 ]
jiraposter@reviews.apache.org commented on FLUME-831:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2739/#review3119
-----------------------------------------------------------
Ship it!
lgtm
- Prasad
On 2011-11-07 03:53:10, Arvind Prabhakar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2739/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-07 03:53:10)
bq.
bq.
bq. Review request for Flume, Prasad Mujumdar and Eric Sammer.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Removed the log4j dependency from flume-jdbc-channel module.
bq.
bq.
bq. This addresses bug FLUME-831.
bq. https://issues.apache.org/jira/browse/FLUME-831
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-channels/flume-jdbc-channel/pom.xml 3586253
bq. flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/JdbcChannel.java 6a3ea42
bq.
bq. Diff: https://reviews.apache.org/r/2739/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Built the modules without any errors.
bq.
bq.
bq. Thanks,
bq.
bq. Arvind
bq.
bq.
> flume-jdbc-channel project has unnecessary direct dependency on log4j API
> -------------------------------------------------------------------------
>
> Key: FLUME-831
> URL: https://issues.apache.org/jira/browse/FLUME-831
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 1
> Reporter: Will McQueen
> Assignee: Arvind Prabhakar
>
> Please use slf4j API instead of direct log4j API. So in org.apache.flume.channel.jdbc.JdbcChannel, just change this:
> import org.apache.log4j.Logger;
> private static final Logger LOG = Logger.getLogger(JdbcChannel.class);
> ...to this:
> import org.slf4j.Logger;
> import org.slf4j.LoggerFactory;
> private static final Logger LOG = LoggerFactory.getLogger(JdbcChannel.class);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-831) flume-jdbc-channel project has
unnecessary direct dependency on log4j API
Posted by "Will McQueen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141945#comment-13141945 ]
Will McQueen commented on FLUME-831:
------------------------------------
flume-ng-channels/flume-jdbc-channel/pom.xml also needs to be updated so that we replace this:
<dependency>
<groupId>log4j</groupId>
<artifactId>log4j</artifactId>
</dependency>
...with this:
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>
> flume-jdbc-channel project has unnecessary direct dependency on log4j API
> -------------------------------------------------------------------------
>
> Key: FLUME-831
> URL: https://issues.apache.org/jira/browse/FLUME-831
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 1
> Reporter: Will McQueen
> Assignee: Arvind Prabhakar
>
> Please use slf4j API instead of direct log4j API. So in org.apache.flume.channel.jdbc.JdbcChannel, just change this:
> import org.apache.log4j.Logger;
> private static final Logger LOG = Logger.getLogger(JdbcChannel.class);
> ...to this:
> import org.slf4j.Logger;
> import org.slf4j.LoggerFactory;
> private static final Logger LOG = LoggerFactory.getLogger(JdbcChannel.class);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-831) flume-jdbc-channel project has
unnecessary direct dependency on log4j API
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153050#comment-13153050 ]
Hudson commented on FLUME-831:
------------------------------
Integrated in flume-728 #62 (See [https://builds.apache.org/job/flume-728/62/])
FLUME-831. Removing log4j dependency from flume-jdbc channel.
arvind : http://svn.apache.org/viewvc/?view=rev&rev=1203783
Files :
* /incubator/flume/branches/flume-728
* /incubator/flume/branches/flume-728/flume-ng-channels
* /incubator/flume/branches/flume-728/flume-ng-channels/flume-jdbc-channel/pom.xml
* /incubator/flume/branches/flume-728/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/JdbcChannel.java
* /incubator/flume/branches/flume-728/flume-ng-sinks
> flume-jdbc-channel project has unnecessary direct dependency on log4j API
> -------------------------------------------------------------------------
>
> Key: FLUME-831
> URL: https://issues.apache.org/jira/browse/FLUME-831
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 1
> Reporter: Will McQueen
> Assignee: Arvind Prabhakar
> Fix For: NG beta 1
>
>
> Please use slf4j API instead of direct log4j API. So in org.apache.flume.channel.jdbc.JdbcChannel, just change this:
> import org.apache.log4j.Logger;
> private static final Logger LOG = Logger.getLogger(JdbcChannel.class);
> ...to this:
> import org.slf4j.Logger;
> import org.slf4j.LoggerFactory;
> private static final Logger LOG = LoggerFactory.getLogger(JdbcChannel.class);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (FLUME-831) flume-jdbc-channel project has
unnecessary direct dependency on log4j API
Posted by "Arvind Prabhakar (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar reassigned FLUME-831:
--------------------------------------
Assignee: Arvind Prabhakar
> flume-jdbc-channel project has unnecessary direct dependency on log4j API
> -------------------------------------------------------------------------
>
> Key: FLUME-831
> URL: https://issues.apache.org/jira/browse/FLUME-831
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 1
> Reporter: Will McQueen
> Assignee: Arvind Prabhakar
>
> Please use slf4j API instead of direct log4j API. So in org.apache.flume.channel.jdbc.JdbcChannel, just change this:
> import org.apache.log4j.Logger;
> private static final Logger LOG = Logger.getLogger(JdbcChannel.class);
> ...to this:
> import org.slf4j.Logger;
> import org.slf4j.LoggerFactory;
> private static final Logger LOG = LoggerFactory.getLogger(JdbcChannel.class);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-831) flume-jdbc-channel project has
unnecessary direct dependency on log4j API
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145226#comment-13145226 ]
jiraposter@reviews.apache.org commented on FLUME-831:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2739/#review3071
-----------------------------------------------------------
Please add direct dep on slf4j-API in Pom file as well
- Will
On 2011-11-07 03:53:10, Arvind Prabhakar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2739/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-07 03:53:10)
bq.
bq.
bq. Review request for Flume, Prasad Mujumdar and Eric Sammer.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Removed the log4j dependency from flume-jdbc-channel module.
bq.
bq.
bq. This addresses bug FLUME-831.
bq. https://issues.apache.org/jira/browse/FLUME-831
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-channels/flume-jdbc-channel/pom.xml 3586253
bq. flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/JdbcChannel.java 6a3ea42
bq.
bq. Diff: https://reviews.apache.org/r/2739/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Built the modules without any errors.
bq.
bq.
bq. Thanks,
bq.
bq. Arvind
bq.
bq.
> flume-jdbc-channel project has unnecessary direct dependency on log4j API
> -------------------------------------------------------------------------
>
> Key: FLUME-831
> URL: https://issues.apache.org/jira/browse/FLUME-831
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 1
> Reporter: Will McQueen
> Assignee: Arvind Prabhakar
>
> Please use slf4j API instead of direct log4j API. So in org.apache.flume.channel.jdbc.JdbcChannel, just change this:
> import org.apache.log4j.Logger;
> private static final Logger LOG = Logger.getLogger(JdbcChannel.class);
> ...to this:
> import org.slf4j.Logger;
> import org.slf4j.LoggerFactory;
> private static final Logger LOG = LoggerFactory.getLogger(JdbcChannel.class);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-831) flume-jdbc-channel project has
unnecessary direct dependency on log4j API
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145209#comment-13145209 ]
jiraposter@reviews.apache.org commented on FLUME-831:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2739/
-----------------------------------------------------------
Review request for Flume, Prasad Mujumdar and Eric Sammer.
Summary
-------
Removed the log4j dependency from flume-jdbc-channel module.
This addresses bug FLUME-831.
https://issues.apache.org/jira/browse/FLUME-831
Diffs
-----
flume-ng-channels/flume-jdbc-channel/pom.xml 3586253
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/JdbcChannel.java 6a3ea42
Diff: https://reviews.apache.org/r/2739/diff
Testing
-------
Built the modules without any errors.
Thanks,
Arvind
> flume-jdbc-channel project has unnecessary direct dependency on log4j API
> -------------------------------------------------------------------------
>
> Key: FLUME-831
> URL: https://issues.apache.org/jira/browse/FLUME-831
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 1
> Reporter: Will McQueen
> Assignee: Arvind Prabhakar
>
> Please use slf4j API instead of direct log4j API. So in org.apache.flume.channel.jdbc.JdbcChannel, just change this:
> import org.apache.log4j.Logger;
> private static final Logger LOG = Logger.getLogger(JdbcChannel.class);
> ...to this:
> import org.slf4j.Logger;
> import org.slf4j.LoggerFactory;
> private static final Logger LOG = LoggerFactory.getLogger(JdbcChannel.class);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira