You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Hairong Kuang (JIRA)" <ji...@apache.org> on 2010/05/19 20:21:58 UTC

[jira] Created: (HDFS-1165) createSymlink should not hold the fsnamesytem lock when sync its edit log to disk

createSymlink should not hold the fsnamesytem lock when sync its edit log to disk
---------------------------------------------------------------------------------

                 Key: HDFS-1165
                 URL: https://issues.apache.org/jira/browse/HDFS-1165
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: name-node
    Affects Versions: 0.21.0
            Reporter: Hairong Kuang
            Assignee: Eli Collins
            Priority: Blocker
             Fix For: 0.21.0, 0.22.0


Holding the fsnamesytem lock while calling logSync is unnecessary and decrease NameNode performance.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HDFS-1165) createSymlink should not hold the fsnamesytem lock when sync its edit log to disk

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869249#action_12869249 ] 

Todd Lipcon commented on HDFS-1165:
-----------------------------------

This is fixed in HDFS-988 (which generally cleans up synchronization and safemode checks throughout FSN). I need to do a unit test over there, then it should be good to commit.

> createSymlink should not hold the fsnamesytem lock when sync its edit log to disk
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-1165
>                 URL: https://issues.apache.org/jira/browse/HDFS-1165
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Hairong Kuang
>            Assignee: Eli Collins
>            Priority: Blocker
>             Fix For: 0.21.0, 0.22.0
>
>
> Holding the fsnamesytem lock while calling logSync is unnecessary and decrease NameNode performance.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HDFS-1165) createSymlink should not hold the fsnamesytem lock when sync its edit log to disk

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon resolved HDFS-1165.
-------------------------------

    Resolution: Duplicate

Since HDFS-988 is marked blocker, and I should have a unit test for it ready soon, I'm marking this one as duplicate.

> createSymlink should not hold the fsnamesytem lock when sync its edit log to disk
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-1165
>                 URL: https://issues.apache.org/jira/browse/HDFS-1165
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Hairong Kuang
>            Assignee: Eli Collins
>            Priority: Blocker
>             Fix For: 0.21.0, 0.22.0
>
>
> Holding the fsnamesytem lock while calling logSync is unnecessary and decrease NameNode performance.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HDFS-1165) createSymlink should not hold the fsnamesytem lock when sync its edit log to disk

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869343#action_12869343 ] 

Eli Collins commented on HDFS-1165:
-----------------------------------

Good find Hairong. Assuming HDFS-988 goes into 21 I think we can close this,  unless Todd do you want to pull out that particular fix to a patch for this jira?

> createSymlink should not hold the fsnamesytem lock when sync its edit log to disk
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-1165
>                 URL: https://issues.apache.org/jira/browse/HDFS-1165
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Hairong Kuang
>            Assignee: Eli Collins
>            Priority: Blocker
>             Fix For: 0.21.0, 0.22.0
>
>
> Holding the fsnamesytem lock while calling logSync is unnecessary and decrease NameNode performance.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.