[jira] [Resolved] (SLING-4346) Sightly: HtmlParser does not parse documents correctly when comments span across internal char buffer size

["Felix Meschberger (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SLING-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger resolved SLING-4346.
--------------------------------------
       Resolution: Fixed
    Fix Version/s:     (was: Scripting Sightly Engine 1.0.2)
                   Scripting Sightly Engine 1.0.0
         Assignee: Felix Meschberger

Thanks for providing the patch. I have applied it in Rev. 1654218

> Sightly: HtmlParser does not parse documents correctly when comments span across internal char buffer size
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: SLING-4346
>                 URL: https://issues.apache.org/jira/browse/SLING-4346
>             Project: Sling
>          Issue Type: Bug
>          Components: Scripting
>            Reporter: Vlad Bailescu
>            Assignee: Felix Meschberger
>             Fix For: Scripting Sightly Engine 1.0.0
>
>         Attachments: SLING-4346_Sightly__HtmlParser_does_not_parse_documents_correctly_when_comments_span_acros.patch
>
>
> The HTML parser used by Sightly to process templates is parsing incorrectly comments that span across it's internal char buffer size. Right now the buffer is set to 2048 characters, making the problem hard to see.
> The problem can be exposed by lowering the buffer size to 10 and feeding a string such as {code:java}"test test <!--/*comment*/-->"{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)