You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/13 09:37:40 UTC
[GitHub] [dolphinscheduler] caishunfeng opened a new pull request, #10026: [Bug] fix docker-compose init schema
caishunfeng opened a new pull request, #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10026: [Bug] fix docker-compose init schema
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#issuecomment-1125880063
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10026)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=CODE_SMELL) [20 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10026&metric=new_coverage&view=list) [55.9% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10026&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10026&metric=new_duplicated_lines_density&view=list) [2.2% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10026&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10026: [Bug] fix run on docker and k8s
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#issuecomment-1127290009
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10026)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10026&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10026&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10026: [Bug] fix docker-compose init schema
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#discussion_r872277942
##########
deploy/docker/docker-compose.yml:
##########
@@ -19,6 +19,9 @@ version: "3.8"
services:
dolphinscheduler-postgresql:
image: bitnami/postgresql:11.11.0
Review Comment:
Yes. We use this image as datasource E2E test in ```dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/resources/docker/datasource-postgresql/docker-compose.yaml```. But I'm not familiar with postgres stable version...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10026: [Bug] fix run on docker and k8s
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#discussion_r873277977
##########
deploy/kubernetes/dolphinscheduler/templates/job-dolphinscheduler-schema-initializer.yaml:
##########
@@ -38,10 +38,12 @@ spec:
image: {{ include "dolphinscheduler.image.fullname.tools" . }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
args:
- - bin/create-schema.sh
+ - tools/bin/upgrade-schema.sh
Review Comment:
I think we should add a variable to judge whether it is docker in ```upgrade-schema.sh```. If it is docker, we will not execute ```source dolphinscheduler-env.sh```. Otherwise, the no such file error will be printed to terminal which will misleading the user's judgment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10026: [Bug] fix run on docker and k8s
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#issuecomment-1126898311
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10026)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=CODE_SMELL) [20 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10026&metric=new_coverage&view=list) [53.8% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10026&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10026&metric=new_duplicated_lines_density&view=list) [2.1% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10026&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #10026: [Bug] fix run on docker and k8s
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#discussion_r873140319
##########
docs/docs/en/guide/start/docker.md:
##########
@@ -56,7 +56,15 @@ $ tar -zxf apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src.tar.gz
$ cd apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src/deploy/docker
# For Windows users
$ cd apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src\deploy\docker
Review Comment:
Sorry, I can't get the point of this change, and I think the original description is ok.
##########
docs/docs/en/guide/start/docker.md:
##########
@@ -56,7 +56,15 @@ $ tar -zxf apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src.tar.gz
$ cd apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src/deploy/docker
# For Windows users
$ cd apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src\deploy\docker
-$ docker-compose up -d
+
+# Initialize the database, use profile schema-init
+$ docker-compose --profile schema-init up -d
+
+# start api-server
+$ docker-compose up dolphinscheduler-postgresql dolphinscheduler-zookeeper dolphinscheduler-api
+
Review Comment:
I had removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #10026: [Bug] fix run on docker and k8s
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#discussion_r873140855
##########
deploy/docker/docker-compose.yml:
##########
@@ -66,15 +71,14 @@ services:
image: ${HUB}/dolphinscheduler-api:${TAG}
ports:
- "12345:12345"
+ profiles: ["all"]
env_file: .env
healthcheck:
test: [ "CMD", "curl", "http://localhost:12345/actuator/health" ]
Review Comment:
I had updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #10026: [Bug] fix run on docker and k8s
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#issuecomment-1126897230
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10026?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10026](https://codecov.io/gh/apache/dolphinscheduler/pull/10026?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ed9a8a) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/baf654cb47d60a753dd6372698ebb9230fca4859?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (baf654c) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## dev #10026 +/- ##
============================================
- Coverage 40.89% 40.88% -0.01%
+ Complexity 4631 4630 -1
============================================
Files 839 839
Lines 33983 33983
Branches 3764 3764
============================================
- Hits 13896 13894 -2
- Misses 18756 18757 +1
- Partials 1331 1332 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/10026?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `77.77% <0.00%> (-5.56%)` | :arrow_down: |
| [...r/plugin/task/sqoop/parameter/SqoopParameters.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10026/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci10YXNrLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXRhc2stc3Fvb3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcGx1Z2luL3Rhc2svc3Fvb3AvcGFyYW1ldGVyL1Nxb29wUGFyYW1ldGVycy5qYXZh) | `53.33% <0.00%> (-1.34%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10026?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10026?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [baf654c...3ed9a8a](https://codecov.io/gh/apache/dolphinscheduler/pull/10026?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #10026: [Bug] fix run on docker and k8s
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#discussion_r873139877
##########
deploy/docker/docker-compose.yml:
##########
@@ -19,6 +19,9 @@ version: "3.8"
services:
dolphinscheduler-postgresql:
image: bitnami/postgresql:11.11.0
+ ports:
+ - "5432:5432"
+ profiles: ["all", "schema-init"]
Review Comment:
I had changed the doc of docker-compose version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10026: [Bug] fix run on docker and k8s
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#issuecomment-1126924890
I restart the failed CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10026: [Bug] fix docker-compose init schema
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#discussion_r872901350
##########
deploy/docker/docker-compose.yml:
##########
@@ -19,6 +19,9 @@ version: "3.8"
services:
dolphinscheduler-postgresql:
image: bitnami/postgresql:11.11.0
Review Comment:
Bitami is part of VMware. I didn't know it for so many years...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #10026: [Bug] fix docker-compose init schema
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#discussion_r873099920
##########
deploy/docker/docker-compose.yml:
##########
@@ -19,6 +19,9 @@ version: "3.8"
services:
dolphinscheduler-postgresql:
image: bitnami/postgresql:11.11.0
+ ports:
+ - "5432:5432"
+ profiles: ["all", "schema-init"]
Review Comment:
> BTW, we should change the document and note users should use `docker-comopse` after version `1.28.0` according https://docs.docker.com/compose/release-notes/#1280. And I find out all examples in https://docs.docker.com/compose/profiles/ using `version: "3.9"`, did you test 3.8 locally?
Yes, I test `version: "3.8"` at local and it's ok. I will change the doc of docker-compose version. Thanks for your reminder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10026: [Bug] fix run on docker and k8s
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#discussion_r873159260
##########
docs/docs/en/guide/start/docker.md:
##########
@@ -56,7 +56,15 @@ $ tar -zxf apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src.tar.gz
$ cd apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src/deploy/docker
# For Windows users
$ cd apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src\deploy\docker
Review Comment:
I think we should only provide one single command to our users which they could directly copy paste and the command. They should see our comment or note only if they use another system
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #10026: [Bug] fix run on docker and k8s
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#discussion_r873142202
##########
deploy/docker/docker-compose.yml:
##########
@@ -51,6 +55,7 @@ services:
dolphinscheduler-schema-initializer:
image: ${HUB}/dolphinscheduler-tools:${TAG}
env_file: .env
+ profiles: ["schema-init"]
command: [ bin/create-schema.sh ]
Review Comment:
> In `create/upgrade-schema.sh` will `source bin/env/dolphinscheduler-env.sh`. I think the `.env` file may not working in containers currently.
I found that `source bin/env/dolphinscheduler-env.sh` in `upgrade-scheme.sh` will not work because there is no such script file. So the .env file works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #10026: [Bug] fix run on docker and k8s
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#discussion_r873320851
##########
deploy/docker/.env:
##########
@@ -17,6 +17,7 @@
#
HUB=ghcr.io/apache/dolphinscheduler
TAG=latest
+DOCKER=TRUE
Review Comment:
This is already set in all `Dockerfile`
https://github.com/apache/dolphinscheduler/blob/67cc260d52c1f2e5aa7db76aa8621cdd0f8c4ee0/dolphinscheduler-tools/src/main/docker/Dockerfile#L20-L21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng merged pull request #10026: [Bug] fix run on docker and k8s
Posted by GitBox <gi...@apache.org>.
caishunfeng merged PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #10026: [Bug] fix run on docker and k8s
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#discussion_r873305294
##########
deploy/kubernetes/dolphinscheduler/templates/job-dolphinscheduler-schema-initializer.yaml:
##########
@@ -38,10 +38,12 @@ spec:
image: {{ include "dolphinscheduler.image.fullname.tools" . }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
args:
- - bin/create-schema.sh
+ - tools/bin/upgrade-schema.sh
Review Comment:
Good suggestion. I had updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10026: [Bug] fix docker-compose init schema
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#discussion_r872986345
##########
deploy/docker/docker-compose.yml:
##########
@@ -66,15 +71,14 @@ services:
image: ${HUB}/dolphinscheduler-api:${TAG}
ports:
- "12345:12345"
+ profiles: ["all"]
env_file: .env
healthcheck:
test: [ "CMD", "curl", "http://localhost:12345/actuator/health" ]
Review Comment:
This should change to ```http://localhost:12345/dolphinscheduler/actuator/health``` since we have context path in ```api-server```.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10026: [Bug] fix run on docker and k8s
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#issuecomment-1127198272
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10026)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10026&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10026&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10026&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #10026: [Bug] fix docker-compose init schema
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#discussion_r872526129
##########
deploy/docker/docker-compose.yml:
##########
@@ -19,6 +19,9 @@ version: "3.8"
services:
dolphinscheduler-postgresql:
image: bitnami/postgresql:11.11.0
Review Comment:
bitnami is part of VMware and is very wildly used and trusted so I think it's ok to use it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #10026: [Bug] fix run on docker and k8s
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#discussion_r873364701
##########
deploy/docker/.env:
##########
@@ -17,6 +17,7 @@
#
HUB=ghcr.io/apache/dolphinscheduler
TAG=latest
+DOCKER=TRUE
Review Comment:
> This is already set in all `Dockerfile`
>
> https://github.com/apache/dolphinscheduler/blob/67cc260d52c1f2e5aa7db76aa8621cdd0f8c4ee0/dolphinscheduler-tools/src/main/docker/Dockerfile#L20-L21
I had updated and thanks for your reminder, YYDS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10026: [Bug] fix docker-compose init schema
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#discussion_r872488495
##########
docs/docs/en/guide/start/docker.md:
##########
@@ -56,7 +56,15 @@ $ tar -zxf apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src.tar.gz
$ cd apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src/deploy/docker
# For Windows users
$ cd apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src\deploy\docker
Review Comment:
```suggestion
# For Windows users, you should run command `cd apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src\deploy\docker`
```
##########
deploy/docker/docker-compose.yml:
##########
@@ -19,6 +19,9 @@ version: "3.8"
services:
dolphinscheduler-postgresql:
image: bitnami/postgresql:11.11.0
+ ports:
+ - "5432:5432"
+ profiles: ["all", "schema-init"]
Review Comment:
Thanks, I learn the new statement `profile` of `docker-compose`
##########
docs/docs/en/guide/start/docker.md:
##########
@@ -56,7 +56,15 @@ $ tar -zxf apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src.tar.gz
$ cd apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src/deploy/docker
# For Windows users
$ cd apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src\deploy\docker
-$ docker-compose up -d
+
+# Initialize the database, use profile schema-init
+$ docker-compose --profile schema-init up -d
+
+# start api-server
+$ docker-compose up dolphinscheduler-postgresql dolphinscheduler-zookeeper dolphinscheduler-api
+
Review Comment:
I think we should directly remove this command, because when we run `--profile all` will create and start all server we need, correct me if I wrong
##########
docs/docs/en/guide/start/docker.md:
##########
@@ -111,6 +123,7 @@ $ docker run -d --name dolphinscheduler-alert-server \
-e SPRING_DATASOURCE_USERNAME="<USER>" \
-e SPRING_DATASOURCE_PASSWORD="<PASSWORD>" \
-e REGISTRY_ZOOKEEPER_CONNECT_STRING="localhost:2181" \
+ --net host \
Review Comment:
Good catch!
##########
deploy/docker/docker-compose.yml:
##########
@@ -19,6 +19,9 @@ version: "3.8"
services:
dolphinscheduler-postgresql:
image: bitnami/postgresql:11.11.0
+ ports:
+ - "5432:5432"
+ profiles: ["all", "schema-init"]
Review Comment:
BTW, we should change the document and note users should use `docker-comopse` after version `1.28.0` according https://docs.docker.com/compose/release-notes/#1280. And I find out all examples in https://docs.docker.com/compose/profiles/ using `version: "3.9"`, did you test 3.8 locally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10026: [Bug] fix docker-compose init schema
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#discussion_r872197465
##########
deploy/docker/docker-compose.yml:
##########
@@ -19,6 +19,9 @@ version: "3.8"
services:
dolphinscheduler-postgresql:
image: bitnami/postgresql:11.11.0
Review Comment:
I would suggest using the official image of postgres instead of a third party image. Which is more stablity and more authority.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #10026: [Bug] fix docker-compose init schema
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#discussion_r872275257
##########
deploy/docker/docker-compose.yml:
##########
@@ -19,6 +19,9 @@ version: "3.8"
services:
dolphinscheduler-postgresql:
image: bitnami/postgresql:11.11.0
Review Comment:
> I would suggest using the official image of postgres instead of a third party image. Which is more stablity and more authority.
Do you mean `https://hub.docker.com/_/postgres?tab=description`? Can you give some suggestion of the stable version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10026: [Bug] fix docker-compose init schema
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#discussion_r872986241
##########
deploy/docker/docker-compose.yml:
##########
@@ -51,6 +55,7 @@ services:
dolphinscheduler-schema-initializer:
image: ${HUB}/dolphinscheduler-tools:${TAG}
env_file: .env
+ profiles: ["schema-init"]
command: [ bin/create-schema.sh ]
Review Comment:
In ```create/upgrade-schema.sh``` will ```source bin/env/dolphinscheduler-env.sh```. I think the ```.env``` file may not working in containers currently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10026: [Bug] fix docker-compose init schema
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#discussion_r872986241
##########
deploy/docker/docker-compose.yml:
##########
@@ -51,6 +55,7 @@ services:
dolphinscheduler-schema-initializer:
image: ${HUB}/dolphinscheduler-tools:${TAG}
env_file: .env
+ profiles: ["schema-init"]
command: [ bin/create-schema.sh ]
Review Comment:
In ```create/upgrade-schema.sh``` will ```source bin/dolphinscheduler-env.sh```. I think the ```.env``` file may not working in containers currently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #10026: [Bug] fix run on docker and k8s
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#discussion_r873305198
##########
docs/docs/en/guide/start/docker.md:
##########
@@ -56,7 +56,15 @@ $ tar -zxf apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src.tar.gz
$ cd apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src/deploy/docker
# For Windows users
$ cd apache-dolphinscheduler-"${DOLPHINSCHEDULER_VERSION}"-src\deploy\docker
Review Comment:
> I think we should only provide one single command to our users which they could directly copy paste and the command. They should see our comment or note only if they use another system
OK, I had changed my mind and updated it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10026: [Bug] fix run on docker and k8s
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10026:
URL: https://github.com/apache/dolphinscheduler/pull/10026#discussion_r873142317
##########
deploy/docker/docker-compose.yml:
##########
@@ -51,6 +55,7 @@ services:
dolphinscheduler-schema-initializer:
image: ${HUB}/dolphinscheduler-tools:${TAG}
env_file: .env
+ profiles: ["schema-init"]
command: [ bin/create-schema.sh ]
Review Comment:
Oh....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org