You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/10/07 19:44:34 UTC
[PR] Move dependency analysis into main PR workflow [camel]
gnodet opened a new pull request, #27506:
URL: https://github.com/apache/camel/pull/27506
The standalone `dep-check.yml` workflow had two problems:
1. It ran a full redundant build (~20 min) just to execute pilot
2. It was silently failing due to `continue-on-error: true`: pilot-plugin 0.4.0 crashes on modules that declare test-scoped deps but have no `src/test/java` (e.g. `bom-generator-maven-plugin`)
## Changes
- **Remove `dep-check.yml`** — no more redundant standalone rebuild (the disable is tracked in #27513)
- **Add a pilot step to `pr-build-main.yml`** — runs only on the JDK 25 matrix entry, *after* `mvn test` (so `target/test-classes` exists for correct test-scope analysis). No extra build cost.
- **Bind the goal to the `verify` phase** in the `dep-check` profile so the workflow just calls `./mvnw verify -Pdep-check -DskipTests`: version lives only in `pom.xml` `pluginManagement`, Dependabot can track it there.
- **Keep `continue-on-error: true`** / report mode — flip to `-Dpilot.action=check` once the report is clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move dependency analysis into main PR workflow, upgrade to pilot 0.9.0 [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #27506:
URL: https://github.com/apache/camel/pull/27506#issuecomment-6045475824
Closing in favor of two separate PRs: one to simply disable the workflow, one to properly fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move dependency analysis into main PR workflow, upgrade to pilot 0.9.0 [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27506:
URL: https://github.com/apache/camel/pull/27506#issuecomment-6039679136
<!-- ci-tested-modules -->
:information_source: CI did not run targeted module tests.
---
<details><summary>:microscope: Scalpel shadow comparison — Scalpel: 18 of 699 tested, 4 compile-only — current: 0 all tested</summary>
[Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **18 affected modules** (current approach: 0).
**Skip-tests mode would test 18 modules** (7 direct + 4 downstream), **skip tests for 4** (generated code, meta-modules)
<details><summary>:warning: Modules only in Scalpel (18)</summary>
- `camel-etc`
- `camel-jbang-mcp`
- `camel-jbang-plugin-mcp`
- `camel-jbang-plugin-route-parser`
- `camel-jbang-plugin-tui`
- `camel-jbang-plugin-validate`
- `camel-jpa`
- `camel-launcher-container`
- `camel-opentelemetry`
- `camel-salesforce`
- `camel-salesforce-codegen`
- `camel-salesforce-parent`
- `camel-servicenow`
- `camel-servicenow-maven-plugin`
- `camel-servicenow-parent`
- `camel-wasm`
- `camel-yaml-dsl-validator`
- `camel-yaml-dsl-validator-maven-plugin`
</details>
<details><summary>Modules Scalpel would test (18)</summary>
- `camel-etc` ← effective property workspace
- `camel-jbang-mcp` ← depends on affected reactor module org.apache.camel:camel-yaml-dsl-validator
- `camel-jbang-plugin-mcp` ← depends on affected reactor module org.apache.camel:camel-jbang-core
- `camel-jbang-plugin-route-parser` ← depends on affected reactor module org.apache.camel:camel-route-parser
- `camel-jbang-plugin-tui` ← depends on affected reactor module org.apache.camel:camel-yaml-dsl-validator
- `camel-jbang-plugin-validate` ← depends on affected reactor module org.apache.camel:camel-yaml-dsl-validator
- `camel-jpa` ← effective property camel.surefire.fork.additional-vmargs
- `camel-launcher-container` ← effective property docker.context
- `camel-opentelemetry` ← effective property opentracing-agent.lib
- `camel-salesforce` ← downstream of org.apache.camel:camel-salesforce-parent
- `camel-salesforce-codegen` ← downstream of org.apache.camel:camel-salesforce-parent
- `camel-salesforce-parent` ← effective property salesforce.component.root
- `camel-servicenow` ← downstream of org.apache.camel:camel-servicenow-parent
- `camel-servicenow-maven-plugin` ← downstream of org.apache.camel:camel-servicenow-parent
- `camel-servicenow-parent` ← effective property servicenow.component.root
- `camel-wasm` ← effective property camel.surefire.fork.additional-vmargs
- `camel-yaml-dsl-validator` ← depends on affected reactor module org.apache.camel:camel-catalog
- `camel-yaml-dsl-validator-maven-plugin` ← depends on affected reactor module org.apache.camel:camel-yaml-dsl-validator
</details>
<details><summary>Modules with tests skipped (4)</summary>
- `camel-itest`
- `camel-salesforce-maven-plugin`
- `camel-yaml-dsl`
- `camel-yaml-dsl-deserializers`
</details>
> :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
</details>
<details><summary>All tested modules (46 modules, 8m 53s total)</summary>
**Total reactor time:** 8m 53s
| Module | Duration | Status |
| --- | --- | --- |
| Camel :: Launcher | 55.6s | SUCCESS |
| Camel :: Salesforce | 53.0s | SUCCESS |
| Camel :: JPA | 50.7s | SUCCESS |
| Camel :: JBang :: Plugin :: TUI | 48.0s | SUCCESS |
| Camel :: JBang :: MCP | 45.4s | SUCCESS |
| Camel :: OpenTelemetry (deprecated) | 30.4s | SUCCESS |
| Camel :: Catalog :: Camel Catalog | 25.5s | SUCCESS |
| Camel :: YAML DSL :: Validator | 21.5s | SUCCESS |
| Camel :: Component DSL | 21.0s | SUCCESS |
| Camel :: YAML DSL | 19.8s | SUCCESS |
| Camel :: JBang :: Plugin :: Validate | 16.8s | SUCCESS |
| Camel :: Docs | 16.5s | SUCCESS |
| Camel :: JBang :: Plugin :: Testing | 13.8s | SUCCESS |
| Camel :: Wasm | 13.8s | SUCCESS |
| Camel :: JBang :: Plugin :: Kubernetes | 12.7s | SUCCESS |
| Camel :: Kamelet Main | 12.1s | SUCCESS |
| Camel :: Salesforce :: Maven Plugin | 8.6s | SUCCESS |
| Camel :: YAML DSL :: Deserializers | 7.5s | SUCCESS |
| Camel :: Catalog :: Camel Report Maven Plugin | 7.1s | SUCCESS |
| Camel :: Catalog :: Camel Route Parser | 7.0s | SUCCESS |
| Camel :: ServiceNow :: Component | 6.0s | SUCCESS |
| Camel :: YAML DSL :: Validator Maven Plugin | 5.0s | SUCCESS |
| Camel :: All Components Sync point | 4.6s | SUCCESS |
| Camel :: ServiceNow :: Maven Plugin | 4.5s | SUCCESS |
| Camel :: Catalog :: Maven | 3.6s | SUCCESS |
| Camel :: ServiceNow :: Parent | 2.5s | SUCCESS |
| Camel :: Catalog :: Suggest (deprecated) | 2.5s | SUCCESS |
| Camel :: Salesforce :: Parent | 1.9s | SUCCESS |
| Camel :: Assembly | 1.9s | SUCCESS |
| Camel :: YAML DSL :: Maven Plugins | 1.8s | SUCCESS |
| Camel :: Salesforce :: CodeGen | 1.6s | SUCCESS |
| Camel :: JBang :: Plugin :: Edit | 1.5s | SUCCESS |
| Camel :: JBang :: Plugin :: MCP | 1.4s | SUCCESS |
| Camel :: Coverage | 1.3s | SUCCESS |
| Camel :: Endpoint DSL :: Support | 1.1s | SUCCESS |
| Camel :: JBang :: Plugin :: Generate | 1.0s | SUCCESS |
| Camel :: JBang :: Integration tests | 0.9s | SUCCESS |
| Camel :: JBang :: Main | 0.8s | SUCCESS |
| Camel :: JBang :: Plugin :: Route Parser | 0.8s | SUCCESS |
| Camel :: Catalog :: Console | 0.7s | SUCCESS |
| Camel :: Catalog :: Dummy Component | 0.6s | SUCCESS |
| Camel :: Launcher :: Container | 0.4s | SUCCESS |
| Camel :: Etc | 0.2s | SUCCESS |
| Camel :: Endpoint DSL | n/a | |
| Camel :: Integration Tests | n/a | |
| Camel :: JBang :: Core | n/a | |
**Top 20 slowest modules:**
- `Camel :: Launcher` (55.6s)
- `Camel :: Salesforce` (53.0s)
- `Camel :: JPA` (50.7s)
- `Camel :: JBang :: Plugin :: TUI` (48.0s)
- `Camel :: JBang :: MCP` (45.4s)
- `Camel :: OpenTelemetry (deprecated)` (30.4s)
- `Camel :: Catalog :: Camel Catalog` (25.5s)
- `Camel :: YAML DSL :: Validator` (21.5s)
- `Camel :: Component DSL` (21.0s)
- `Camel :: YAML DSL` (19.8s)
- `Camel :: JBang :: Plugin :: Validate` (16.8s)
- `Camel :: Docs` (16.5s)
- `Camel :: JBang :: Plugin :: Testing` (13.8s)
- `Camel :: Wasm` (13.8s)
- `Camel :: JBang :: Plugin :: Kubernetes` (12.7s)
- `Camel :: Kamelet Main` (12.1s)
- `Camel :: Salesforce :: Maven Plugin` (8.6s)
- `Camel :: YAML DSL :: Deserializers` (7.5s)
- `Camel :: Catalog :: Camel Report Maven Plugin` (7.1s)
- `Camel :: Catalog :: Camel Route Parser` (7.0s)
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/37629401094)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move dependency analysis into main PR workflow, upgrade to pilot 0.9.0 [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #27506:
URL: https://github.com/apache/camel/pull/27506#discussion_r4210389719
##########
pom.xml:
##########
@@ -996,21 +996,35 @@
<profile>
<!--
Opt-in dependency analysis profile.
- Usage: mvn compile pilot:dependencies -Pdep-check -Dpilot.skipTestScope=true [-Dpilot.action=check]
+ Usage: mvn verify -Pdep-check [-Dpilot.action=check]
Leverages eu.maveniverse.maven.plugins:pilot-plugin:dependencies for
bytecode-level analysis: detects unused declared and used transitive deps.
Non-blocking by default (report mode); use -Dpilot.action=check to fail
the build on findings, or -Dpilot.action=fix to apply fixes to pom.xml.
- Use -Dpilot.skipTestScope=true to skip test-scoped dependency analysis.
-->
<id>dep-check</id>
<build>
+ <plugins>
+ <plugin>
+ <groupId>eu.maveniverse.maven.plugins</groupId>
+ <artifactId>pilot-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>dep-check</id>
+ <goals>
+ <goal>dependencies</goal>
+ </goals>
+ <phase>verify</phase>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
<pluginManagement>
<plugins>
<plugin>
<groupId>eu.maveniverse.maven.plugins</groupId>
<artifactId>pilot-plugin</artifactId>
- <version>0.5.0</version>
+ <version>0.9.0</version>
Review Comment:
`pilot-plugin:0.9.0` does not resolve from Central (latest there is 0.5.0), and the JDK 25 job on this PR failed this step with `Could not find artifact eu.maveniverse.maven.plugins:pilot-plugin:jar:0.9.0`. Is the release still pending?
##########
.github/workflows/pr-build-main.yml:
##########
@@ -205,6 +205,24 @@ jobs:
with:
name: incremental-test-java-${{ matrix.java }}.log
path: incremental-test.log
+ - name: Dependency analysis
+ # Run only on JDK 25 (the primary matrix entry) to avoid duplicating the
+ # 20-minute run. Runs after mvn test so that target/test-classes exists.
+ # Non-blocking for now (report mode); switch to -Dpilot.action=check once
+ # the report is clean.
+ if: matrix.java == '25'
+ continue-on-error: true
+ run: |
+ ./mvnw verify -Pdep-check -DskipTests -Dlicense.skip \
+ --no-transfer-progress --batch-mode \
+ 2>&1 | tee dep-check-output.txt
Review Comment:
Without `set -o pipefail`, this step's exit status is `tee`'s, so a failing `-Dpilot.action=check` would be reported as success later on.
```suggestion
2>&1 | tee dep-check-output.txt; exit ${PIPESTATUS[0]}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move dependency analysis into main PR workflow, upgrade to pilot 0.9.0 [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet closed pull request #27506: Move dependency analysis into main PR workflow, upgrade to pilot 0.9.0
URL: https://github.com/apache/camel/pull/27506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Temporarily disable dependency analysis CI job [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27506:
URL: https://github.com/apache/camel/pull/27506#issuecomment-6038780161
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org