You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "XiaoFeiASK (via GitHub)" <gi...@apache.org> on 2026/07/22 09:26:21 UTC
[PR] Fix(generic) reject unsupported generic modes [dubbo-go]
XiaoFeiASK opened a new pull request, #3501:
URL: https://github.com/apache/dubbo-go/pull/3501
### What this PR does
Part of #3472 (泛化调用优化).
This PR covers the `filter/generic` validation slice. Previously, some generic call paths silently fell back to the Map generalizer when an unknown generic mode was configured, which made configuration mistakes such as `generic=bad-type` hard to diagnose.
This PR makes unsupported generic modes fail with a clear error in the consumer/provider filter paths instead of continuing with the default Map mode.
### Changes
- **`filter/generic/util.go`**
- Change `getGeneralizer` to return `(Generalizer, error)`.
- Accept `true`, `gson`, `bean`, `protobuf-json`, and legacy `protobuf`.
- Return `unsupported generic mode` for unknown values.
- Add shared mode resolution for configured URL mode and invocation attachment mode.
- **`filter/generic/filter.go`**
- Validate generic mode before rewriting consumer generic invocations.
- Propagate invalid mode errors instead of invoking with a fallback generalizer.
- Keep `generic=false` and empty URL generic as pass-through behavior.
- Use the resolved generic mode when setting outgoing invocation attachments.
- Validate generic mode before typed reply deserialization in `OnResponse`.
- **`filter/generic/service_filter.go`**
- Validate provider-side generic invocation mode before realizing arguments.
- Return clear errors for unsupported modes.
- Validate generic mode before generalizing provider responses.
- **Tests**
- Cover unsupported generic modes.
- Cover `generic=false` and empty generic pass-through behavior.
- Cover invocation attachment override and invalid attachment rejection.
- Cover legacy `protobuf` as a supported compatibility value.
### Note for reviewers
This PR only handles the `filter/generic` strict-validation part of #3472.
Follow-up PRs will cover typed result behavior, `InvokeWithType` mode awareness, Triple generic mode detection, and `GenericException` alias exposure. The generic mode policy should stay aligned across `client`, `filter/generic`, and `protocol/triple`.
### Verification
`go test ./filter/generic`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix(generic) reject unsupported generic modes [dubbo-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #3501:
URL: https://github.com/apache/dubbo-go/pull/3501#discussion_r3630150641
##########
filter/generic/util.go:
##########
@@ -52,27 +50,71 @@ func isMakingAGenericCall(invoker base.Invoker, invocation base.Invocation) bool
// isGeneric receives a generic field from url of invoker to determine whether the service is generic or not
func isGeneric(generic string) bool {
- return strings.EqualFold(generic, constant.GenericSerializationDefault) ||
- strings.EqualFold(generic, constant.GenericSerializationGson) ||
- strings.EqualFold(generic, constant.GenericSerializationProtobufJson) ||
- strings.EqualFold(generic, constant.GenericSerializationBean)
+ _, err := getGeneralizer(generic)
+ return err == nil
+}
+
+func isGenericDisabled(generic string) bool {
+ return generic == "" || strings.EqualFold(generic, "false")
}
-func getGeneralizer(generic string) (g generalizer.Generalizer) {
+// getGeneralizer resolves a generic mode to its generalizer.
+// Recommended modes are true, gson, bean, and protobuf-json. protobuf is
+// accepted as a legacy alias of protobuf-json for compatibility.
+func getGeneralizer(generic string) (generalizer.Generalizer, error) {
switch {
case strings.EqualFold(generic, constant.GenericSerializationDefault):
- g = generalizer.GetMapGeneralizer()
+ return generalizer.GetMapGeneralizer(), nil
case strings.EqualFold(generic, constant.GenericSerializationGson):
- g = generalizer.GetGsonGeneralizer()
- case strings.EqualFold(generic, constant.GenericSerializationProtobufJson):
- g = generalizer.GetProtobufJsonGeneralizer()
+ return generalizer.GetGsonGeneralizer(), nil
+ case strings.EqualFold(generic, constant.GenericSerializationProtobufJson),
+ strings.EqualFold(generic, constant.GenericSerializationProtobuf):
Review Comment:
[P1] 不要把 legacy `protobuf` 直接映射为 `protobuf-json`
`generic=protobuf` 目前还是 Triple generic invoker/外层 protobuf wrapper 使用的历史标记，内部 `$invoke` 参数仍可能是 Hessian2 对象，并不等价于 protobuf JSON。用同一个 `$invoke`（attachment 为 `protobuf`、实参为 Hessian 字符串 `world`）做 Base/Head overlay：Base `b87881aa` 能调用下游；当前 Head `97894301` 在这里选择 `ProtobufJsonGeneralizer` 后报 `the type of obj(=string) should be proto.Message`，下游未被调用。建议保留该历史模式原有的 Map/Hessian 语义，或拆分 transport marker 与 generalizer mode；同时补一条真实 Triple `$invoke` 的兼容回归测试，而不是只验证 `protobuf` 与 `protobuf-json` 返回同一 generalizer。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix(generic) reject unsupported generic modes [dubbo-go]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl merged PR #3501:
URL: https://github.com/apache/dubbo-go/pull/3501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix(generic) reject unsupported generic modes [dubbo-go]
Posted by "XiaoFeiASK (via GitHub)" <gi...@apache.org>.
XiaoFeiASK commented on PR #3501:
URL: https://github.com/apache/dubbo-go/pull/3501#issuecomment-5048861865
新增修改
- filter/generic/util.go
问题: generic=protobuf 被直接映射为 ProtobufJsonGeneralizer，导致 legacy Triple $invoke 中的 Hessian/String 参数被误按 protobuf JSON 处理，下游方法未被调用。
修复: 拆分 protobuf 与 protobuf-json 映射，protobuf-json 使用 ProtobufJsonGeneralizer，protobuf 恢复为 MapGeneralizer。
影响: 保留历史 Triple generic invoker 的 Map/Hessian 语义，避免兼容性回归。
- filter/generic/util_test.go
问题: 测试错误验证 protobuf 与 protobuf-json 使用同一个 generalizer。
修复: 将 generic=protobuf 的期望结果改为 MapGeneralizer。
影响: 测试与 legacy protobuf 兼容行为保持一致。
- filter/generic/filter_test.go
问题: protobuf-legacy 测试使用 protobuf message，未覆盖 legacy Map/Hessian 语义。
修复: 改为普通 POJO 参数，并断言泛化结果为 map[string]any。
影响: 覆盖 consumer 侧 generic=protobuf 继续走 Map/Hessian 泛化逻辑。
- filter/generic/service_filter_test.go
问题: 缺少 $invoke + generic=protobuf + Hessian string 参数的兼容回归测试。
修复: 新增 legacy generic $invoke 测试，参数为 []hessian.Object{"world"}，目标方法为 Hello(string)，断言返回 hello, world。
影响: 防止 legacy generic $invoke 的 Map/Hessian 兼容行为再次回归。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix(generic) reject unsupported generic modes [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3501:
URL: https://github.com/apache/dubbo-go/pull/3501#issuecomment-5102303199
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3501) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3501&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3501&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3501&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3501&metric=new_coverage&view=list)
 [8.5% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3501&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3501)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix(generic) reject unsupported generic modes [dubbo-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on PR #3501:
URL: https://github.com/apache/dubbo-go/pull/3501#issuecomment-5053346882
以后提交 PR，记得把代码提交到 develop 分支。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix(generic) reject unsupported generic modes [dubbo-go]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl commented on PR #3501:
URL: https://github.com/apache/dubbo-go/pull/3501#issuecomment-5066762140
> https://github.com/apache/dubbo-go/actions/runs/29998967425/job/89179480271?pr=3501 请问这个卡网络应该怎么解决，我尝试提交空commit重试但是没用，我应该修改integration_test把dubbo-go 依赖从远程下载改成本地源码引用吗？
现在好了 应该是github的问题
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix(generic) reject unsupported generic modes [dubbo-go]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl commented on PR #3501:
URL: https://github.com/apache/dubbo-go/pull/3501#issuecomment-5053481541
这个pr和 #3500 干的是同一个事情吗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix(generic) reject unsupported generic modes [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3501:
URL: https://github.com/apache/dubbo-go/pull/3501#issuecomment-5055979604
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3501) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3501&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3501&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3501&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3501&metric=new_coverage&view=list)
 [8.5% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3501&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3501)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix(generic) reject unsupported generic modes [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3501:
URL: https://github.com/apache/dubbo-go/pull/3501#issuecomment-5053934709
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3501) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3501&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3501&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3501&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3501&metric=new_coverage&view=list)
 [8.5% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3501&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3501)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix(generic) reject unsupported generic modes [dubbo-go]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3501:
URL: https://github.com/apache/dubbo-go/pull/3501#issuecomment-5048612523
## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/3501?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.62500%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.44%. Comparing base ([`b87881a`](https://app.codecov.io/gh/apache/dubbo-go/commit/b87881aa2982cdef7b8e7a74a78b3b9682c5af48?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9789430`](https://app.codecov.io/gh/apache/dubbo-go/commit/97894301109b41b516d7175433accbc317e41435?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/dubbo-go/pull/3501?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [filter/generic/filter.go](https://app.codecov.io/gh/apache/dubbo-go/pull/3501?src=pr&el=tree&filepath=filter%2Fgeneric%2Ffilter.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZmlsdGVyL2dlbmVyaWMvZmlsdGVyLmdv) | 86.66% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/3501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [filter/generic/service\_filter.go](https://app.codecov.io/gh/apache/dubbo-go/pull/3501?src=pr&el=tree&filepath=filter%2Fgeneric%2Fservice_filter.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZmlsdGVyL2dlbmVyaWMvc2VydmljZV9maWx0ZXIuZ28=) | 85.71% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/3501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [filter/generic/util.go](https://app.codecov.io/gh/apache/dubbo-go/pull/3501?src=pr&el=tree&filepath=filter%2Fgeneric%2Futil.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZmlsdGVyL2dlbmVyaWMvdXRpbC5nbw==) | 94.28% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/3501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #3501 +/- ##
==========================================
+ Coverage 54.36% 54.44% +0.07%
==========================================
Files 462 462
Lines 35585 35623 +38
==========================================
+ Hits 19345 19394 +49
+ Misses 14703 14689 -14
- Partials 1537 1540 +3
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/dubbo-go/pull/3501?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix(generic) reject unsupported generic modes [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3501:
URL: https://github.com/apache/dubbo-go/pull/3501#issuecomment-5053841931
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3501) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3501&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3501&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3501&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3501&metric=new_coverage&view=list)
 [8.5% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3501&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3501)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix(generic) reject unsupported generic modes [dubbo-go]
Posted by "XiaoFeiASK (via GitHub)" <gi...@apache.org>.
XiaoFeiASK commented on PR #3501:
URL: https://github.com/apache/dubbo-go/pull/3501#issuecomment-5053538982
> 以后提交 PR，记得把代码提交到 develop 分支。
okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix(generic) reject unsupported generic modes [dubbo-go]
Posted by "XiaoFeiASK (via GitHub)" <gi...@apache.org>.
XiaoFeiASK commented on PR #3501:
URL: https://github.com/apache/dubbo-go/pull/3501#issuecomment-5066378504
https://github.com/apache/dubbo-go/actions/runs/29998967425/job/89179480271?pr=3501 请问这个卡网络应该怎么解决，我尝试解决包括提交空commit重试但是没用
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix(generic) reject unsupported generic modes [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3501:
URL: https://github.com/apache/dubbo-go/pull/3501#issuecomment-5057297179
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3501) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3501&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3501&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3501&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3501&metric=new_coverage&view=list)
 [8.5% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3501&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3501)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix(generic) reject unsupported generic modes [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3501:
URL: https://github.com/apache/dubbo-go/pull/3501#issuecomment-5048910906
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3501) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3501&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3501&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3501&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3501&metric=new_coverage&view=list)
 [8.5% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3501&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3501)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix(generic) reject unsupported generic modes [dubbo-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on PR #3501:
URL: https://github.com/apache/dubbo-go/pull/3501#issuecomment-5077166260
当前代码审查角度未发现仍未修复的 P0/P1；此前 `generic=protobuf` 被错误映射到 `ProtobufJsonGeneralizer` 的兼容性问题已修复，并已通过 legacy Hessian `$invoke` 行为探针、目标单测、Race、Vet、全仓测试和提交 blob 格式检查。
当前 Head：`8f1a18c50fcb0d3a34b06cf37e70764d93792ff5`。
GitHub 实时状态：
- `OPEN`
- `MERGEABLE/CLEAN`
- 8 项 checks 全部 `SUCCESS`
- 无未解决的 current review thread
- `reviewDecision` 为空
因此，当前唯一阻止给出 ✅ 可 Merge 结论的门禁是 `reviewDecision` 为空，尚无法确认仓库要求的 Review/Approval 门禁已经满足。待维护者完成所需 Review，并确认 Head 未发生变化后，才可以给出完整的可 Merge 结论；如果 Head 变化，需要基于新 Head 重新复核 Diff、checks 和 review threads。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix(generic) reject unsupported generic modes [dubbo-go]
Posted by "XiaoFeiASK (via GitHub)" <gi...@apache.org>.
XiaoFeiASK commented on PR #3501:
URL: https://github.com/apache/dubbo-go/pull/3501#issuecomment-5066781045
> > https://github.com/apache/dubbo-go/actions/runs/29998967425/job/89179480271?pr=3501 请问这个卡网络应该怎么解决，我尝试提交空commit重试但是没用，我应该修改integration_test把dubbo-go 依赖从远程下载改成本地源码引用吗？
>
> 现在好了 应该是github的问题
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix(generic) reject unsupported generic modes [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3501:
URL: https://github.com/apache/dubbo-go/pull/3501#issuecomment-5044156215
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3501) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3501&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3501&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3501&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3501&metric=new_coverage&view=list)
 [6.6% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3501&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3501)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix(generic) reject unsupported generic modes [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3501:
URL: https://github.com/apache/dubbo-go/pull/3501#issuecomment-5044718749
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3501) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3501&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3501&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3501&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3501&metric=new_coverage&view=list)
 [8.7% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3501&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3501)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix(generic) reject unsupported generic modes [dubbo-go]
Posted by "XiaoFeiASK (via GitHub)" <gi...@apache.org>.
XiaoFeiASK commented on PR #3501:
URL: https://github.com/apache/dubbo-go/pull/3501#issuecomment-5053661099
#3500 主要做的是 client 侧：
- 在创建引用时就校验 generic type
- 把 WithGenericType / NewGenericService 的语义讲清楚
- 处理的是“配置写错要尽早报错”这条线
#3501 主要做的是 filter/generic 侧：
- 在 consumer/provider filter 里拦截并校验 generic mode
- 避免 unknown mode 静默回退
- 还修了 protobuf 这类 legacy 兼容语义
不是重复 PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix(generic) reject unsupported generic modes [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3501:
URL: https://github.com/apache/dubbo-go/pull/3501#issuecomment-5044362146
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3501) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3501&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3501&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3501&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3501&metric=new_coverage&view=list)
 [8.7% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3501&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3501)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] Fix(generic) reject unsupported generic modes [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3501:
URL: https://github.com/apache/dubbo-go/pull/3501#issuecomment-5056875901
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3501) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3501&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3501&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3501&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3501&metric=new_coverage&view=list)
 [8.5% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3501&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3501)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org