You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/13 21:12:07 UTC
[GitHub] [airflow] kaxil opened a new pull request #18218: Chart: Allow running and waiting for DB Migrations using default image
kaxil opened a new pull request #18218:
URL: https://github.com/apache/airflow/pull/18218
This keeps the same behaviour but allows setting `useDefaultImageForMigration` to `true` which will then use the default image (set by `.Values.defaultAirflowRepository` and `.Values.defaultAirflowTag`) to run and wait for DB migration.
This safeguards issues with dependency and other user codes like badly written dags, etc
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18218: Chart: Allow running and waiting for DB Migrations using default image
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18218:
URL: https://github.com/apache/airflow/pull/18218#issuecomment-918640084
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #18218: Chart: Allow running and waiting for DB Migrations using default image
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #18218:
URL: https://github.com/apache/airflow/pull/18218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed pull request #18218: Chart: Allow running and waiting for DB Migrations using default image
Posted by GitBox <gi...@apache.org>.
kaxil closed pull request #18218:
URL: https://github.com/apache/airflow/pull/18218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #18218: Chart: Allow running and waiting for DB Migrations using default image
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #18218:
URL: https://github.com/apache/airflow/pull/18218#discussion_r707753920
##########
File path: chart/values.schema.json
##########
@@ -613,6 +613,12 @@
}
]
},
+ "useDefaultImageForMigration": {
+ "description": "To avoid images with user code for running and waiting for DB migrations set this to ``true``. ",
+ "type": "boolean",
+ "x-docsSection": "Airflow",
Review comment:
```suggestion
"x-docsSection": "Images",
```
I feel like this is a better place?
##########
File path: chart/values.yaml
##########
@@ -232,6 +232,12 @@ extraEnvFrom: ~
# - configMapRef:
# name: '{{ .Release.Name }}-airflow-variables'
+# To avoid images with user code, you can turn this to 'true' and
+# all the 'run-airflow-migrations' and 'wait-for-airflow-migrations' containers/jobs
+# will use the images from 'defaultAirflowRepository:defaultAirflowTag' values
+# to run and wait for DB migrations .
+useDefaultImageForMigration: false
Review comment:
Can we move this directly under `images` instead? Seems like a better fit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org